User MaxSem changed the status of MediaWiki.r85940.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85940#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Tim Starling posted a comment on MediaWiki.r85207.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85207#c15902
Comment:
We use sigma (i.e. radius) 0.8 on Wikimedia now. We used sigma=0.4 with older
versions of ImageMagick, because the matrix had some truncation applied to
User Krinkle posted a comment on MediaWiki.r85931.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85931#c15903
Comment:
This file was not altered in r85928. Where does this come from ?
___
MediaWiki-CodeReview mailing list
User Krinkle changed the status of MediaWiki.r85929.
Old Status: new
New Status: fixme
User Krinkle also posted a comment on MediaWiki.r85929.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c15904
Comment:
After up'ing to this revision my local wiki doesn't do anything
* Srikanth Lakshmanan srik@gmail.com [Tue, 12 Apr 2011 22:29:33
+0530]:
Hi all,
Sharing of URLs of non latin wiki's werent really easy and when copy
pasting
we get the unicode numerals in the URL like
User Happy-melon posted a comment on MediaWiki.r85929.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c15905
Comment:
This is a result of having multiple separate things going on in my working copy
at the same time and trying to break up commits. The Action class exists
User Happy-melon changed the status of MediaWiki.r85929.
Old Status: fixme
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85929#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Happy-melon posted a comment on MediaWiki.r85931.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85931#c15906
Comment:
This was fixing r85929, not r85928.
___
MediaWiki-CodeReview mailing list
User Happy-melon changed the status of MediaWiki.r85939.
Old Status: new
New Status: ok
User Happy-melon also posted a comment on MediaWiki.r85939.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85939#c15907
Comment:
Looks like we were all off form last night tt:D/tt
User DieBuche posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15908
Comment:
Thanks! Strict fixed in r85941
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Raymond posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15909
Comment:
Could you please create a page with a few examples of the new possibilities at
Translatewiki?
___
User DieBuche posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15910
Comment:
It doesn't add any new syntax, but simply renders stuff like
http://translatewiki.net/wiki/TablesSandbox semantically correct. (Headers are
actually theads,
User Raymond posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15911
Comment:
Thanks for the example. I was confused by the proposal for new syntax of the
bug reporter.
___
User Bryan posted a comment on MediaWiki.r85922.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85922#c15912
Comment:
Welcome to commit land!
I have some advise for you, mostly related to code style. See also
[[Manual:Coding conventions]].
You should
User Mormegil posted a comment on MediaWiki.r85876.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85876#c15913
Comment:
The code using ''Emailnotarget'' is broken: Since codetarget/code is used
only if code$par/code is not received, you are not able to override a bad
username
This coming week, I'd like to focus on any User Interface bugs. One of
the lessons I learned from this last triage, though, is that we want to
keep the bug reports current. With the introduction of ResourceLoader,
this shouldn't be any trouble, but I want to make it clear that I will
remove
User Reedy posted a comment on MediaWiki.r85804.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85804#c15914
Comment:
Please make sure you enable the PHP STRICT stuff when testing stuff.
You caused a STRICT warning/error which was fixed in r85948
See [[Manual:How_to_debug]]
Very cool. Especially given the development trajectory of Ace to become
the eclipse of web IDEs there will be a lot of interesting
possibilities as we could develop our own mediaWiki centric plugins for
the platform.
I can't help but think about where this is ideally headed ;)
A gitorius type
User MaxSem changed the status of MediaWiki.r85885.
Old Status: fixme
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On 13.04.2011, 8:03 Tim wrote:
On 13/04/11 02:41, Max Semenik wrote:
It's DB2-only fixes, nothing scary about backporting it.
Historically, DBMS support patches have touched a lot of query
building code, and have caused bugs for MySQL. We should decide
whether we want to backport it when we
User P.Copp posted a comment on MediaWiki.r85804.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85804#c15915
Comment:
No idea how I missed that one. Anyway, thanks for the fix!
___
MediaWiki-CodeReview mailing list
User Bryan posted a comment on MediaWiki.r85207.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85207#c15916
Comment:
Well, that is an interesting way to calculate a sharpening matrix. But I guess
if it works for them it will work for us as well.
For
In last week's triage meeting we tended to surface really, really old
bugs that only surface under edge or corner cases.
For example, I now am assigned bug #93 which deals with how behaves
inside nowiki. This is the paradigmatic example of a corner case. This
isn't preventing anyone from
User Reedy changed the status of MediaWiki.r85959.
Old Status: new
New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85959#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User MaxSem posted a comment on MediaWiki.r85885.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15917
Comment:
The message There must be a tablespace with at least 32k of pagesize looks
like it needs some tweaks.
___
User MaxSem changed the status of MediaWiki.r85890.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85890#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
Neil Kandalgaonkar ne...@wikimedia.org writes:
Maybe the Bugmeister role is still being defined, but I think it would
be most helpful if we used these sessions to catch bugs that were
important, but for one reason or another fell through the cracks.
Neil,
Thanks for your comments and
User Catrope changed the status of MediaWiki.r85961.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85961#c0
___
MediaWiki-CodeReview mailing list
On Wed, Apr 13, 2011 at 7:23 AM, Michael Dale md...@wikimedia.org wrote:
Very cool. Especially given the development trajectory of Ace to become
the eclipse of web IDEs there will be a lot of interesting
possibilities as we could develop our own mediaWiki centric plugins for
the platform.
I
User Catrope changed the status of MediaWiki.r85580.
Old Status: fixme
New Status: resolved
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85580#c0
___
MediaWiki-CodeReview mailing list
User Kaldari posted a comment on MediaWiki.r85655.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85655#c15918
Comment:
This code (along with r85606 and r85648) sets up basic lightboxing behavior for
the image thumbnails. Instead of the thumbnails linking to the full-size
Just came across jsfiddle ( http://jsfiddle.net/ ) via d3 (
https://github.com/mbostock/d3 )
http://jsfiddle.net/mbostock/EVnvj/
Uses CodeMirror http://codemirror.net/
-J
-Original Message-
From: wikitech-l-boun...@lists.wikimedia.org
User ^demon changed the status of MediaWiki.r85671.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85671#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Catrope changed the status of MediaWiki.r84535.
Old Status: resolved
New Status: reverted
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84535#c0
___
MediaWiki-CodeReview mailing list
Until today, an advanced query in our Bugzilla's installation defaulted
to returning bugs marked “WONTFIX” and “LATER”.
Rob and I agreed that we didn't think this wasn't the behavior most
people want so I changed it to remove those resolutions from the
defaults.
Another change I made was to
User Catrope changed the status of MediaWiki.r85962.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85962#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85965.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85965#c0
___
MediaWiki-CodeReview mailing list
On Wed, Apr 13, 2011 at 2:01 PM, Mark A. Hershberger
mhershber...@wikimedia.org wrote:
Until today, an advanced query in our Bugzilla's installation defaulted
to returning bugs marked “WONTFIX” and “LATER”.
We changed this awhile back because we wanted to encourage
people to search for dupes.
User Bryan posted a comment on MediaWiki.r85207.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85207#c15919
Comment:
Done in r85966.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Catrope changed the status of MediaWiki.r85967.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85967#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85968.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85968#c0
___
MediaWiki-CodeReview mailing list
User ^demon changed the status of MediaWiki.r85920.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85920#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Kaldari posted a comment on MediaWiki.r85973.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85973#c15920
Comment:
The -5 is for the file extension, e.g. .jpeg
___
MediaWiki-CodeReview mailing list
User DieBuche changed the status of MediaWiki.r85891.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85891#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User DieBuche changed the status of MediaWiki.r85887.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85887#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User DieBuche changed the status of MediaWiki.r85880.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85880#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On 13.04.2011, 22:01 Mark wrote:
Another change I made was to adjust the default priority to “Low” from
“Normal” so that most bugs don't end up in the priority level that I
want to use for “This should be fixed by next release”. Perhaps many
new bugs should be a priority, but I'd like there
Max Semenik wrote:
On 13.04.2011, 22:01 Mark wrote:
Another change I made was to adjust the default priority to “Low”
from
“Normal” so that most bugs don't end up in the priority level that I
want to use for “This should be fixed by next release”. Perhaps many
new bugs should be a
User MaxSem posted a comment on MediaWiki.r85988.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85988#c15921
Comment:
Please explain what that bug is about in commit summary, it's much easier to
review this way.
___
User DieBuche posted a comment on MediaWiki.r85988.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85988#c15922
Comment:
Ok, will do next time
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On Wed, Apr 13, 2011 at 2:44 PM, Krinkle krinklem...@gmail.com wrote:
I agree. Defaulting new bugs to a low priority doesn't seem very
friendly
to new users. They don't know (and shouldn't have to know) what the
bugmeister's organization is.
Then make a triage priority and default them all
On 04/09/2011 02:11 PM, Neil Kandalgaonkar wrote:
I assume those of us who thought they registered via the WMF (but
apparently didn't) don't need to do anything?
Yeah, don't worry about it, Carrie at WMF Cornelius from WMDE are
taking care of it.
-Sumana
On Wed, Apr 13, 2011 at 12:44 PM, Krinkle krinklem...@gmail.com wrote:
I agree. Defaulting new bugs to a low priority doesn't seem very
friendly
to new users. They don't know (and shouldn't have to know) what the
bugmeister's organization is.
I thought about replying with a similar response,
Thanks for correcting my error, Danese! Sorry.
I should instead say: if Carrie says to do something, then yes, you need
to do it. :-)
-Sumana
On 04/13/2011 04:18 PM, Danese Cooper wrote:
Not quite right, Sumana...the folks Carrie wrote to over the weekend need to
make sure they are
On Wed, Apr 13, 2011 at 1:15 PM, Rob Lanphier ro...@robla.net wrote:
From a practical perspective, many more bugs than are being marked as
normal are actually normal by this standard. Most of the bugs in
our database are probably low priority in the sense that we just
can't get around to
User Catrope changed the status of MediaWiki.r85914.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85914#c0
___
MediaWiki-CodeReview mailing list
User Svippong posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15923
Comment:
After these changes, tables are behaving incorrectly.
For instance, if you have a header in a table cell, it won't render correctly
if it is at the
User Catrope changed the status of MediaWiki.r85483.
Old Status: fixme
New Status: resolved
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85483#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85969.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85969#c0
___
MediaWiki-CodeReview mailing list
2011/4/13 Mark A. Hershberger mhershber...@wikimedia.org:
This coming week, I'd like to focus on any User Interface bugs.
Here are a couple of bugs that show up to people who like their
paragraphs justified and set up their preferences accordingly:
User Trevor Parscal changed the status of MediaWiki.r85974.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85974#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Trevor Parscal changed the status of MediaWiki.r85964.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85964#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Catrope changed the status of MediaWiki.r85575.
Old Status: fixme
New Status: resolved
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85575#c0
___
MediaWiki-CodeReview mailing list
User Platonides posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15924
Comment:
- if ( $line === '' ) { # empty line, go to next line
+ if ( $line == '') { //empty line, go to next line
Why
User Platonides posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15925
Comment:
I think that's due to the trim(). As the goal of this revision was to add
thead/tfoot, I think it could be stripped back.
User Platonides posted a comment on MediaWiki.r85943.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85943#c15926
Comment:
You should add a parser test.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
Max Semenik maxsem.w...@gmail.com writes:
This may piss people off (what? my bug is not in their plans?!).
How is that different from how we've been pissing people off with ~2500
bugs against MediaWiki that were opened more than six months ago and
have sat, ignored, without resolution.
I think
User Platonides posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15927
Comment:
Did you run the parserTests after your changes? You also broke other 3
parserTests:
* Fuzz testing: Parser14-table...
* Fuzz testing: Parser22...
* Bug
Just to be sure with this, we're not talking about justifying
paragraphs by default? Users must set this preference?
The reason I ask is that paragraph justification is a rather massive
no-no when it comes to usability regarding readers with dyslexia and
some types of visual
Brion Vibber br...@pobox.com writes:
On Wed, Apr 13, 2011 at 1:15 PM, Rob Lanphier ro...@robla.net wrote:
From a practical perspective, many more bugs than are being marked as
normal are actually normal by this standard. Most of the bugs in
our database are probably low priority in the
2011/4/14 Brandon Harris bhar...@wikimedia.org:
Just to be sure with this, we're not talking about justifying
paragraphs by default? Users must set this preference?
Yes. I usually turn it on; now you made me consider turning it off.
The reason I ask is that paragraph
Happy-melon wrote:
What I have done is to move the PHP version check from WebStart.php (which
was unparseable since Tim added a try/catch block in r85327) to the entry
points index.php, api.php, load.php. That way, only those files have to be
PHP 4 compatible.
Don't forget about
User Bryan posted a comment on MediaWiki.r85973.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85973#c15928
Comment:
Note that the maximum length is 255 bytes, while maxlength sets the maximum
amount of characters, as far as I know. So you should still take care that you
User Krinkle changed the status of MediaWiki.r85982.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85982#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
From a practical perspective, many more bugs than are being marked as
normal are actually normal by this standard. Most of the bugs in
our database are probably low priority in the sense that we just
can't get around to fixing all of them. I can see the argument for
making the most common
User Catrope changed the status of MediaWiki.r85990.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85990#c0
___
MediaWiki-CodeReview mailing list
User Helder.wiki posted a comment on MediaWiki.r85902.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85902#c15929
Comment:
Great! :)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
Amir E. Aharoni amir.ahar...@mail.huji.ac.il writes:
Here are a couple of bugs that show up to people who like their
paragraphs justified and set up their preferences accordingly:
https://bugzilla.wikimedia.org/show_bug.cgi?id=20184
https://bugzilla.wikimedia.org/show_bug.cgi?id=28359
I've
User Brion VIBBER changed the status of MediaWiki.r82120.
Old Status: new
New Status: fixme
User Brion VIBBER also posted a comment on MediaWiki.r82120.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82120#c15930
Comment:
This causes a fatal error because it tries to pass a
User Kaldari posted a comment on MediaWiki.r85973.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85973#c15931
Comment:
True. This is just a quick fix for latin scripts. Will work on a more
comprehensive checking mechanism soon.
___
User Happy-melon changed the status of MediaWiki.r82120.
Old Status: fixme
New Status: reverted
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82120#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Trevor Parscal posted a comment on MediaWiki.r85998.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85998#c15932
Comment:
Line 106
+ $data2[$userData['revid']]['ratings'][$id]['count']++;
Should be
+ if ( $value ) {
+
User Trevor Parscal changed the status of MediaWiki.r86000.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86000#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Trevor Parscal changed the status of MediaWiki.r85998.
Old Status: new
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85998#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Catrope changed the status of MediaWiki.r85998.
Old Status: resolved
New Status: new
User Catrope also posted a comment on MediaWiki.r85998.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85998#c15933
Comment:
I did this in r86000, 5 seconds after
User Siebrand changed the status of MediaWiki.r86001.
Old Status: new
New Status: fixme
User Siebrand also posted a comment on MediaWiki.r86001.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86001#c15934
Comment:
Please fix the out-of-context reuse of the message key
User Happy-melon changed the status of MediaWiki.r86001.
Old Status: fixme
New Status: reverted
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86001#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix posted a comment on MediaWiki.r86011.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86011#c15935
Comment:
Some minor [[Manual:Coding conventions|coding style]] issues here:
*$welcome_creation_msg should be called $welcomeCreationMsg
*I'd prefer a space after
User Reedy changed the status of MediaWiki.r86015.
Old Status: new
New Status: fixme
User Reedy also posted a comment on MediaWiki.r86015.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86015#c15936
Comment:
You shouldn't ever be using $_GET or $_POST directly
It also has
User Reedy posted a comment on MediaWiki.r86011.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86011#c15937
Comment:
Also, an onwiki Manual page should be created for the hook
___
MediaWiki-CodeReview mailing list
User Reedy changed the status of MediaWiki.r86014.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86014#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r85996.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85996#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r85993.
Old Status: new
New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85993#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jeroen De Dauw posted a comment on MediaWiki.r85993.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85993#c15939
Comment:
That also seems to work, which I find rather odd, since there must be some
reason I started using the while loop instead of a
User Reedy posted a comment on MediaWiki.r85993.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85993#c15940
Comment:
Nope. It's been the case as long as I can remember.. God knows! Heh :)
___
MediaWiki-CodeReview mailing list
User Reedy changed the status of MediaWiki.r86017.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86017#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r86016.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86016#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy posted a comment on MediaWiki.r85993.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85993#c15938
Comment:
pre
while ( $vote = $votes-fetchObject() ) {
/pre
should really be
pre
foreach( $votes as $vote ) {
/pre
___
User Krinkle changed the status of MediaWiki.r85989.
Old Status: new
New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85989#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r85995.
Old Status: new
New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85995#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
1 - 100 of 103 matches
Mail list logo
