Re: [Wikitech-l] putenv(TZ) hack in LocalSettings.php now gives warnings
Hey Jidanni, you can just eliminate your whole
date_default_timezone_set($wgLocaltimezone);
putenv(TZ=$wgLocaltimezone);$wgLocalTZoffset=date('Z')/60;
line. It's already taken care of for you in includes/Setup.php !
You don't even need to reinstall Mediawiki just to find out how they do
it in the current generated LocalSettings.php .
Don't worry. The next time your wiki stops working because something
needs to be updated in LocalSettings.php just look at the...
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Creating a thumbnail with File::createThumb()
Don't use RENDER_NOW. It's the complete opposite of what he's asking for.
In fact NEVER use RENDER_NOW unless you are absolutely sure that you
absolutely need it.
The only valid use case for RENDER_NOW I can think of is if you intend to
open the file yourself and do extra image processing on it. If you want to
give a user a URL then you NEVER need it.
My input on this subject:
- If your thumbnail size is larger than the image's size then the original
image's url will be returned because it's already big enough (this IS what
you want)
- If you have setup a 404 handler files will only be generated when they
are requested by the user. This IS what you want.
We support generating thumbnails when a file is not found. If a path looks
like a thumbnail it gets sent to thumb.php where it's then rendered, sent
to the user, and saved to the filesystem for future requests.
This has a number of advantages:
- You can delete all your thumbnails if you think you have piles ones not
being used anymore. Since they will all safely be regenerated when used.
- You can use thumbnails inside of css since you know the thumb will
always be usable.
- It speeds up your wiki. Rendering thumbnails takes time. And during the
time that thumbnails are being generated php is frozen. That means that
thumbnail render time adds to your wiki's page load time on upload, save,
previews, view, etc... By using a 404 handler the wiki is capable of
skipping the rendering serving a url and deferring that load time to a
process dedicated to rendering the thumbnail.
- It also lets you dedicate machines to image thumbnailing and allow your
webservers to focus on serving webpages instead of spending cpu time on
image processing.
One of these days I'd like to see if I could write a fuse filesystem that
exposes a cache as a filesystem. ;) then you can mount that as your
filesystem for thumbs/ and have all old thumbnails purged automatically.
(We don't have the capability to delete thumbnails that are no longer used)
On Tue, 27 Mar 2012 22:13:23 -0700, Hunter Fernandes h.g.f...@gmail.com
wrote:
Since no one has replied at this time, I thought I'd give a crack at an
answer (I really don't know if this will work).
Some goodies from a quick scan of thumb.php:
$img = wfLocalFile( $fileName );
$params = array(
'width' = 100,
'height' = 100,
);
$img-transform( $params, File::RENDER_NOW );
$localpath = $thumb-getPath();
$thumbPath = $img-getThumbPath( $thumbName );
That's my guess. I havn't tested it or anything.
- Hunter F.
On Tue, Mar 27, 2012 at 7:03 PM, Daniel Renfro
dren...@vistaprint.comwrote:
MW gurus,
I am working on an API module to an extension and would like to create
thumbnails programmatically for some images (if they don't already have
them.)
The includes/filerepo/File.php file contains a createThumb() method,
which
looks like it's what I want. From the comment block directly above the
aforementioned method:
/**
* Create a thumbnail of the image having the specified width/height.
* The thumbnail will not be created if the width is larger than the
* image's width. Let the browser do the scaling in this case.
* The thumbnail is stored on disk and is only computed if the
thumbnail
* file does not exist OR if it is older than the image.
* Returns the URL.
*
*
*/
However, this method always returns the url of the file itself and not
the
thumb. From what I can tell it never generates the thumbnail (it's not
in
the filesystem repo in any directory.) My code is:
?php
# ...query to get a list of recently uploaded images (quite simple)
$result = $dbr-select();
# loop through them and get a thumbnail url
foreach ( $result as $row ) {
$title = Title::newFromText( $row-page_title, NS_FILE );
$file = wfFindFile( $title );
if ( !$file ) {
continue;
}
$thumbnail_url = $file-createThumb( 80 ); # width in pixels
...add to the API result...
}
...return...
?
I'm sure that my query return valid page titles/namespaces, and that the
files exist (both in the wiki and in the filesystem.) They are all
local,
and some are quite large. I'd hate to have to send the entire image and
make the browser do the scaling, as the thumbnail will get reused and
the
resizing is only done once.
Any ideas fellow MW gurus? What am I missing?
-Daniel Renfro
--
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Creating naming conventions for git branches?
2012/3/21 Diederik van Liere dvanli...@gmail.com: Hi y'all, With the pending git migration upon us,is this also the right time to think about naming conventions for git branches or is there nu such a need? I can imagine that a branch aimed at fixing a bug could be named B12345, or something like that. Or are 'descriptive' names good enough? One reason to have naming conventions is that it would make it easier in the future to run scripts to collect stats on particular branches. That would be much harder in a complete freetext environment. In the few commits i did until now, i usually did called it something like bug_31817_add_bdi_to_allowed_tags. Nobody complained yet. I'm OK with 2012/bug_31817_add_bdi_to_allowed_tags, too, or anything else that will be decided. When i use `git review -d' on a change that was in the aforementioned branch, another branch called review/amire80/bug/31817 is created, so i suppose that Gerrit identified the bug number (or maybe somebody did it manually and i missed it). I don't quite understand why two branches are created for pretty much the same thing. Maybe i should create a branch called review/amire80/bug/31817 in the first place? Or maybe i shouldn't use `git review -d' at all? And, there's also the issue of several branches per one bug, so it's possible that it's not enough. -- Amir Elisha Aharoni ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114549]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r114549 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114549#c32556 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r114549: added i18n for openlayers Nikerabbit's comment: Please use tabs for indentation and add message documentation for new messages. Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114550]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r114550 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114550#c32557 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r114550: added i18n to google service and missing i18n for validation Nikerabbit's comment: Same comments as in previous commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114550]: New comment added
Netbrain posted a comment on MediaWiki.r114550. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114550#c32559 Commit summary for MediaWiki.r114550: added i18n to google service and missing i18n for validation Netbrain's comment: done ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114550]: New comment added
Netbrain posted a comment on MediaWiki.r114550. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114550#c32560 Commit summary for MediaWiki.r114550: added i18n to google service and missing i18n for validation Netbrain's comment: done ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Gerrit bots notification
Le 28/03/12 04:37, Ryan Lane a écrit : It already supports sending to multiple channels. I can't go into details right now, but I'll follow up on this later with more info. That message remembers meof Fermat last theorem :-) Fermat published a mathematical conjecture and claimed in the margin he had a proof that did not fit in. Long story made short: the conjecture has been proven 358 years later. http://en.wikipedia.org/wiki/Fermat%27s_Last_Theorem -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GSoC 12 Proposal
Hi, I have modified my ideas page in accordance with the application template - http://www.mediawiki.org/wiki/User:Shivansh13 I would request some feedback, so that I can discuss these ideas more. With Regards, On 28 March 2012 04:52, Shivansh Srivastava shivansh.b...@gmail.com wrote: Hi, I am Shivansh, pursuing Engineering at BITS Pilani, currently in my 3rd year. I am well versed in Web Technologies, that include HTML5, JavaScripts (jQuery), CSS; with PHP MySQL and App Development for Windows Phone 7. I have worked in my college on several websites with the same knowledge. I had also given a talk at the 3rd WikiConference held at Mumbai on Improving Wiki UI using AJAX jQuery presented with 4 ideas/projects with the Wiki community. I am interested in developing the Frontend, as I am pretty comfortable in designing UI using HTML, jQuery (javascripts), CSS HTML5, particularly dealing with Gadgets Extensions. I have already worked on the MediaWiki Software, generally play around with the extensions, but I mostly try to develop on the user common.js . After a series of discussions feedback, I made the proposal page - https://www.mediawiki.org/wiki/User:Shivansh13#My_Proposal_for_Ideas . Kindly look at it let me me know the feasibility of such a project. Waiting for a reply. Thank you. With Regards, -- Shivansh Srivastava | +91-955-243-5407 | http://in.linkedin.com/pub/shivansh-srivastava/17/a50/b18mr.shivansh.srivast...@gmail.com mr.shivansh.srivast...@gmail.com3rd Year Undergraduate | B.E. (Hons.) - Electronics Instrumentation BITS-Pilani. -- Shivansh Srivastava | +91-955-243-5407 | http://in.linkedin.com/pub/shivansh-srivastava/17/a50/b18mr.shivansh.srivast...@gmail.com mr.shivansh.srivast...@gmail.comSecretary, BITS Alumni Affairs Division | Web Expert, Newsletter, BITSAA International 3rd Year Undergraduate | B.E. (Hons.) - Electronics Instrumentation BITS-Pilani. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] I'd prefer that you didn't submit this
Hi everyone, There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. I did some testing and this is totally configurable :) It won't change for old comments that were already submitted, but we can pick some nicer wording going forward. I really don't have any good suggestions for this, so I'm opening this up to the list for a bit of good old fashioned bikeshedding. Thanks! -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Creating naming conventions for git branches?
On Wed, Mar 28, 2012 at 1:58 AM, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: When i use `git review -d' on a change that was in the aforementioned branch, another branch called review/amire80/bug/31817 is created, so i suppose that Gerrit identified the bug number (or maybe somebody did it manually and i missed it). I don't quite understand why two branches are created for pretty much the same thing. Maybe i should create a branch called review/amire80/bug/31817 in the first place? Or maybe i shouldn't use `git review -d' at all? No, this is expected behavior. git review -d creates branches with this naming convention, the only reason it's weird is because you're downloading yuor own change rather than someone else's. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] I'd prefer that you didn't submit this
* I found a problem in this revision * There is a problem in this revision * Thank you for submitting your revision, but there is some error in your code Some suggestions :) On Wed, Mar 28, 2012 at 3:10 PM, Chad innocentkil...@gmail.com wrote: Hi everyone, There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. I did some testing and this is totally configurable :) It won't change for old comments that were already submitted, but we can pick some nicer wording going forward. I really don't have any good suggestions for this, so I'm opening this up to the list for a bit of good old fashioned bikeshedding. Thanks! -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] I'd prefer that you didn't submit this
This patch cannot be merged in the current state or something like that. —vvv On Wed, Mar 28, 2012 at 5:10 PM, Chad innocentkil...@gmail.com wrote: Hi everyone, There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. I did some testing and this is totally configurable :) It won't change for old comments that were already submitted, but we can pick some nicer wording going forward. I really don't have any good suggestions for this, so I'm opening this up to the list for a bit of good old fashioned bikeshedding. Thanks! -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] I'd prefer that you didn't submit this
+1 for There is a problem with this revision. as it doesn't make use of any personal words like 'you' or 'i' Maybe even append 'Please fix' to give an action to the sender. e.g. There is a problem with this revision. Please fix. On Wed, Mar 28, 2012 at 2:17 PM, Petr Bena benap...@gmail.com wrote: * I found a problem in this revision * There is a problem in this revision * Thank you for submitting your revision, but there is some error in your code Some suggestions :) On Wed, Mar 28, 2012 at 3:10 PM, Chad innocentkil...@gmail.com wrote: Hi everyone, There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. I did some testing and this is totally configurable :) It won't change for old comments that were already submitted, but we can pick some nicer wording going forward. I really don't have any good suggestions for this, so I'm opening this up to the list for a bit of good old fashioned bikeshedding. Thanks! -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] I'd prefer that you didn't submit this
I support the less personal wording, but cannot is more like -2. -1 is more like should not. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore 2012/3/28 Victor Vasiliev vasi...@gmail.com: This patch cannot be merged in the current state or something like that. —vvv On Wed, Mar 28, 2012 at 5:10 PM, Chad innocentkil...@gmail.com wrote: Hi everyone, There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. I did some testing and this is totally configurable :) It won't change for old comments that were already submitted, but we can pick some nicer wording going forward. I really don't have any good suggestions for this, so I'm opening this up to the list for a bit of good old fashioned bikeshedding. Thanks! -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114549]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r114549. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114549#c32561 Commit summary for MediaWiki.r114549: added i18n for openlayers Jeroen De Dauw's comment: If you fixed the stuff, mark your commit as new, else it'll just stay fixme :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] GSoC
Hi, I'd like to participate in Google Summer of Code. After thinking about several options (global preferences, export/import, ...) I took the subject that I am most excited about and that is a continuation of what I have been doing as a volunteer, improving Incubator (with an extension) and language support of MediaWiki. Please see https://www.mediawiki.org/wiki/User:SPQRobin/GSoC , any feedback is of course welcome. (It's difficult to guess what is too little or too much.) As I am not home from 31 March till 6 April, I will have to submit it now in two days, because I am not sure I will have internet access during that week. Thanks Robin ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] I'd prefer that you didn't submit this
Le 28/03/12 15:10, Chad a écrit : There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. Better as make it even more personal ? :-D My suggestion is: This patchset needs to be improved That sounds positive to me. At least improving something is probably more of a reward than fixme. Sometime, we might have a patch which is fine to merge but not perfect yet, so I guess that case is covered by my suggestion. A fun one would be: Much to learn you still have...my old padawan. Would probably make a Yoda job in Jenkins just for that :-D -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikimedia and IPv6
Le 28/03/12 00:18, Erik Moeller wrote: snip We'll continue to sync up on this internally both from an ops and development standpoint, but anyone who wants to help move IPv6 forward, please do. * raises hand * -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Replying to gerrit comments
What's the standard way to reply to a comment someone has made to one of your commits? Nothing was obvious in the interface, so I just did a Review with a score of 0 (obviously :). Drawbacks to this way: * It really shouldn't be giving me the option to +1 my own commit * I now show up as a reviewer, which is odd * It calls up a new page, so I cannot see the comment I am replying to Not a big deal, but I am wondering if there is a better way. -- Greg Sabino Mullane g...@endpoint.com End Point Corporation PGP Key: 0x14964AC8 pgpPdmOKBSv8y.pgp Description: PGP signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114549]: New comment added
Nikerabbit posted a comment on MediaWiki.r114549. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114549#c32562 Commit summary for MediaWiki.r114549: added i18n for openlayers Nikerabbit's comment: And associate the follow-up :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114549]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r114549. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114549#c32563 Commit summary for MediaWiki.r114549: added i18n for openlayers Jeroen De Dauw's comment: And don't forget to enjoy the easiness of it all, before you have to switch to gerrit o_O ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Wikimedia and IPv6
Yes I would like to help as well, but it would be nice if you told us, how. My suggestion is to enable ipv6 on wikimedia labs, and on beta cluster, so that we can test the mediawiki support for ipv6 there and let the community of wikimedia try it and find and report all problems On Wed, Mar 28, 2012 at 5:47 PM, Antoine Musso hashar+...@free.fr wrote: Le 28/03/12 00:18, Erik Moeller wrote: snip We'll continue to sync up on this internally both from an ops and development standpoint, but anyone who wants to help move IPv6 forward, please do. * raises hand * -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114552]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r114552 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114552#c32564 Old Status: new New Status: fixme Commit summary for MediaWiki.r114552: us isCssOrJsPage() only for script pages actually used in the UI, not all pages containing CSS or JS Nikerabbit's comment: Tabs! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114553]: Revision status changed
Nikerabbit changed the status of MediaWiki.r114553 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114553 Old status: new New status: fixme Commit summary for MediaWiki.r114553: catch exceptions while generating auto delete reason ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114554]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r114554 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114554#c32565 Old Status: new New Status: fixme Commit summary for MediaWiki.r114554: mark _DiffOf_XXX etc for refactoring Nikerabbit's comment: And tabs. Please configure your editor to use tabs :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Open git issues
Le 27/03/12 11:57, Niklas Laxström a écrit : I have been collecting list of issues at http://www.mediawiki.org/wiki/Git/Conversion#Open_issues_after_migration I'd like start discussion how to solve these issues and in what time frame. I would really prefer that we add issues in the Bugzilla tracker. We already have enough mess to keep track of and a wiki has already proven how bad it is for issues tracking. I am answering below but will not follow up. We should have bug opened for all issues potentially copy pasting from this mail and my answer. == Code review process == I would very much like to have the full patch diffs back in emails so that I can quickly scan for any i18n issues. Also Gerrit is just slow enough that I must either waste time waiting for it to load the interface, or do a context switch by reading next commit. Not to mention the need to open the diffs for each file in tab. snip There are several issues in that paragraph. Full diffs in emails: I dislikes having full diffs in emails and they are lacking colors making them basically useless to me. That also makes mail processing slower and makes my inbox very huge. If we ever do that, please please make it a per user option. Gerrit slowness: I do not have that much an issues. Possible root causes could be: - you have a slow computer - your network connection is bad - Gerrit client interface is badly programmed - Gerrit server is overloaded Or that might just be because delay between click is not good enough for you. Maybe we could investigate on the server side or add a layer of caching in front of Gerrit. Anyway, something worth a bug so we could investigate it. scan for i18n: Can this be somehow scripted / made more automatic? We should probably eastablish a list of recurrent issues then have a script to automatically analyse files to find possible culprit. Two possibles examples comes to mind: - messages being added in MessagesEn.php and missing from Messages.inc. 100% sure this can be scripted - wfMessage() being used without an explicit formatting call (-parse, -parseAsBlock(), -text()). There is again 100% possibility to script that using PHP tokenizer. diff files in each tab: I am a huge fan of this feature, I find it way easier to handle than a large and long page. I have already written about it in wikitech-l some weeks ago. One possible workaround would be to add a link to the Gitweb full diff in Gerrit GUI. This should probably be reported upstream. == Emails == Related to above, I want to scan all (submitted?) changes for the issues. Currently there is no easy way to subscribe to changes of all repositories. Indeed, you have to manually subscribe to get email notifications for each projects. Once subscribed you will always receive everything with no easy way to stop the mail spam even if you have no interest in a specific change. As I understand it, you are looking for something like the mailing list that received all mediawiki svn commits. We will have to look at Gerrit to have some mailing list to get notified of any patchset submitted to Core and Extension. Need investigation and a report upstream. In theory I could do the same inside Gerrit, would it provide a easily navigatable list which records what I have looked at. One way is to use the Gerrit search box and look for 'mediawiki/' that will give you all changes ever submitted to mediawiki/* projects. == Unicode issue in Gerrit == This must be fixed (dataloss). See https://gerrit.wikimedia.org/r/#change,3505 for example See: https://bugzilla.wikimedia.org/35455 Upstream recommendation is to use the embed H2 database or a real database such as postgre. == Local changes == How to handle permanent local changes? There have already been suggestions: * use git stash (not fun to do for every push) * use git review --no-rebase (no idea if this is a good idea) * commit them to local development branch (but then how to rebase changes-to-commit to master before pushing?) I have talked about it with Niklas and have no idea how that could be fixed. Maybe by working in a local branch and then have the current commit to be merged to a clean master before submission. That would require some scripting. Niklas, I guess you want to send a new mail to wikitech-l so it receives more attention. == How to FIXME == We need a way to identify *merged* commits that need fixing. Those commits should be our collective burden to fix. It must not rely on the reporter of the issue fixing the issue him/herself or being persistent enough to get someone to fix it. I was suggested to use bugzilla, but it's a bit tedious to use and doesn't as-is have the high visibility like FIXMES used to have. We should have less fixme nowadays since we have adopted a pre merge review, it still happens from time to time though. Our bug report is https://bugzilla.wikimedia.org/35535 Thanks Niklas for your long feedback :-) --
Re: [Wikitech-l] GSOC Proposal: Watchlist Improvements
On 03/27/2012 02:08 AM, Aaron Pramana wrote: Thanks Steven, I have posted the deliverables for my proposal here: https://www.mediawiki.org/wiki/User:Blackjack48/GSOC_proposal_for_watchlist_improvements Is there any place in particular I should post the link besides this mailing list? -Aaron Hi, Aaron. http://google-opensource.blogspot.com/2012/03/new-kind-of-summer-job-open-source.html has the details on applying. You need to submit your proposal via http://www.google-melange.com/gsoc/program/home/google/gsoc2012 before Friday, April 6 at 19:00 UTC. I know you wrote that you'll be adding more details to your proposal later this week. Just so you know, the best way to get an idea of what a MediaWiki project proposal should look like is to look at our past projects https://www.mediawiki.org/wiki/Summer_of_Code_Past_Projects and to read http://en.flossmanuals.net/GSoCStudentGuide/ , then use our application template: https://www.mediawiki.org/wiki/Summer_of_Code_2012/Application_template . Vivek Bagaria https://www.mediawiki.org/wiki/User:Bagariavivek/GSoC_Application is also interested in doing a Google Summer of Code project to improve watchlist functionality. Historically, sometimes we receive multiple proposals for very similar tasks for Google Summer of Code, but we only accept one (factors going into our decision will include which proposal is better, which student has participated more in the Wikimedia community, which student has better technical skills, and which student has better communication skills). Therefore, you and Vivek should either choose to strive to make your applications regarding watchlist improvements the best it can be, or one of you should choose a different topic. Feel free to discuss with each other. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Replying to gerrit comments
Hey, Not a big deal I disagree. This workflow is horrible. I have to open a new window to see what I am replying to. Seriously?!! This wasts peoples time... Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikimedia and IPv6
On Wed, Mar 28, 2012 at 8:55 AM, Petr Bena benap...@gmail.com wrote: Yes I would like to help as well, but it would be nice if you told us, how. My suggestion is to enable ipv6 on wikimedia labs, and on beta cluster, so that we can test the mediawiki support for ipv6 there and let the community of wikimedia try it and find and report all problems I'll let Ryan respond to this in full when he gets back, but he said there's an issue with supporting IPv6 in labs. If I recall correctly it was something along the lines of: * Nova did not have IPv6 support when he set up labs * Newer versions of Nova support IPv6 but assume you create the IPv4 and IPv6 networks at the same time -- Therefore there is no reasonable way to add IPv6 support to an existing IPv4-only Nova setup I can't say how long it will take to set up IPv6 in labs, Ryan is much better qualified to estimate that, just saying that it's apparently not at all trivial. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Replying to gerrit comments
On Wed, Mar 28, 2012 at 8:54 AM, Greg Sabino Mullane g...@endpoint.com wrote: What's the standard way to reply to a comment someone has made to one of your commits? Nothing was obvious in the interface, so I just did a Review with a score of 0 (obviously :). Drawbacks to this way: * It really shouldn't be giving me the option to +1 my own commit * I now show up as a reviewer, which is odd * It calls up a new page, so I cannot see the comment I am replying to Not a big deal, but I am wondering if there is a better way. It's very strange, but yes, this is the standard way. And Jeroen is right, it sucks that you can't see what you're replying to. Having an AJAX interface here would be nice (inline comments do have this). Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Replying to gerrit comments
Le 28/03/12 17:54, Greg Sabino Mullane a écrit : What's the standard way to reply to a comment someone has made to one of your commits? Nothing was obvious in the interface, so I just did a Review with a score of 0 (obviously :). Drawbacks to this way: * It really shouldn't be giving me the option to +1 my own commit * I now show up as a reviewer, which is odd * It calls up a new page, so I cannot see the comment I am replying to Not a big deal, but I am wondering if there is a better way. The reason you show up as a reviewer of your own patchset is that people will amend it and you will have to review changes made to your original code. That also explain why you are allowed to +1 on a change you have created. Spelled differently, consider anything you push to Gerrit is no more your but instead a gift to the community. You will have the responsibility to have it reviewed and follow up on reviews. The way Gerrit work, people are supposed to write their comments directly inside the files differences where you can reply and be really precise as to which area of the code you comment on (just click a line). The textarea below the patchsets list is just about introducing all the comments you did in the various files. Hence the Cover message: label. In conclusion, that is not a forum like we used to have on Special:CodeReview. I believe serious issues should be bring back to wikitech-l for further discussion or the bug report if there is any. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Continuous integration workflow post-Git migration
Erik Moeller wrote: snip This video BTW has a nice explanation of a working git/gerrit/jenkins integration. http://vimeo.com/20084957 Notice the Jenkins user posting a build started comment the moment a change goes into Gerrit, and then adding a +1 on test or a -1 on failure (although that should arguably be a -2). That is exactly what I am aiming for following a discussion with the OpenStack developers. Now that git and 1.19 are on rails, I will probably switch back to finish up the git jobs in Jenkins :-) Thanks for posting that screencast. It is a good introduction to Gerrit. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114549]: New comment added, and revision status changed
Netbrain changed the status of MediaWiki.r114549 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114549#c32566 Old Status: fixme New Status: new Commit summary for MediaWiki.r114549: added i18n for openlayers Netbrain's comment: ah lol.. thanks guys ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114550]: Revision status changed
Netbrain changed the status of MediaWiki.r114550 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114550 Old status: fixme New status: new Commit summary for MediaWiki.r114550: added i18n to google service and missing i18n for validation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114554]: New comment added
Daniel Kinzler (WMDE) posted a comment on MediaWiki.r114554. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114554#c32567 Commit summary for MediaWiki.r114554: mark _DiffOf_XXX etc for refactoring Daniel Kinzler (WMDE)'s comment: uh, i thought i did? sorry, i'll check again ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1484]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1484 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1484 Old status: new New status: ok Commit summary for Wikimedia.r1484: Merging in the upgrade of civicrm version 4.1.1 r1479, r1480 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1483]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1483 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1483 Old status: new New status: ok Commit summary for Wikimedia.r1483: Merging in the upgrade of civicrm version 4.1.1 r1479, r1480 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1480]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1480 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1480 Old status: new New status: ok Commit summary for Wikimedia.r1480: Tag vendors/civicrm/current as vendors/civicrm/4.1.1. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1517]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1517 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1517 Old status: new New status: ok Commit summary for Wikimedia.r1517: MFT r1515 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1481]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1481 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1481 Old status: new New status: ok Commit summary for Wikimedia.r1481: Copying the old prod over to the location of the CiviCrm 4.1.1 upgrade in progress. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1479]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1479 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1479 Old status: new New status: ok Commit summary for Wikimedia.r1479: Load civicrm into vendors/civicrm/current. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Creating a thumbnail with File::createThumb()
I must be missing something. My test image is 400px (width) by 300px (height.) I'd like to create a thumbnail of max-width 100px. I can get the image's url and path quite easily, but I can't seem to get the url of the thumbnail. All the methods return the path and url for the *image*, not the *thumbnail*. The only thing that comes close is the call to thumbName(), which will return the thumbnail's name (but not the url.) The createThumb() method does not do what I expect in the least -- it always seems to return a url to the *image*, and does not create anything, let along return a url to that nothing. I checked and I've got one 404 handler, but it is very specific to employee pictures (showing a generic image when an employee has no picture on their userpage.) I'd rather not have to mess with Apache (I hate writing rewrite rules,) and would rather have MW just generate the thumbnail when it's url is requested. Either way the user is going to wait (unless the thumbnail already exists, which I'm planning on happening in the large majority of the cases.) This code shows what I am talking about: The output of the var_dump shows the same url for both the image and it's thumbnail, when (what I expect) they should be different. - // get the image and the thumbnail $img = wfLocalFile( $title ); $params = array( 'width' = 100, 'height' = 100, ); $thumb = $img-transform( $params ); // dump some output to test things var_dump( $img-getName(), # Example.jpg $img-getExtension(), # jpg $img-getUrl(), # /w/images/a/a9/Example.jpg $img-getPath(),# /home/wiki/wiki/images/a/a9/Example.jpg $img-canRender(), # bool(true) $img-thumbName( $params ), # 100px-Example.jpg $img-createThumb( 100 ),# /w/images/a/a9/Example.jpg $thumb-getUrl(), # /w/images/a/a9/Example.jpg $thumb-getPath() # /home/wiki/wiki/images/a/a9/Example.jpg ); die(); - What am I missing here? -Daniel -Original Message- From: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] On Behalf Of Daniel Friesen Sent: Wednesday, March 28, 2012 2:31 AM To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] Creating a thumbnail with File::createThumb() Don't use RENDER_NOW. It's the complete opposite of what he's asking for. In fact NEVER use RENDER_NOW unless you are absolutely sure that you absolutely need it. The only valid use case for RENDER_NOW I can think of is if you intend to open the file yourself and do extra image processing on it. If you want to give a user a URL then you NEVER need it. My input on this subject: - If your thumbnail size is larger than the image's size then the original image's url will be returned because it's already big enough (this IS what you want) - If you have setup a 404 handler files will only be generated when they are requested by the user. This IS what you want. We support generating thumbnails when a file is not found. If a path looks like a thumbnail it gets sent to thumb.php where it's then rendered, sent to the user, and saved to the filesystem for future requests. This has a number of advantages: - You can delete all your thumbnails if you think you have piles ones not being used anymore. Since they will all safely be regenerated when used. - You can use thumbnails inside of css since you know the thumb will always be usable. - It speeds up your wiki. Rendering thumbnails takes time. And during the time that thumbnails are being generated php is frozen. That means that thumbnail render time adds to your wiki's page load time on upload, save, previews, view, etc... By using a 404 handler the wiki is capable of skipping the rendering serving a url and deferring that load time to a process dedicated to rendering the thumbnail. - It also lets you dedicate machines to image thumbnailing and allow your webservers to focus on serving webpages instead of spending cpu time on image processing. One of these days I'd like to see if I could write a fuse filesystem that exposes a cache as a filesystem. ;) then you can mount that as your filesystem for thumbs/ and have all old thumbnails purged automatically. (We don't have the capability to delete thumbnails that are no longer used) On Tue, 27 Mar 2012 22:13:23 -0700, Hunter Fernandes h.g.f...@gmail.com wrote: Since no one has replied at this time, I thought I'd give a crack at an answer (I really don't know if this will work). Some goodies from a quick scan of thumb.php: $img = wfLocalFile( $fileName
Re: [Wikitech-l] Creating a thumbnail with File::createThumb()
On Wed, Mar 28, 2012 at 10:33 AM, Daniel Renfro dren...@vistaprint.comwrote: $img = wfLocalFile( $title ); $params = array( 'width' = 100, 'height' = 100, ); $thumb = $img-transform( $params ); // dump some output to test things var_dump( $img-createThumb( 100 ),# /w/images/a/a9/Example.jpg $thumb-getUrl(), # /w/images/a/a9/Example.jpg $thumb-getPath() # /home/wiki/wiki/images/a/a9/Example.jpg ); By any chance do you not have image scaling enabled? It might well be giving you the original image and scaling client-side. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Creating a thumbnail with File::createThumb()
$wgUseImageResize is set to true, which means dynamic server-side image resizing of thumbnails should be enabled. As far as I can tell, everything *should* be setup for image-resizing/ thumbnail-generation. Brion, you're describing what is currently happening -- the server sends the url of the thumbnail (which is really the url of the original image), and then the browser is scaling it to fit. I'd rather not send 1Mb files across the wire when I can send a 10Kb thumbnail. I'll keep working on it, thanks for the help gurus. Btw, here's Special:Vesion: MediaWiki 1.18.2 (r19114) PHP 5.3.3 (apache2handler) MySQL 5.0.77 Linux 2.6.18-274.17.1.el5 -Daniel -Original Message- From: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] On Behalf Of Brion Vibber Sent: Wednesday, March 28, 2012 1:37 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Creating a thumbnail with File::createThumb() On Wed, Mar 28, 2012 at 10:33 AM, Daniel Renfro dren...@vistaprint.comwrote: $img = wfLocalFile( $title ); $params = array( 'width' = 100, 'height' = 100, ); $thumb = $img-transform( $params ); // dump some output to test things var_dump( $img-createThumb( 100 ),# /w/images/a/a9/Example.jpg $thumb-getUrl(), # /w/images/a/a9/Example.jpg $thumb-getPath() # /home/wiki/wiki/images/a/a9/Example.jpg ); By any chance do you not have image scaling enabled? It might well be giving you the original image and scaling client-side. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Creating a thumbnail with File::createThumb()
OMG nevermind! I found that $wgUseImageResize was being set to false in LocalSettings! I was looking at the wrong LocalSettings.ah! Thanks anyway, everything working OK now, -Daniel -Original Message- From: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] On Behalf Of Daniel Renfro Sent: Wednesday, March 28, 2012 2:00 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Creating a thumbnail with File::createThumb() $wgUseImageResize is set to true, which means dynamic server-side image resizing of thumbnails should be enabled. As far as I can tell, everything *should* be setup for image-resizing/ thumbnail-generation. Brion, you're describing what is currently happening -- the server sends the url of the thumbnail (which is really the url of the original image), and then the browser is scaling it to fit. I'd rather not send 1Mb files across the wire when I can send a 10Kb thumbnail. I'll keep working on it, thanks for the help gurus. Btw, here's Special:Vesion: MediaWiki 1.18.2 (r19114) PHP 5.3.3 (apache2handler) MySQL 5.0.77 Linux 2.6.18-274.17.1.el5 -Daniel -Original Message- From: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] On Behalf Of Brion Vibber Sent: Wednesday, March 28, 2012 1:37 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Creating a thumbnail with File::createThumb() On Wed, Mar 28, 2012 at 10:33 AM, Daniel Renfro dren...@vistaprint.comwrote: $img = wfLocalFile( $title ); $params = array( 'width' = 100, 'height' = 100, ); $thumb = $img-transform( $params ); // dump some output to test things var_dump( $img-createThumb( 100 ),# /w/images/a/a9/Example.jpg $thumb-getUrl(), # /w/images/a/a9/Example.jpg $thumb-getPath() # /home/wiki/wiki/images/a/a9/Example.jpg ); By any chance do you not have image scaling enabled? It might well be giving you the original image and scaling client-side. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] I'd prefer that you didn't submit this
I agree. Having 'you' or 'i' makes the message personal when the focus should remain on the commit itself. + 1 This patch needs improvement. | Needs improvement, this patch does. ( if we go with the yoda job ) On Wed, Mar 28, 2012 at 8:29 AM, Antoine Musso hashar+...@free.fr wrote: Le 28/03/12 15:10, Chad a écrit : There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. Better as make it even more personal ? :-D My suggestion is: This patchset needs to be improved That sounds positive to me. At least improving something is probably more of a reward than fixme. Sometime, we might have a patch which is fine to merge but not perfect yet, so I guess that case is covered by my suggestion. A fun one would be: Much to learn you still have...my old padawan. Would probably make a Yoda job in Jenkins just for that :-D -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Rob Moen Wikimedia Foundation rm...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] git commit message guide lines
Hello, With the switch to git and Gerrit, we should start formatting our commit message. Over the last days, you might have noticed I have amended a few changes in mediawiki/core.git. Both git and gerrit use the first line of a message as a summary of the commit which is probably more human friendly than a sha1. In Gerrit it is used when referring to a parent commit and as a subject for email notifications. In git it is very helpful when using `log --oneline` or cherry-picking a commit, or rebasing interactively. Inspired by various online resources, I have started writing guidelines and even provided some screen captures: https://www.mediawiki.org/wiki/Git/Commit_message_guidelines Edits welcome :-D See also: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html http://en.wikibooks.org/wiki/Git/Introduction#Good_commit_messages -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] A very nice error message
Folks, I have never had such an error...
The page is:
http://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29action=submit
(It occured during saving.)
The message (belső hiba means internal error):
Belső hiba
A Wikipédiából, a szabad enciklopédiából
Ugrás:
navigációhttp://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29action=submit#column-one,
kereséshttp://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29action=submit#searchInput
Detected bug in an extension! Hook ClickTrackingHooks::articleSave failed
to return a value; should return true to continue hook processing or false
to abort.
Backtrace:
#0
/usr/local/apache/common-local/php-1.19/includes/GlobalFunctions.php(3823):
Hooks::run('ArticleSave', Array)
#1 /usr/local/apache/common-local/php-1.19/includes/WikiPage.php(1263):
wfRunHooks('ArticleSave', Array)
#2 [internal function]: WikiPage-doEdit('{{korrekt??ra}}...', 'N??mi
r??g??s a...', 98)
#3 /usr/local/apache/common-local/php-1.19/includes/Article.php(1786):
call_user_func_array(Array, Array)
#4 [internal function]: Article-__call('doEdit', Array)
#5 /usr/local/apache/common-local/php-1.19/includes/EditPage.php(1434):
Article-doEdit('{{korrekt??ra}}...', 'N??mi r??g??s a...', 98)
#6 /usr/local/apache/common-local/php-1.19/includes/EditPage.php(959):
EditPage-internalAttemptSave(Array, false)
#7 /usr/local/apache/common-local/php-1.19/includes/EditPage.php(357):
EditPage-attemptSave()
#8
/usr/local/apache/common-local/php-1.19/includes/actions/EditAction.php(51):
EditPage-edit()
#9
/usr/local/apache/common-local/php-1.19/includes/actions/EditAction.php(71):
EditAction-show()
#10 /usr/local/apache/common-local/php-1.19/includes/Wiki.php(484):
SubmitAction-show()
#11 /usr/local/apache/common-local/php-1.19/includes/Wiki.php(278):
MediaWiki-performAction(Object(Article))
#12 /usr/local/apache/common-local/php-1.19/includes/Wiki.php(593):
MediaWiki-performRequest()
#13 /usr/local/apache/common-local/php-1.19/includes/Wiki.php(503):
MediaWiki-main()
#14 /usr/local/apache/common-local/php-1.19/index.php(58): MediaWiki-run()
#15 /usr/local/apache/common-local/live-1.5/index.php(3):
require('/usr/local/apac...')
#16 {main}
Just in case somebody likes to collect nice errors to hang them framed
above the bed. (A reload solved my problem, the pages was saved for 2nd
attempt. Diff:
http://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29diff=11452503oldid=11452430
)
--
Bináris
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] A very nice error message
2012/3/28 Bináris wikipo...@gmail.com: Folks, I have never had such an error... The page is: http://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29action=submit (It occured during saving.) The message (belső hiba means internal error): Belső hiba A Wikipédiából, a szabad enciklopédiából Ugrás: navigációhttp://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29action=submit#column-one, kereséshttp://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29action=submit#searchInput Detected bug in an extension! Hook ClickTrackingHooks::articleSave failed to return a value; should return true to continue hook processing or false to abort. Backtrace: [snip] Just in case somebody likes to collect nice errors to hang them framed above the bed. (A reload solved my problem, the pages was saved for 2nd attempt. Diff: http://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29diff=11452503oldid=11452430 ) That's very weird. Looks like that was an intermittent error while I was in the middle of deploying a change? Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] A very nice error message
2012/3/28 Roan Kattouw roan.katt...@gmail.com: That's very weird. Looks like that was an intermittent error while I was in the middle of deploying a change? I only see 3 of these in exception.log , so I think it's fine. If this were happening on every page save, we'd be seeing a lot more of them. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Fwd: Chennai Unofficial Wikimedia Hackathon Report
Thought this would be interesting to wikitech-l. -- Forwarded message -- From: Yuvi Panda yuvipa...@gmail.com Date: Tue, Mar 27, 2012 at 1:47 PM Subject: Chennai Unofficial Wikimedia Hackathon Report To: Discussion list on Indian language projects of Wikimedia. wikimediaindi...@lists.wikimedia.org The Chennai Unofficial Wikimedia Hackathon Report TL;DR: 13 completed hacks, including 2 core mediawiki patches, 3 tawiki userscript updates and 2 new deployed tools. It was super awesome and super productive! The 'Unofficial' Chennai Wikimedia Hackathon(http://www.mediawiki.org/wiki/Chennai_Hackathon_March_2012) happened on Saturday, March 17 2012 at the Thoughtworks office in Chennai. It was a one day, 8 hour event focusing on getting people together to hack on stuff related to all Wikimedia projects - not just Mediawiki patches. The event started with us sailing past security reasonably easily, and getting setup with internet without a glitch. People trickled in and soon enough we had 21 people in there. Since this was a pure hackathon, there were no explicit tutorials or presentations. As people came in, we asked them what technologies/fields they are familiar with, and picked out an idea for them to work on from the Ideas List (http://www.mediawiki.org/wiki/Chennai_Hackathon_March_2012/Ideas). This took care of the biggest problem with hackathons with new people - half the day spent on figuring out what to work on, and when found, it is completely outside the domain of expertise of the people hacking on the idea. Talking together with them fast to pick an idea within 5 minutes that they can complete in the day fixed this problem and made sure people can concentrate on coding for the rest of the day. People started hacking, and just before lunch we made people come up and tell us what they were working on. We then broke for lunch and usual socialization happened over McDonalds burgers and Saravana Bhavan dosas. Hacking started soon after, and people were concentrating on getting their hacks done before the demo time. And we did have quite a few demos! Demos = Here's a short description of each of the demos, written purely in the order in which they were presented: 1. Wikiquotes via SMS By: @MadhuVishy and @YesKarthik What it does: Send a person name to a particular number, and you'll keep getting back quotes from that person. Works in similar semi-automated fashion as the DYKBot. Built on AppEngine + Python. Status: Deployed live! Send SMS '@wikiquote Gandhi' to 9243342000 to test it out! Has limited data right now, however. --- 2. API to Rotate Images (Mediawiki Core Patch) By: Vivek What it does: Adds an API method that can arbitrarily rotate images. Think of this as first step towards being able to rotate any image in commons with a single button instantly, without having to wait for a bot. Patch was attached to https://bugzilla.wikimedia.org/33186. Status: It was reviewed on that day itself (Thanks Reedy!). Vivek is now figuring out how to modify his patch so that it would be accepted into Mediawiki core. Vivek is also applying to work with Mediawiki for GSoC, so we will hopefully get a long term contributor :) --- 3. Find list of unique Tamil words in tawiki By: Shrinivasan T What it does: It took the entire tamil wikipedia dump and extracted all unique words out of it. About 1.3 million unique tamil words were extracted. Has multiple applications, including a tamil spell checker. Status: Code and the dataset live on github: https://github.com/tshrinivasan/tamil-wikipedia-word-list --- 4. Program to help record pronunciations for words in tawikt What it does: Simple python program that gives you a word, asks you to pronounce it and then uploads it to commons for being used in Wiktionary. Makes the process much more streamlined and faster. Status: Code available at: https://github.com/tshrinivasan/voice-recorder-for-tawictionary. Preliminary testing with his friends shows that easy to record 500 words in half an hour. Is currently blocked on figuring out a way to properly upload to commons --- 5. Translation of Gadgets/UserScripts to tawiki By: SuryaPrakash [[:ta:பயனர்:Surya_Prakash.S.A.]] What he did: Surya spent the day translating two gadgets into Tamil, so they can be used on tawiki. First is the 'Prove It' Reference addition tool (http://ta.wikipedia.org/wiki/Mediawiki:Gadget-ProveIt.js). The second one was the 'Speed Reader' extension that formats content into multiple columns for faster scanning (http://ta.wikipedia.org/wiki/Mediawiki:Gadget-TwoColumn.js). Last I checked, these are available for anyone with only tamil knowledge to use, so yay! (He also tried to localize Twinkle for Tamil, couldn't because of issues with the laptop he was using. --- 6. Structured database search over Wikipedia By: Ashwanth What it does: Built a tool that combined DBPedia and Wikipedia to allow you to search in a semantic way. We almost descended into madness with
Re: [Wikitech-l] Changeset differ (was Re: Committing followups: please no --amend)
Tim Starling tstarl...@wikimedia.org wrote: I wrote: It doesn't work, I'm afraid. Because of the implicit rebase on push, usually subsequent changesets have a different parent. So when you diff between the two branches, you get all of the intervening commits which were merged to the master. I was hoping that someone was going to say you're wrong, making those diffs is easy, here's how. But I take it by the silence that I'm not wrong, and it really is hard. I just tried to push second commit to https://gerrit.wikimedia.org/r/#change,3841 patchet three. If you don't start from scratch i.e. base your commit on the parent: 8824515e571eadd4a63b09e1331f35309315603f (now I have $ git log HEAD ^HEAD^^^ commit e67af5bbd843db3062cc0082254b69aae3d1241b Author: saper sa...@saper.info Date: Wed Mar 28 22:06:17 2012 +0200 An example how a foreign key should be added to the table Change-Id: I0da5b25f4b4499facac6c410fa7ab74250935288 commit 96692fb23c00cb726144290b108623896cf24834 Author: Marc A. Pelletier m...@uberbox.org Date: Tue Mar 27 22:44:32 2012 -0400 (bug 5445) remove autoblocks when user is unblocked (...comment truncated...) Change-Id: I4aa820ae9bbd962a12d0b48b6c638a1b6ff4efc9 This is the current HEAD: commit 8824515e571eadd4a63b09e1331f35309315603f Author: Santhosh Thottingal santhosh.thottin...@gmail.com Date: Wed Mar 28 11:25:45 2012 +0530 Trying to commit e67af5bbd843db3062cc0082254b69aae3d1241b makes gerrit say: ! [remote rejected] HEAD - refs/changes/3841 (squash commits first) It does not matter if I use the same change ID or not. It knows exactly where it should go but it still refuses it. I have managed to workaround this by creating a branch, doing lots of commits there, merging it, and push the merge to gerrit. But then it uploads lots of unrelated changets: https://gerrit.wikimedia.org/r/#change,3706 https://gerrit.wikimedia.org/r/#change,3707 https://gerrit.wikimedia.org/r/#change,3708 (but this was outside of the branch) https://gerrit.wikimedia.org/r/#change,3709 The commit tree looked like: private branch: 3706 --- 3707 --- / \ 62562768cf8f2696 + 3708 + 3709 (merge) As you can see, although there were so many changesets, they all have dependencies set properly. Is this a better way? I don't know... I wonder why in this case gerrit does not complain with its usual (squash commits first) Having private branches with other people would certainly help to work together on issues. I tried to submit an improvement to https://gerrit.wikimedia.org/r/#change,3841 and it seems I can't do this the other way than rebasing my changes to the parent of the changeset (*not* master). Not sure how to make a branch out of it (maybe I should merge it with the parent commit?) //Saper ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114531]: New comment added
Platonides posted a comment on MediaWiki.r114531. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114531#c32568 Commit summary for MediaWiki.r114531: Show the folder in which we're executing each subcommand if passed the -v parameter. Platonides's comment: dash is more strict there, bash seems to accept both = and ==. Fixed in r114573. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114493]: Revision status changed
Tim Starling changed the status of MediaWiki.r114493 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114493 Old status: deferred New status: ok Commit summary for MediaWiki.r114493: Fix path to jobs-loop.sh . Currently the job runners are operational, but any attempt to restart them would break them completely because they'd look for jobs-loop.sh in the wrong place ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114531]: Revision status changed
Reedy changed the status of MediaWiki.r114531 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114531 Old status: fixme New status: new Commit summary for MediaWiki.r114531: Show the folder in which we're executing each subcommand if passed the -v parameter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114587]: New comment added
Bsitu posted a comment on MediaWiki.r114587. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114587#c32569 Commit summary for MediaWiki.r114587: fix title url so it includes namespace Bsitu's comment: Missing semicolon is added in the follow-up revision ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Replying to gerrit comments
On Wed, Mar 28, 2012 at 11:54 AM, Greg Sabino Mullane g...@endpoint.com wrote: * It really shouldn't be giving me the option to +1 my own commit This is gerrit issue 308[0], and one that I'd really like to see fixed. Commenting on your own code is perfectly fine--you have to have a chance to respond to criticism. However I find the ability to +1 yourself confusing/useless as best and +2's of your own code to be actively harmful (except in emergency/site-ops type stuff) since it basically ducks the review process. -1/-2 of your own code is useful--it's great for This is a work in progress, please do not merge yet but I'd like feedback -Chad [0] http://code.google.com/p/gerrit/issues/detail?id=308 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Replying to gerrit comments
On 29/03/12 03:19, Roan Kattouw wrote: It's very strange, but yes, this is the standard way. And Jeroen is right, it sucks that you can't see what you're replying to. Having an AJAX interface here would be nice (inline comments do have this). A minor nitpick: the whole of the Gerrit web UI is AJAX (or at least AJAJ). For example, when you ask for a change list, the HTML is built on the client side from a JSON response that looks a bit like this: http://paste.tstarling.com/p/TymHnr.html I guess we'll have to think of some other term for a usable web UI. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikimedia and IPv6
On Thu, Mar 29, 2012 at 1:46 AM, Roan Kattouw roan.katt...@gmail.com wrote: it was something along the lines of: * Nova did not have IPv6 support when he set up labs * Newer versions of Nova support IPv6 but assume you create the IPv4 and IPv6 networks at the same time -- Therefore there is no reasonable way to add IPv6 support to an existing IPv4-only Nova setup Yeah, it looks like they are working on it but there is still a lot of TBD in there, see here: http://wiki.openstack.org/ipv6support https://blueprints.launchpad.net/nova/+spec/ipv6-support https://code.launchpad.net/~ntt-pf-lab/nova/ipv6-support -- -- Daniel Zahn dz...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
