https://bugzilla.xfce.org/show_bug.cgi?id=14576
alexxcons changed:
What|Removed |Added
CC||cy...@yahoo.com
--- Comment #83 from alexxcons
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #82 from ToZ ---
@HYPERION, see: https://bugzilla.xfce.org/show_bug.cgi?id=14693
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #81 from HYPERION ---
Hi,
Regression in tumbler 0.2.2 : folder thumbnails show and vanish :(
JP
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mail
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #80 from alexxcons ---
uh, ok ... changed back to 1.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #79 from HYPERION ---
@Alex : I really meant ERROR : at this point of exit : all the tests have
failed, so we have to inform the caller program that we failed ;)
Not sure Tumbler uses the exit code from child thumbnailer anyway...
JP
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #78 from alexxcons ---
@ToZ
Regarding the preferences dialog I would agree with HYPERION. It's already
configurable via the config file and the "show thumbnails" enum, should be
sufficient.
Even if we would provide a checkbox, in thunar
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #77 from HYPERION ---
#!/bin/bash
convert -thumbnail "$1" "$2/folder.jpg" "$3" 1>/dev/null 2>&1 ||\
convert -thumbnail "$1" "$2/.folder.jpg" "$3" 1>/dev/null 2>&1 ||\
convert -thumbnail "$1" "$2/folder.png" "$3" 1>/dev/null 2>&1 ||\
con
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #76 from HYPERION ---
Something needs to be improved to handle folder names containing spaces :
#!/bin/bash
convert -thumbnail "$1" "$2/folder.jpg" "$3" ||\
convert -thu
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
URL||FIXED
--- Comment #75 from HYPERION ---
@Toz
O
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #74 from ToZ ---
@alexxcons, the patch doesn't include the setting in the dialog. Is the intent
to keep it a hidden setting now (which we should document), or will you push
the dialog change as well?
Also, I've found that the convert co
https://bugzilla.xfce.org/show_bug.cgi?id=14576
alexxcons changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #72 from Git Bot ---
HYPERION referenced this bugreport in commit
543c23b0f011dde5a571bca3525e80bb7e273561
Add support for folder.jpg (Bug #14576)
https://git.xfce.org/xfce/thunar/commit?id=543c23b0f011dde5a571bca3525e80bb7e273561
--
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #71 from Git Bot ---
HYPERION referenced this bugreport in commit
58b7da73dcee057ba4ed2756ee989c09c1e9c358
Add support for folder.jpg (Bug #14576)
https://git.xfce.org/xfce/thunar/commit?id=58b7da73dcee057ba4ed2756ee989c09c1e9c358
--
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #70 from HYPERION ---
@All This is cleaner, seems to work better, and if confirmed : is not a
workaround anymore ;)
"/usr/bin/folder-thumbnailer" as follow :
#!/bin/bash
convert -thumbnail "$1" "$2/folder.jpg" "$3" ||\
convert -thumbn
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #69 from HYPERION ---
@All
Seems that I found the reason for persistant thumbs, and a workaround :)
The reason : each thumb file in the cache is named after the md5 hash of the
URI of the thumbed object (here : the folder). folder chan
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #68 from Andre Miranda ---
@Alex, LGTM.
I just wonder if this thumbnailer has to be 1) shipped by tumbler 2) shipped by
distributions 3) created manually by users.
Thank you all for patiently investigating and testing, specially HYPER
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #67 from ToZ ---
Patch works well.
@HYPERION, thank you very much for this contribution. This is something I've
heard a lot of requests for.
--
You are receiving this mail because:
You are the assignee for the bug.
___
https://bugzilla.xfce.org/show_bug.cgi?id=14576
alexxcons changed:
What|Removed |Added
Attachment #7883|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #65 from HYPERION ---
@alex : I looked at the Thunar "file monitor" mechanism, and found nothing
specific to folders. I believe that the problem of persistant thumb seems to
come from the way tumbler desktop plugin works : once a thumbna
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #64 from alexxcons ---
@HYPERION
If there is a change that thunar is involved in the mtime problem, I would
prefer to wait a bit with the commit. I guess there is a third if(..) which
needs to get modified ( Trying to keep the number of
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #63 from HYPERION ---
To support more images files :
"/usr/bin/folder-thumbnailer" as follow :
#!/bin/bash
convert -thumbnail "$1" "$2/folder.jpg" "$3" ||\
convert -thumbnail "$1" "$2/.folder.jpg" "$3" ||\
convert -thumbnail "$1" "$2/
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #62 from HYPERION ---
@Toz : not watching for mtime for folders may be related to the way Thunar
handles thumbnails... (maybe I forgot to remove some test statement, someone
knows ?).
@All Anyway : the icon rollback problem doesn't prev
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #61 from ToZ ---
The performance is much better with this solution. Plus, I like the fact that
you can specify the file to use for the folder icon (folder.jpg, .folder.png,
etc) directly in the thumbnailer file.
Reverting to the default
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #60 from HYPERION ---
@Alex : up to you to commit the small change to Thunar code ? ok ?
I will send the folder.thumbnailer solution to tumbler team ;)
JP
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #59 from HYPERION ---
To recover the origin theme icon, two solutions, so far :
1) remove folder.jpg and then rename the folder twice (to be back to original
name)
2) remove folder.jpg and then clear the thumbnail cache
Not very user
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #58 from alexxcons ---
Works fine for me. Congratz, looks like you found another nice solution ! :P
Some minor thing:
- Instead of adding another indention in this already huge and deep if/else
block in thunar-icon-factory.c , code woul
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
Attachment #7879|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #56 from HYPERION ---
Hi All,
Tumbler has the capability of loading ".thumbnailer" files placed in the
/usr/share/thumbnailers folder (aka Desktop Thumbnailer Plugin, see : plugin
https://docs.xfce.org/xfce/thunar/tumbler ).
This
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #55 from alexxcons ---
Thanks for testing all !
@ToZ
- With this patch there is no need for xfconf-query. I added a checkbox for it
in preferences-->display ... I used the tooltip to give info on the supported
files-names ... We as we
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #54 from HYPERION ---
Agreed, tumbler is probably better for the purpose.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.o
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #53 from Andre Miranda ---
@ToZ I couldn't test the patch yet (looks simple and correct to me), but this
is a considerable performance hit, we can't afford this even if the feature is
opt-in.
@alexxcons Now I think a tumbler plugin for
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #52 from ToZ ---
Scrolling results in thunar cpu usage increase to @30-40% while scrolling.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing lis
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #51 from ToZ ---
The patch works. To enable the hidden setting: "xfconf-query -c thunar -p
/misc-folder-custom-icons --create -t bool -s true".
However, there is a noticeable impact when first loading a folder and a smaller
performance
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #50 from alexxcons ---
Here is my first shot:
https://github.com/alexxcons/thunar/commit/50d1f709f7a2ccf3a5ecd42901095abce1e49c93
Please let me know if it would be fine for you like that.
( And I would be happy if you could check my gr
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #49 from HYPERION ---
ok :)
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #48 from alexxcons ---
Yes, it is simple, but IMO no, that does not make it beautiful. And no, I would
not call it fast, since, it will slow down thunar for all users who do not use
the feature.
- IMO it should be possible to disable a h
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #47 from HYPERION ---
ready for merge ?
https://github.com/H1p8r10n/thunar/commit/d6d8d7c042bba84befe8f843957f9d1b8c290188
--
You are receiving this mail because:
You are the assignee for the bug.
_
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #46 from HYPERION ---
simple is beautiful !
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailm
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #45 from HYPERION ---
As it is now : the code is fast, simple, and already triggered by an option :
enabling thumbnails : with a few lines of code the result is really great.
Taking distance with the feature : it's just another kind of
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #44 from Andre Miranda ---
I think we are overthinking this feature, ["folder.png", ".folder.png",
"folder.jpg", ".folder.jpg"] should be enough, not need to customize it via a
hidden property.
As performance is a concern, I guess an opt
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #43 from alexxcons ---
Here some doc regarding gtk3 Object Properties: [0] not taht much, I did
not find a better doc for it so far.
Here is some doc. regarding exo bindings: [1]
Think you will only need one exo_binding between th
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #42 from HYPERION ---
I need some help to understand the way exo_binding ; Object properties ; and
all these API work.
For the moment it's obscure, and unfortunately I have not enough time to
investigate :/
--
You are receiving this m
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #41 from alexxcons ---
Thanks alot for your work, the feature works fine for me when I compile your
master branch !
A fork on github is nice ! Regarding the code, I will directly comment into the
commit there. ( Hope we will have our ne
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #40 from HYPERION ---
github.com/H1p8r10n/thunar/commit/949d184590d18369747b9d63954c244a2004f457
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailin
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #39 from HYPERION ---
ok :) clear !
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listi
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #38 from ToZ ---
@Hyperion, without the test for custom_icon, thunar was spitting out alot of
"GLib-CRITICAL **: g_file_test: assertion 'filename != NULL' failed" messages
similar to this bug report: https://bugzilla.xfce.org/show_bug.cg
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #37 from HYPERION ---
ps : I totally agree with the hidden ".folder.jpg" idea, instead of shown
"folder.jpg"
But :
- png is not usual for cover thumbs
- music albums are often provided with "folder.jpg" , never with ".folder.jpg"
--
Y
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #36 from HYPERION ---
git contrib ;)
https://github.com/H1p8r10n/thunar/commit/aeee54171efcfda194258860645a5dbf780d32c7
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #35 from HYPERION ---
1 remark : you added a test for custom_icon != NULL :
custom_icon = g_strconcat (g_file_get_path (thunar_file_get_file (file)), "/",
"folder.jpg", NULL);
+ if (custom_icon != NULL && g_file_test(custom_ico
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #34 from HYPERION ---
It's a matter of performance impact : my second patch did it, but too much
impact imho.
We have to choose
JP
--
You are receiving this mail because:
You are the assignee for the bug.
___
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #33 from ToZ ---
My last sentence is confusing. We should add support for hidden and png files.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #32 from ToZ ---
Created attachment 7883
--> https://bugzilla.xfce.org/attachment.cgi?id=7883&action=edit
Patch to apply to git
Attached is a modified version of Hyperion's last patch that applies against
thunar git. I made a few corr
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #31 from HYPERION ---
line 906
if (thunar_icon_factory_get_show_thumbnail (factory, file))
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing l
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #30 from HYPERION ---
Created attachment 7880
--> https://bugzilla.xfce.org/attachment.cgi?id=7880&action=edit
thunar-icon-factory.c (master)
try to build master with this file ... (not tested)
build fails here...
--
You are receiv
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #29 from HYPERION ---
latest stable = tag Thunar-1.8.1
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfc
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #28 from alexxcons ---
Master build fine for me here .. did you try to build without the patch / a
clean checkout ?
Latest patch does not work for me, when applied to master:
File to patch: thunar/thunar-icon-factory.c
patching file thu
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
Attachment #7874|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #26 from Andre Miranda ---
Hi HYPERION,
The latest patch looks very simple, so we may support both ways of loading
folders images.
I would like to point out a couple of things:
- pay attention to indentation and white spaces, Xfce has n
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
Attachment #7871|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #24 from HYPERION ---
sorry for previous patch with bad API usage
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
Attachment #7867|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #22 from alexxcons ---
I just had another chat with Andre Miranda .. for some strange coincidence we
both so far overlooked that xfdesktop already implements this feature :X
Sorry for that , you already pointed out by your first post, b
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #21 from HYPERION ---
or maybe as a thunar plugin ? (ie : "Thunar Music Library Plugin"
--
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xf
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #20 from HYPERION ---
Created attachment 7869
--> https://bugzilla.xfce.org/attachment.cgi?id=7869&action=edit
Another exemple of Thunar as a Music Library File Manager
Another exemple of Thunar as a Music Library File Manager
--
Yo
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #19 from HYPERION ---
Hi,
Thanks for the feedback, before going further, let me clarify again the purpose
of my patch :
-> primary goal is to make Thunar behave the way XFDESKTOP already do for music
folders you put on the desktop.
"
https://bugzilla.xfce.org/show_bug.cgi?id=14576
Andre Miranda changed:
What|Removed |Added
CC||andre...@xfce.org
--- Comment #18 from Andr
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
Attachment #7866|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #16 from HYPERION ---
Comment on attachment 7866
--> https://bugzilla.xfce.org/attachment.cgi?id=7866
improved patch (memory cleaning)
>diff -rNaud Thunar-1.8.1-OLD/thunar/thunar-icon-factory.c
>Thunar-1.8.1/thunar/thunar-icon-factor
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
Attachment #7856|0 |1
is obsolete|
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #14 from HYPERION ---
Thanks for the tips, I will improve the code in this way.
About having custom icons : I believe that it's really useful specially for
folders, and a bit less interesting for regular files which already have
mimetyp
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #13 from alexxcons ---
Regarding the feature in dolphin:
The dolphin solution is more like the way you propose:
A file called ".directory" is added to a folder which stores the path to the
used image. here an example:
> [Desktop Entry
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #12 from alexxcons ---
thanks, seems like you fixed it, now the patch works fine for me.
Some further improvement suggestions for your patch to prevent memory leaking:
- the return value of g_strconcat always need to be freed. Currently
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #11 from HYPERION ---
Created attachment 7864
--> https://bugzilla.xfce.org/attachment.cgi?id=7864&action=edit
new patch, shouldn't segfault
new patch, can't reproduce segfault here, so I g_freed some gchar just in
case... :/
some he
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #10 from alexxcons ---
I am not saying that setting the icon manually should be the only option. Just
think it should be the default option.
But you are right that this is only a nice add .. .the cherry on the cake.
Primary goal should
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #9 from HYPERION ---
It's not the same feature : having folder.jpg icons inside the directories
allows to deal with music libraries : if you have 2000 directories (1 per
album), each one with a cover artwork : setting custom images manua
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #8 from alexxcons ---
Just one thing I forgot:
For dolphin the feature is only available for folders. However nautilus/nemo
allow to have custom icons for any single file.
IMO it would not hurt to allow custom icons for every file.
--
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #7 from alexxcons ---
Created attachment 7862
--> https://bugzilla.xfce.org/attachment.cgi?id=7862&action=edit
backtrace
I just took a look into nautilus, nemo and dolphin, which all already have this
feature.
IMO the GUI approach th
https://bugzilla.xfce.org/show_bug.cgi?id=14576
HYPERION changed:
What|Removed |Added
CC||h1p8r...@yandex.com
--- Comment #6 from HYPERION
https://bugzilla.xfce.org/show_bug.cgi?id=14576
ToZ changed:
What|Removed |Added
CC||tony.pau...@gmail.com
--- Comment #5 from ToZ ---
Cr
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #4 from HYPERION ---
Created attachment 7859
--> https://bugzilla.xfce.org/attachment.cgi?id=7859&action=edit
Thunar as Music Library Manager
An exemple with Thunar as Music Library Manager : look at the shortcuts on the
left ;)
--
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #3 from HYPERION ---
Here's the xfdesktop way (xfdesktop-regular-file-icon.c) :
/* builds a folder/file path and then tests if that file is a valid image.
* returns the file location if it does, NULL if it doesn't */
static gchar *
xfd
https://bugzilla.xfce.org/show_bug.cgi?id=14576
alexxcons changed:
What|Removed |Added
CC||ac...@gmx.de
--- Comment #2 from alexxcons ---
https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #1 from HYPERION ---
Created attachment 7857
--> https://bugzilla.xfce.org/attachment.cgi?id=7857&action=edit
screenshot
--
You are receiving this mail because:
You are the assignee for the bug.
__
83 matches
Mail list logo
