Re: [PATCH 5/6] glx: Flatten -DXFree86Server

2011-03-15 Thread Eric Anholt
On Tue, 15 Mar 2011 06:05:39 +1000, Dave Airlie airl...@gmail.com wrote: On Tue, Mar 15, 2011 at 5:31 AM, Adam Jackson a...@redhat.com wrote: Always defined by the makefile, so, just get rid of it. Signed-off-by: Adam Jackson a...@redhat.com ---  glx/Makefile.am |    1 -  glx/glapi.c  

Re: [ATCH 0/5] GLX context tag reimplementation

2011-03-23 Thread Eric Anholt
. But fortunately there's a simpler implementation that I believe to be within the letter of the law, which is what the first patch in this series is. The rest is merely cleanup. This series is: Reviewed-by:Eric Anholt e...@anholt.net pgptwmvSAlXLp.pgp Description: PGP signature

Re: [PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 11:29:48 -0400, Adam Jackson a...@redhat.com wrote: There are, in general, more fbconfig depths than visual depths. fbconfigs need not support Window rendering, however any that do must have an associated visual ID (which we got right), and any that do not must not claim

Re: [PATCH] Pack swap complete bits into an XEvent

2011-04-28 Thread Eric Anholt
On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: The defintion of the swap complete event was wrong; XEvents are only 32 bytes long, and with padding the swap event was longer. So use some creative packing to get all the bits we want transmitted. Requires a

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-04-28 Thread Eric Anholt
On Thu, 28 Apr 2011 13:27:22 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Use the new swap event structure packing and send it to the client if possible. This means tracking client version information when clients connect. If they don't support the new packing, they'll get the old

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Eric Anholt
On Wed, 4 May 2011 18:21:20 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 5 May 2011 11:17:02 +1000 Dave Airlie airl...@gmail.com wrote: So I wasn't watching and glproto broke its interface, and I think its bad. Why? You can no longer bisect things across this point

Re: More DRI2 invalidate stuff

2011-05-09 Thread Eric Anholt
On Fri, 6 May 2011 18:18:14 +0300, ville.syrj...@nokia.com wrote: The proposed DRI@ invalidate patch [1] causes a lot more invalidate events to be sent out. That will cause processes to wake up needlessly. Eg. if an unredirected fullscreen app is flipping, each flip will also send an

Re: [PATCH rendercheck] Report the success_mask to stdout

2011-05-09 Thread Eric Anholt
On Sat, 7 May 2011 18:20:17 -0700, Jeremy Huddleston jerem...@apple.com wrote: This was previously computed but never passed on to the caller. Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston jerem...@apple.com Doing something useful with those success flags would be nice,

Re: [PATCH rendercheck] Report which test groups passed successfully

2011-05-10 Thread Eric Anholt
On Mon, 9 May 2011 18:31:34 -0700, Jeremy Huddleston jerem...@apple.com wrote: This was previously computed but never passed on to the caller. Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston jerem...@apple.com Bonus cleanup of the rest of the code. Nice. Looks like I

Re: [PATCH] dri2proto: add new DRI2BufferSwapComplete struct to match spec

2011-05-10 Thread Eric Anholt
On Thu, 5 May 2011 12:42:43 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Just add a new struct to remain compatible with existing code. Reviewed-by: Eric Anholt e...@anholt.net pgpPWYDLhJdKT.pgp Description: PGP signature ___ xorg-devel

Re: [PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

2011-05-10 Thread Eric Anholt
On Thu, 5 May 2011 12:39:57 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Just add a new struct to remain compatible with existing code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/configure.ac b/configure.ac index a3047e4..a6c301c 100644 --- a/configure.ac

Re: [PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

2011-05-10 Thread Eric Anholt
On Tue, 10 May 2011 12:32:24 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 10 May 2011 11:59:56 -0700 Eric Anholt e...@anholt.net wrote: On Thu, 5 May 2011 12:39:57 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Just add a new struct to remain compatible

Re: [PATCH] dri2: Pass AsyncSwap [vblank_mode=0] requests to the drivers

2011-06-08 Thread Eric Anholt
On Wed, 8 Jun 2011 12:03:04 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 8 Jun 2011 19:06:11 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Currently, the midlayer dri2 code intercepts vblank_mode=0 SwapBuffers and converts it to a CopyRegion request. This prevents the

[PATCH 2/2] Set DamageSetReportAfterOp to true for the damage extension

2010-10-28 Thread Eric Anholt
From: Kristian Høgsberg k...@bitplanet.net Change the damage extension reporter to queue up events after we chain to the wrapped functions. Damage events are typically sent out after the rendering happens anyway, since we submit batch buffers from the flush callback chain and then flush client

[PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-28 Thread Eric Anholt
with client damage changed to reportAfter. Signed-off-by: Eric Anholt e...@anholt.net --- composite/compalloc.c |2 +- composite/compwindow.c|4 ++-- damageext/damageext.c |4 ++-- exa/exa.c |3 +-- glx/glxdri.c |4

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-29 Thread Eric Anholt
On Fri, 29 Oct 2010 10:46:00 +0200, Michel Dänzer mic...@daenzer.net wrote: On Don, 2010-10-28 at 20:46 -0700, Eric Anholt wrote: In all these cases, any rendering implied by this damage has already occurred, and we want to get the damage out to the client. Some of the DamageRegionAppend

Re: [PATCH] Define/use pad_to_pow_two() instead of open coding it

2010-03-24 Thread Eric Anholt
On Wed, 24 Mar 2010 14:59:04 -0400, Matt Turner matts...@gmail.com wrote: On Wed, Mar 24, 2010 at 2:56 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Matt Turner matts...@gmail.com Date: Wed, 24 Mar 2010 13:57:15 -0400 diff --git a/hw/dmx/dmxpict.c b/hw/dmx/dmxpict.c index

Re: [PATCH] configure: introduce --{enable, disable}-syscall-clock

2010-04-02 Thread Eric Anholt
On Mon, 29 Mar 2010 14:59:35 -0400, Adam Jackson a...@redhat.com wrote: On Mon, 2010-03-29 at 11:02 -0700, Alan Coopersmith wrote: Tiago Vignatti wrote: Some systems might not want to link against rt and pthread libraries simply to implement monotonic clock, inside GetTimeInMillis().

Re: [PATCH] configure: introduce --{enable, disable}-syscall-clock

2010-04-06 Thread Eric Anholt
On Mon, 05 Apr 2010 10:20:04 -0400, Adam Jackson a...@redhat.com wrote: On Fri, 2010-04-02 at 11:13 -1000, Eric Anholt wrote: On Mon, 29 Mar 2010 14:59:35 -0400, Adam Jackson a...@redhat.com wrote: Yeah, it's not really something I want Linux to default to using either. I mean, we're

Re: Merged proto package

2010-04-06 Thread Eric Anholt
On Tue, 06 Apr 2010 15:41:41 -0700, Keith Packard kei...@keithp.com wrote: I've written some scripts that construct a merged proto package from the existing proto packages. They're not fancy, but do preserve the entire history of each sub package as they get merged in. Here's the merged

Re: [PATCH 4/4] miext/damage: Only wrap into the GC ops chain if there's a listener

2011-12-13 Thread Eric Anholt
square 6000 trep @ 0.0005 msec (2180983.0/sec): ShmPutImage 10x10 square Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Eric Anholt e...@anholt.net pgpOtez327FCq.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 01/11] glx: Fix mishandling of shared contexts

2011-12-24 Thread Eric Anholt
code to that effect, and seems like the only possible place), which would make this: Reviewed-by: Eric Anholt e...@anholt.net pgp5HGNcSrGHG.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH intel-gpu-tools 00/10] Upgrade module configuration - Part 2

2012-01-03 Thread Eric Anholt
for updates to automake infrastructure for this project are Acked-by: Eric Anholt e...@anholt.net I think I cribbed from xf86-video-intel when I originally did this stuff, and I didn't mean for it to be gratuitously different from our other projects, as I recall. pgp15r1mBdcSV.pgp Description: PGP

Re: [PATCH:intel-gpu-tools 0/6] Port to Solaris

2012-01-08 Thread Eric Anholt
values instead of using gcc range extension include fcntl.h in lib/intel_mmio.c for open() prototype on Solaris Fix pthread compiler flags to work on Solaris and with Studio compiler Acked-by: Eric Anholt e...@anholt.net pgp5XP5DaXLS9.pgp Description: PGP signature

Re: [PATCH synaptics 06/10] Drop circular pad support

2012-05-09 Thread Eric Anholt
On Wed, 9 May 2012 15:34:34 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Do such devices still exist? Yeah, I use a 6 year old one as my i915 test system. But then, it doesn't have any particular synaptics configuration done to it, so I guess the driver never knew it. Nor do I

Re: [PATCH 01/02] dri2proto: Add DRI2GetParam request

2012-05-15 Thread Eric Anholt
On Thu, 10 May 2012 00:04:36 -0700, Chad Versace chad.vers...@linux.intel.com wrote: /* * Events @@ -330,4 +331,32 @@ typedef struct { } xDRI2InvalidateBuffers; #define sz_xDRI2InvalidateBuffers 32 +typedef struct { +CARD8 reqType; +CARD8 dri2ReqType; +CARD16

Re: [PATCH v3 02/02] dri2: Add DRI2GetParam request

2012-05-17 Thread Eric Anholt
-by: Eric Anholt e...@anholt.net pgpSOHodxuXcU.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [Mesa-dev] [PATCH] RFC: refactor out dri2 proto code into libdri2

2011-09-27 Thread Eric Anholt
On Thu, 22 Sep 2011 15:36:07 -0500, Rob Clark rob.cl...@linaro.org wrote: Since I was working on some extensions to DRI2 protocol for handling video, it occurred to me that it might be easier to extend the protocol if there weren't N different copies of dri2.c floating around in various

Re: [Pull v2] Glamor - fixed build failure, fixed coding style problem.

2011-10-20 Thread Eric Anholt
On Thu, 20 Oct 2011 09:54:29 +0200, Jamey Sharp ja...@minilop.net wrote: Non-text part: multipart/mixed Non-text part: multipart/signed This is also like Xgl, as I recall, in that Xgl was a large development effort happening inside a company (Novell, in that case) and then being dropped on the

Re: [PATCH] int10: Remove the vm86 and stub backends

2010-07-30 Thread Eric Anholt
On Thu, 29 Jul 2010 13:53:39 -0400, Adam Jackson a...@nwnk.net wrote: On Wed, 2010-07-28 at 11:35 -0400, Alex Deucher wrote: On Wed, Jul 28, 2010 at 11:29 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Isn't vm86 even further limited to just those machines running the Linux

Re: [PATCH mesa] Include search for non pkg-config libtalloc.

2010-09-08 Thread Eric Anholt
On Wed, 8 Sep 2010 17:01:25 -0400, Trevor Woerner twoer...@gmail.com wrote: From: Trevor Woerner twoer...@gmail.com Change search for libtalloc so a build which includes it in a non pkg-config'ized form will succeed. Signed-off-by: Trevor Woerner twoer...@gmail.com --- My system

Re: [patches] Fix broken Render implementation in several video drivers (radeonhd, mga, i128)

2009-03-06 Thread Eric Anholt
], and probably also take advantage of hardware acceleration that is present in -ati now [5]. I'm attaching the patches for the other two drivers to this email. Pushed, with one small tweak for mga. Thanks! -- Eric Anholt e...@anholt.net eric.anh...@intel.com

Re: Default local auth policy

2009-03-16 Thread Eric Anholt
difference in behaviour that you should have to ask for it. So. New -localuser option? Change the default? Bad idea, give up, take up farming? It sounds sensible, the only thing I'm concerned about is whether with this new default I could sudo X app and still get success. -- Eric Anholt e

Re: Default local auth policy

2009-03-20 Thread Eric Anholt
On Tue, 2009-03-17 at 14:06 -0400, Adam Jackson wrote: On Mon, 2009-03-16 at 12:52 -0700, Eric Anholt wrote: On Fri, 2009-03-13 at 13:46 -0400, Adam Jackson wrote: Currently, if you start X without -ac and without -auth, the default connection policy is to allow connections from localhost

Re: Temporary resolution changes?

2009-06-09 Thread Eric Anholt
flag perhaps something that can be passed to xrandr when a resolution is set? I'd love to see an extension to RandR to handle this. It's been a serious problem of X's modesetting APIs forever. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc

Re: [PATCH] xserver: remove all of RAC and access code

2009-07-29 Thread Eric Anholt
{ */ int PCIid; -/** - * Resources associated with this type of device. - */ -resRange *resList; } PciChipsets; add a dummy for resRange here so we don't have to rewrite the pci ids structs in lots of drivers. good idea or bad idea? Love it! -- Eric Anholt e

Re: [PATCH] pciaccess: remove xorg macros dependency

2009-07-29 Thread Eric Anholt
On Fri, 2009-07-17 at 02:05 +1000, Daniel Stone wrote: On Thu, Jul 16, 2009 at 08:27:12AM -0700, Eric Anholt wrote: On Thu, 2009-07-16 at 14:18 +0300, Tiago Vignatti wrote: -m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 or later before running autoconf/autogen

Re: [RFC PATCH] Only open the console if the video driver needs hardware access.

2009-10-02 Thread Eric Anholt
Perhaps we need a flag for this ddx needs console access as well as this ddx needs io ports and such -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCHv2] Remove static MAXSCREENS limit from Xext/shm.c.

2009-10-02 Thread Eric Anholt
-shmFuncs-CreatePixmap)( pDraw-pScreen, stuff-width, stuff-height, stuff-depth, shmdesc-addr + stuff-offset); -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description

Re: [PATCH 1/3] Remove shave now that automake-1.11 has AM_SILENT_RULES

2009-10-06 Thread Eric Anholt
to transition to automake-1.11. xserver 1.8 series will require automake-1.11 for silencing build noise. Signed-off-by: Alan Coopersmith alan.coopersm...@sun.com series is Reviewed-by: Eric Anholt e...@anholt.net -- Eric Anholt e...@anholt.net eric.anh...@intel.com

Re: [PATCH] Cast small-int values through intptr_t when they're passed as pointers.

2009-10-06 Thread Eric Anholt
of the mess we've got now. Yes. Yes yes yes. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http

Re: [Xcb] Thinking towards 7.6 katamari, including xcb

2009-10-29 Thread Eric Anholt
depend on unreleased libdrm. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman

Re: [RFC] DRI2 synchronization and swap bits

2009-10-30 Thread Eric Anholt
to do that). -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg

Re: New development model check-in.

2009-11-19 Thread Eric Anholt
. But could we please backup annarchy for imperfect people? -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel

Re: [PATCH] exa: Fix a warning when enabling DEBUG_TRACE_FALL

2014-02-19 Thread Eric Anholt
Reviewed-by: Eric Anholt e...@anholt.net pgptLseT_DeD7.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/6] xephyr: Pass incoming XCB events to the Xlib event filter.

2014-02-24 Thread Eric Anholt
This is the same thing that Qt ended up doing to get DRI2's event mangling to happen despite using an XCB event loop. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com --- hw/kdrive/ephyr/ephyr.c| 3 +++ hw/kdrive/ephyr/ephyr_glamor_glx.c | 39

glamor: Enabling xephyr and Xorg.

2014-02-24 Thread Eric Anholt
Here's a short series to make the server glamor stuff actually testable. I'm now running glamor for my normal desktop, and the xephyr bits work too. I pulled out changes that would have required more from the intel 2d driver: now it's just a matter of not linking to the external module's

[PATCH 3/6] xorg: Build a glamor_egl module.

2014-02-24 Thread Eric Anholt
-by: Eric Anholt e...@anholt.net --- configure.ac | 11 +++ glamor/glamor_eglmodule.c | 3 ++- hw/xfree86/Makefile.am| 7 ++- hw/xfree86/glamor_egl/Makefile.am | 39 +++ include/dix-config.h.in | 3 +++ 5

[PATCH 1/6] xephyr: Build support for rendering with glamor using a -glamor option.

2014-02-24 Thread Eric Anholt
v2: Avoid making the Ximage for the screen that we'll never use, and drive the screen pixmap creation for glamor ourselves. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com (v1) --- configure.ac | 3 + glamor/glamor.c

[PATCH 6/6] glamor: Add support for DRI3.

2014-02-24 Thread Eric Anholt
discussion with keithp was that if the driver's dri3_open for a provider on a different screen, that's a core dri3 bug. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.h | 4 +- glamor/glamor_egl.c | 78 +++ hw

[PATCH 5/6] glamor: Rename the DRI-related pixmap functions.

2014-02-24 Thread Eric Anholt
There was confusion over whether they should have egl in the name, and they had DRI3 in the name even though they're useful to have without DRI3. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 10 +- glamor/glamor.h | 54

[PATCH 4/6] xorg: Connect up the glamor XV code, xorg DDX-only for now.

2014-02-24 Thread Eric Anholt
the xv ABI later). Signed-off-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am| 1 - glamor/glamor.h | 5 - glamor/glamor_eglmodule.c | 2 +- glamor/glamor_xv.c| 17 ++--- hw/xfree86/glamor_egl/Makefile.am | 1 + 5

Re: [PATCH 6/6] glamor: Add support for DRI3.

2014-02-25 Thread Eric Anholt
davya...@free.fr writes: Hi, While for XWayland we want to provide our own dri3_open, we still want to have glamor enabling the dri3 support That is rather a GLAMOR_NO_DRI3_SETUP flag and +if (glamor_egl-dri3_capable !(glamor_priv-flags GLAMOR_NO_DRI3)) { +/* Tell the

[PATCH 4/6] xorg: Connect up the glamor XV code, xorg DDX-only for now.

2014-02-25 Thread Eric Anholt
the xv ABI later). v3: Fix last minute breakage of having reintroduced xf86ScrnToScreen (one of the compat macros). Just use the drawable's pScreen instead. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am| 1 - glamor/glamor.h | 5

[PATCH 5/6 v2] glamor: Rename the DRI-related pixmap functions.

2014-02-26 Thread Eric Anholt
-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 10 +- glamor/glamor.h | 53 + glamor/glamor_egl.c | 12 ++-- 3 files changed, 40 insertions(+), 35 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index

Re: [PATCH 1/2] xf86Config: Fix warning: declaration of 'Pointer' shadows a global

2014-03-04 Thread Eric Anholt
pusehd the reviewed change for inputproto yet. I'd rather see that land. Patch 2/2 is: Reviewed-by: Eric Anholt e...@anholt.net (I had similar, but it got nitpicked and I just don't care what type gets used). pgpZYCmRHVfI_.pgp Description: PGP signature

[PULL] glamor xephyr and xorg changes

2014-03-05 Thread Eric Anholt
changes up to da08316605b26830b4d8f8fb2d9e69471cdc80ab: glamor: Add support for DRI3. (2014-03-05 13:10:24 -0800) Eric Anholt (6): xephyr: Build support for rendering with glamor using a -glamor option. xephyr: Pass

[PATCH 3/6] glamor: Add a note about the state of GL_ARB_map_buffer_range.

2014-03-06 Thread Eric Anholt
GLES2 Xephyr is failing due to lack of glMapBuffer() with the read bits set, and I decided to see if we can just switch everything to glMapBufferRange(). I'm undecided, and it largely depends on whether we find people are interested in using glamor for the windows X server. Signed-off-by: Eric

[PATCH 5/6] glamor: Fix a mismatched glamor_get/put_context().

2014-03-06 Thread Eric Anholt
We don't call GL in this function any more, so we can just drop the get. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 5 - 1 file changed, 5 deletions(-) diff --git a/glamor/glamor_gradient.c b/glamor/glamor_gradient.c index 9f6f1b1..6a7b528 100644 --- a/glamor

[PATCH 4/6] dix: Remove incorrect comment about privates.

2014-03-06 Thread Eric Anholt
PRIVATE_ALL was apparently dropped before this comment was added in commit 495fc3eb2d6c98bde82ae1278f89fcf131fd9bf8. Signed-off-by: Eric Anholt e...@anholt.net --- dix/privates.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dix/privates.c b/dix/privates.c index

[PATCH 2/6] glamor: Fix a spelling mistake in GLAMOR_PIXMAP_FBO_NOT_EXACT_SIZE.

2014-03-06 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 2 +- glamor/glamor_render.c | 2 +- glamor/glamor_utils.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index f1440f3..119e4d9 100644 --- a/glamor

[PATCH 6/6] xephyr: Don't forget to glViewport() before drawing the screen.

2014-03-06 Thread Eric Anholt
Fixes misrendering with cairogears. I had noticed the failure while trying to figure out what was going on with traps. Cairogears was apparently putting its results on the screen through putimage, which is a texture upload, so the last GL drawing was done to the size of the cairogears window,

little glamor cleanups (and a dix cleanup)

2014-03-06 Thread Eric Anholt
Here are some trivial patches from the glamor-server branch for review. I'm planning to send out the VBO changes next, which get us closer to making glamor not actually suck for performance. These are on the glamor-cleanups branch of my tree, branched from glamor-pull-request.

[PATCH 1/6] glamor: remove dead global variable.

2014-03-06 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 77197b5..f1440f3 100644 --- a/glamor/glamor_pixmap.c +++ b/glamor/glamor_pixmap.c @@ -697,7 +697,6

[PATCH] glx: Clear new FBConfig attributes to 0 by default.

2014-03-06 Thread Eric Anholt
system, which as you might guess was slightly lower performance than expected. Signed-off-by: Eric Anholt e...@anholt.net --- glx/glxdricommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c index 69d4b29..62cce13 100644 --- a/glx

[PULL] non-glamor build fix

2014-03-07 Thread Eric Anholt
I've got a few other patches with review on the list currently, but I want to give a little more time for anyone that cares to respond. A build fix seems important enough that we should shove it in now, though. The following changes since commit 78e508c9379b3976ac8e76b7aaa90ba86ad4e443: dix:

Re: [PATCH 1/6] xephyr: Build support for rendering with glamor using a -glamor option.

2014-03-07 Thread Eric Anholt
Jon TURNEY jon.tur...@dronecode.org.uk writes: On 25/02/2014 01:47, Eric Anholt wrote: v2: Avoid making the Ximage for the screen that we'll never use, and drive the screen pixmap creation for glamor ourselves. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei

[PATCH 8/9] glamor: Fix requested composite VBO size.

2014-03-08 Thread Eric Anholt
The argument to setup_composte_vbo is the number of verts. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_render.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c index 7829977..63bddfd 100644 --- a/glamor

[PATCH 5/9] glamor: Track the next vertex offset as we go for non-AA traps.

2014-03-08 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_trapezoid.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/glamor/glamor_trapezoid.c b/glamor/glamor_trapezoid.c index 7bbee4b..a774c37 100644 --- a/glamor/glamor_trapezoid.c +++ b/glamor

[PATCH 9/9] glamor: Use buffer_storage

2014-03-08 Thread Eric Anholt
changes. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 2 ++ glamor/glamor_priv.h | 1 + glamor/glamor_vbo.c | 51 +-- 3 files changed, 52 insertions(+), 2 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index

[PATCH 1/9] glamor: Drop the set of the context to NULL at the end of glamor ops.

2014-03-08 Thread Eric Anholt
The theory here was that it (which I copied from EGL) existed to fix up context switching with indirect GLX. But indirect GLX won't even try to set the context again unless its lastContext field is cleared, so we need to solve this a different way. Signed-off-by: Eric Anholt e...@anholt.net

[PATCH 2/9] glamor: Don't forget to set GL_INVALIDATE_RANGE_BIT on GL_ARB_mbr.

2014-03-08 Thread Eric Anholt
We don't need any current contents of the buffer, and this allows an implementation to make a temporary BO for a streamed upload if it wants to. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_render.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/glamor

[PATCH 6/9] glamor: Track the next vertex offset as we go for AA traps.

2014-03-08 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_trapezoid.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/glamor/glamor_trapezoid.c b/glamor/glamor_trapezoid.c index a774c37..4d2360d 100644 --- a/glamor/glamor_trapezoid.c +++ b/glamor

[PATCH 7/9] glamor: Extract the streamed vertex data code used by Render.

2014-03-08 Thread Eric Anholt
. - Add a comment about resize behavior. - Move glamor_vbo.c init code to glamor_vbo.c from glamor_render.c. (Derived from Markus's changes, but the GLES2 fix dropped almost all of the code in the functions). Signed-off-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am| 1

Re: [PATCH 5/9] glamor: Track the next vertex offset as we go for non-AA traps.

2014-03-10 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Markus Wick mar...@selfnet.de writes: Am 2014-03-09 05:07, schrieb Eric Anholt: +vb += i * glamor_priv-vb_stride / 4; This should be / sizeof(float) instead. presumably GLfloat? We've been pretty good about not using the ugly GL types so far

Re: [PATCH 9/9] glamor: Use buffer_storage

2014-03-10 Thread Eric Anholt
Markus Wick mar...@selfnet.de writes: Am 2014-03-09 05:07, schrieb Eric Anholt: diff --git a/glamor/glamor_vbo.c b/glamor/glamor_vbo.c index be2c2af..f736cbe 100644 --- a/glamor/glamor_vbo.c +++ b/glamor/glamor_vbo.c @@ -52,7 +52,49 @@ glamor_get_vbo_space(ScreenPtr screen, unsigned size

[PULL] glamor cleanups and VBO changes (and glx fix)

2014-03-10 Thread Eric Anholt
FBConfig attributes to 0 by default. (2014-03-10 13:31:14 -0700) Eric Anholt (14): glamor: remove dead global variable. glamor: Fix a spelling mistake in GLAMOR_PIXMAP_FBO_NOT_EXACT_SIZE. glamor: Add a note about

Re: [PATCH 7/9] glamor: Extract the streamed vertex data code used by Render.

2014-03-10 Thread Eric Anholt
Markus Wick mar...@selfnet.de writes: Am 2014-03-09 05:07, schrieb Eric Anholt: diff --git a/glamor/glamor_vbo.c b/glamor/glamor_vbo.c new file mode 100644 index 000..be2c2af --- /dev/null +++ b/glamor/glamor_vbo.c @@ -0,0 +1,138 @@ +/* + * Copyright © 2014 Intel Corporation

Re: [PULL] glamor cleanups and VBO changes (and glx fix)

2014-03-10 Thread Eric Anholt
Eric Anholt e...@anholt.net writes: keithp said he was comfortable with the level of review on these, so here goes. I dropped the two changes from the two series that didn't get review comments: glViewport() in ephyr, and dropping glXMakeCurrent(None). The following changes since commit

[PATCH 04/27] glamor: Move the EGL image to the normal pixmap private.

2014-03-11 Thread Eric Anholt
There's no reason to hide EGL from the rest of glamor, now that we have epoxy. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_egl.c | 89 +++- glamor/glamor_priv.h | 7 + 2 files changed, 47 insertions(+), 49 deletions(-) diff

glamor-server subset patch bomb

2014-03-11 Thread Eric Anholt
keithp said he was tired of the glamor stuff trickling in and wanted to just review it all at once and be done. I know I hate reviewing giant patch series, but who am I to argue with someone who says they want to do more review? This series fixes a bunch of CopyPlane XTS tests in Xephyr, thanks

[PATCH 06/27] sync: Add a header include necessary to use misyncstr.h

2014-03-11 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- miext/sync/misyncstr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/miext/sync/misyncstr.h b/miext/sync/misyncstr.h index b5bf6fd..ad69e8e 100644 --- a/miext/sync/misyncstr.h +++ b/miext/sync/misyncstr.h @@ -29,6 +29,7 @@ #define

[PATCH 09/27] glamor: Drop duplicated lines for getting pixmap state in GetImage.

2014-03-11 Thread Eric Anholt
No change in generated code size -- apparently the compiler figured it out. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_getimage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/glamor/glamor_getimage.c b/glamor/glamor_getimage.c index 5609e70..a932473 100644 --- a/glamor

[PATCH 21/27] glamor: Improve the performance of PushPixels by, well, pushing pixels.

2014-03-11 Thread Eric Anholt
Otherwise, mi will fall back to GetSpans()ing the bitmap, walking the bitmap, computing spans to be filled, and calling FillSpans(). Improves x11perf -f8text by 759.373% +/- 3.33096% (n=166) Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_glyphblt.c | 115

[PATCH 08/27] glamor: Return the stride/size for glamor_dri3_name_from_pixmap(), too.

2014-03-11 Thread Eric Anholt
Just like for a caller of glamor_dri3_fd_from_pixmap(), otherwise the consumer of that named buffer has no idea what GL chose for the stride. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 4 ++-- glamor/glamor.h | 3 ++- glamor/glamor_egl.c | 4 ++-- 3 files changed, 6

[PATCH 02/27] glamor: Drop the set of the context to NULL at the end of glamor ops.

2014-03-11 Thread Eric Anholt
The theory here was that it (which I copied from EGL) existed to fix up context switching with indirect GLX. But indirect GLX won't even try to set the context again unless its lastContext field is cleared, so we need to solve this a different way. Signed-off-by: Eric Anholt e...@anholt.net

[PATCH 13/27] glamor: Rename a variable to be more descriptive.

2014-03-11 Thread Eric Anholt
The valid_ prefix was used above to describe our allocation that gets reused multiple times, which is totally unrelated. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fill.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/glamor/glamor_fill.c b/glamor

[PATCH 10/27] glamor: Fix stack overflow in glamor_solid vertex handling.

2014-03-11 Thread Eric Anholt
ARRAY_SIZE(vertices) is 32 (floating point values), so we need to divide by the number of floats in a box like we do in the overflow case below. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor

[PATCH 12/27] glamor: Fix some integer overflow errors.

2014-03-11 Thread Eric Anholt
Imagine a nbox that was (UINT_MAX + small number) / (4 * 2 * sizeof(float)). We'd malloc a few bytes after the integer overflow, but glamor_set_normalize_vcoords would write over gigabytes of heap. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fill.c | 4 ++-- 1 file changed, 2

[PATCH 01/27] xephyr: Don't forget to glViewport() before drawing the screen.

2014-03-11 Thread Eric Anholt
, not the size of the xephyr screen. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr_glamor_glx.c | 15 +++ hw/kdrive/ephyr/ephyr_glamor_glx.h | 10 ++ hw/kdrive/ephyr/hostx.c| 4 3 files changed, 29 insertions(+) diff --git a/hw/kdrive/ephyr

[PATCH 07/27] glamor: Drop the body of the function for enabling DRI3 extensions.

2014-03-11 Thread Eric Anholt
The flag is already being set at glamor_egl_screen_init() time, so no need for the driver to separately call this. That said, leave the function around to keep the ABI compatibility. --- glamor/glamor.h | 8 glamor/glamor_egl.c | 7 +-- 2 files changed, 1 insertion(+), 14

[PATCH 17/27] glamor: Drop unused GLAMOR_ACCESS_WO.

2014-03-11 Thread Eric Anholt
Nothing was using it, and it was going to complicate the glamor_prepare_access bugfixing I'm going to do next. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 11 +-- glamor/glamor_priv.h | 1 - 2 files changed, 1 insertion(+), 11 deletions(-) diff --git

[PATCH 22/27] glamor: Improve the performance of PolyGlyphBlt.

2014-03-11 Thread Eric Anholt
-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_glyphblt.c | 138 +++ 1 file changed, 138 insertions(+) diff --git a/glamor/glamor_glyphblt.c b/glamor/glamor_glyphblt.c index 0a99a95..5d785a0 100644 --- a/glamor/glamor_glyphblt.c +++ b/glamor

[PATCH 16/27] glamor: Replace some goofy enum-likes with a real enum.

2014-03-11 Thread Eric Anholt
This unpacks the bitfield into an int size, but my experience has been that packing bitfields doesn't matter for performance. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fbo.c | 2 +- glamor/glamor_priv.h | 25 - 2 files changed, 17 insertions(+), 10

[PATCH 25/27] glamor: Add an assert about an invariant the upload code relies on.

2014-03-11 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index f4782e6..ff07483 100644 --- a/glamor/glamor_pixmap.c +++ b/glamor/glamor_pixmap.c @@ -725,6 +725,7

[PATCH 23/27] glamor: Improve the performance of line fallbacks.

2014-03-11 Thread Eric Anholt
% +/- 9.8968% (n=5) Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_polylines.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/glamor/glamor_polylines.c b/glamor/glamor_polylines.c index 697fc9e..1adf45d 100644 --- a/glamor

[PATCH 19/27] glamor: Rely on nested mappings to handle src==dst and !prepare bugs.

2014-03-11 Thread Eric Anholt
Now that the core deals with that for us, we can avoid all this extra carefulness. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_addtraps.c | 2 +- glamor/glamor_copyarea.c | 14 ++ glamor/glamor_copyplane.c| 13 +++-- glamor/glamor_core.c

[PATCH 14/27] glamor: Rename more solid fill variables to clean up the code.

2014-03-11 Thread Eric Anholt
Now the error path of allocation is more obvious: We leave things in the a-few-boxes-at-a-time stack memory state. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fill.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/glamor

[PATCH 26/27] glamor: Don't forget to unmap our PBOs before usng them to upload.

2014-03-11 Thread Eric Anholt
were only getting reaped at PBO destroy time, after the upload. If the GL implementation wasn't coherent, it would have used stale data to do the texture upload. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 18/27] glamor: Allow nested mapping of pixmaps.

2014-03-11 Thread Eric Anholt
would result in trying to umap the inner and failing. By allowing nested mappings, we can fix both problems by not requiring the care from the caller, plus we can allow a simpler nesting of all the prepares in one if statement. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_core.c

  1   2   3   4   5   6   7   8   9   10   >