[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072072#comment-15072072
]
Naganarasimha G R commented on YARN-2934:
-
Thanks for the review and commit [~jira.shegalov],
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071392#comment-15071392
]
Gera Shegalov commented on YARN-2934:
-
+1 for YARN-2934.v2.004.patch. There is an extra space in "Error
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071408#comment-15071408
]
Hudson commented on YARN-2934:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9024 (See
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070917#comment-15070917
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070337#comment-15070337
]
Gera Shegalov commented on YARN-2934:
-
Hi [~Naganarasimha]. Thanks for updating the patch.
Things we
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066045#comment-15066045
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~jira.shegalov], Hope latest patch covers all your
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063681#comment-15063681
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064680#comment-15064680
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061718#comment-15061718
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061850#comment-15061850
]
Naganarasimha G R commented on YARN-2934:
-
oops missed this comment had uploaded the latest patch
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061768#comment-15061768
]
Gera Shegalov commented on YARN-2934:
-
-1 on manual regexes in favor of code reuse. 99.9% of YARN users
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061805#comment-15061805
]
Naganarasimha G R commented on YARN-2934:
-
bq. Simple globs I was suggesting already cover even
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061847#comment-15061847
]
Gera Shegalov commented on YARN-2934:
-
Use RawLocalFileSystem, we don't need the checksumming version:
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062435#comment-15062435
]
Naganarasimha G R commented on YARN-2934:
-
checkstyle is not valid or not induced due to this patch
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062412#comment-15062412
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063574#comment-15063574
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~jira.shegalov],
bq. Minor repetition is not big of
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063138#comment-15063138
]
Gera Shegalov commented on YARN-2934:
-
Thanks for the latest patch. good to see the patch lose 3kb,
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061978#comment-15061978
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061908#comment-15061908
]
Gera Shegalov commented on YARN-2934:
-
That should go to the exception message
{code}
422 } else
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061915#comment-15061915
]
Varun Vasudev commented on YARN-2934:
-
I'm not too fussed either way. Globs are probably easier for an
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063302#comment-15063302
]
Naganarasimha G R commented on YARN-2934:
-
[~jira.shegalov],
Ok got your intention, Just one
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063197#comment-15063197
]
Naganarasimha G R commented on YARN-2934:
-
[~jira.shegalov] thanks for the comments,
bq. good to
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063217#comment-15063217
]
Gera Shegalov commented on YARN-2934:
-
the message looks good to me.
> Improve handling of container's
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063227#comment-15063227
]
Gera Shegalov commented on YARN-2934:
-
Regarding my comment about the user, I meant the YARN app user.
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063486#comment-15063486
]
Gera Shegalov commented on YARN-2934:
-
Minor repetition is not big of a deal, IMO.
The reason I
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063487#comment-15063487
]
Gera Shegalov commented on YARN-2934:
-
Minor repetition is not big of a deal, IMO.
The reason I
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059943#comment-15059943
]
Gera Shegalov commented on YARN-2934:
-
Hi [~Naganarasimha],
Please make sure that the patch does not
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055078#comment-15055078
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050495#comment-15050495
]
Varun Vasudev commented on YARN-2934:
-
[~Naganarasimha] - one minor comment - can we make the tail size
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050887#comment-15050887
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~vvasudev],
Hi as per the
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048280#comment-15048280
]
Gera Shegalov commented on YARN-2934:
-
Thanks [~Naganarasimha]! I skimmed the patch, it is in a pretty
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048367#comment-15048367
]
Naganarasimha G R commented on YARN-2934:
-
Thanks [~jira.shegalov] !
> Improve handling of
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043421#comment-15043421
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~Varun Vasude], [~rohithsharma], [~jira.shegalov],
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024218#comment-15024218
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~varun_saxena], [~vvasudev], [~rohithsharma] &
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996545#comment-14996545
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996336#comment-14996336
]
Varun Saxena commented on YARN-2934:
Thanks [~Naganarasimha] for uploading the patch. Sorry could not
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996335#comment-14996335
]
Naganarasimha G R commented on YARN-2934:
-
Findbugs is not related to this jira and check style &
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996236#comment-14996236
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991374#comment-14991374
]
nijel commented on YARN-2934:
-
thanks [~Naganarasimha] for the patch
Few minor comments/doubts
1.
{code}
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991260#comment-14991260
]
Naganarasimha G R commented on YARN-2934:
-
Can one of the watchers, please take a look at the patch
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986197#comment-14986197
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~jira.shegalov], [~ste...@apache.org] &
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985026#comment-14985026
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985118#comment-14985118
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983874#comment-14983874
]
Hadoop QA commented on YARN-2934:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983977#comment-14983977
]
Varun Saxena commented on YARN-2934:
Thanks [~Naganarasimha] for updating the patch. In general , the
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983970#comment-14983970
]
Steve Loughran commented on YARN-2934:
--
good first pass.
I wouldn't worry about a configurable size
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983985#comment-14983985
]
Varun Saxena commented on YARN-2934:
One more comment :
FSDataInputStream#read is not guaranteed to
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983840#comment-14983840
]
Naganarasimha G R commented on YARN-2934:
-
[~jira.shegalov],
Apologies from my side, missed to
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624477#comment-14624477
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~jira.shegalov],
Sorry for the long
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625060#comment-14625060
]
Gera Shegalov commented on YARN-2934:
-
Hi [~Naganarasimha], yes I was thinking the
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268767#comment-14268767
]
Gera Shegalov commented on YARN-2934:
-
bq. Given this, even the tailed stderr is not
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268761#comment-14268761
]
Vinod Kumar Vavilapalli commented on YARN-2934:
---
bq. Yes it's related, but
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268639#comment-14268639
]
Vinod Kumar Vavilapalli commented on YARN-2934:
---
This seems like it is same
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268712#comment-14268712
]
Gera Shegalov commented on YARN-2934:
-
Yes it's related, but not exclusive to AM (try
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267377#comment-14267377
]
Gera Shegalov commented on YARN-2934:
-
ContainerLaunchContext is meant for a
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263911#comment-14263911
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~jira.shegalov],
Had a look at the
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239112#comment-14239112
]
Gera Shegalov commented on YARN-2934:
-
We need to make sure that stderr location is
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239518#comment-14239518
]
Naganarasimha G R commented on YARN-2934:
-
Hi [~jira.shegalov],
AFAIK some
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239762#comment-14239762
]
Xuan Gong commented on YARN-2934:
-
Hey, [~jira.shegalov]
we already have a
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239779#comment-14239779
]
Gera Shegalov commented on YARN-2934:
-
Hi [~Naganarasimha], yes that's what I meant.
[
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239785#comment-14239785
]
Gera Shegalov commented on YARN-2934:
-
Hi [~xgong],
bq. we already have a
61 matches
Mail list logo
