[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369766#comment-15369766
]
Hudson commented on YARN-3045:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701109#comment-14701109
]
Junping Du commented on YARN-3045:
--
I have commit latest (011) patch to YARN-2928 branch.
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699557#comment-14699557
]
Junping Du commented on YARN-3045:
--
Latest patch LGTM. But will confirm YARN-2928 branch
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700717#comment-14700717
]
Naganarasimha G R commented on YARN-3045:
-
Thanks [~djp] for reviewing this jira.
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700123#comment-14700123
]
Junping Du commented on YARN-3045:
--
Get confirmed with Vinod that new YARN-2928 branch is
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698511#comment-14698511
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698201#comment-14698201
]
Naganarasimha G R commented on YARN-3045:
-
Have run the findbugs manually most of
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697952#comment-14697952
]
Naganarasimha G R commented on YARN-3045:
-
[~djp] [~sjlee0],
Seems like patch
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698126#comment-14698126
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694242#comment-14694242
]
Sangjin Lee commented on YARN-3045:
---
The latest patch LGTM. But please hold off
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693424#comment-14693424
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693443#comment-14693443
]
Junping Du commented on YARN-3045:
--
Thanks [~Naganarasimha] for updating the patch!
bq. i
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693460#comment-14693460
]
Naganarasimha G R commented on YARN-3045:
-
Thanks [~djp] for checking it. Testcase
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692524#comment-14692524
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680545#comment-14680545
]
Sangjin Lee commented on YARN-3045:
---
Thanks for the update [~djp]. Just so we're all on
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680526#comment-14680526
]
Junping Du commented on YARN-3045:
--
bq. Junping Du one more favor can you join us in slack
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680874#comment-14680874
]
Sangjin Lee commented on YARN-3045:
---
Sounds good. Thanks.
[Event producers] Implement
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680942#comment-14680942
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp] [~sjlee0],
I was in transit
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680699#comment-14680699
]
Junping Du commented on YARN-3045:
--
[~sjlee0], there is no further big issues but still
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659937#comment-14659937
]
Junping Du commented on YARN-3045:
--
bq. The first patch was put up in April and later
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659829#comment-14659829
]
Junping Du commented on YARN-3045:
--
The Jenkins test wasn't triggered for some reason.
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660638#comment-14660638
]
Naganarasimha G R commented on YARN-3045:
-
Hi All,
bq. I appreciate Naganarasimha G
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660031#comment-14660031
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658386#comment-14658386
]
Junping Du commented on YARN-3045:
--
Thanks [~sjlee0] and [~Naganarasimha] for quickly
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658671#comment-14658671
]
Joep Rottinghuis commented on YARN-3045:
Yeah, the discussion thread here seems to
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659301#comment-14659301
]
Naganarasimha G R commented on YARN-3045:
-
[~djp] [~sjlee0]
Waiting for comments
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659323#comment-14659323
]
Sangjin Lee commented on YARN-3045:
---
bq. In my opinion last option is sufficient or shall
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659121#comment-14659121
]
Li Lu commented on YARN-3045:
-
bq. To speed up this JIRA's progress, I am fine with keep
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659266#comment-14659266
]
Sangjin Lee commented on YARN-3045:
---
bq. I see. I remember to see a JIRA work is to get
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653640#comment-14653640
]
Junping Du commented on YARN-3045:
--
Sorry for coming late on this as in travelling
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654644#comment-14654644
]
Naganarasimha G R commented on YARN-3045:
-
Based on the feed back may be can remove
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654744#comment-14654744
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654132#comment-14654132
]
Sangjin Lee commented on YARN-3045:
---
Thanks for your input [~djp]! Just wanted to clarify
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654724#comment-14654724
]
Naganarasimha G R commented on YARN-3045:
-
hi [~djp],
Thanks for the feedback.
bq.
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650231#comment-14650231
]
Naganarasimha G R commented on YARN-3045:
-
[~sjlee0], Thanks for the detailed
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650049#comment-14650049
]
Sangjin Lee commented on YARN-3045:
---
{quote}
Sorry was not able to completely get it. Are
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649985#comment-14649985
]
Naganarasimha G R commented on YARN-3045:
-
Thanks [~sjlee0], for clarifying and
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646992#comment-14646992
]
Naganarasimha G R commented on YARN-3045:
-
Thanks for the comments [~djp],
bq. We
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647163#comment-14647163
]
Sangjin Lee commented on YARN-3045:
---
bq. I went through the discussions and the patch of
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643347#comment-14643347
]
Junping Du commented on YARN-3045:
--
bq. Well was aware that priority was not to
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643656#comment-14643656
]
Sangjin Lee commented on YARN-3045:
---
Sorry it took me a while to catch up on this thread.
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643811#comment-14643811
]
Junping Du commented on YARN-3045:
--
bq. Regarding the application lifecycle events, I
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642150#comment-14642150
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp]
bq. 1.what we want to
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641295#comment-14641295
]
Junping Du commented on YARN-3045:
--
Thanks [~Naganarasimha] for updating the patch and
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639668#comment-14639668
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp] [~sjlee0], Based on
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636089#comment-14636089
]
Naganarasimha G R commented on YARN-3045:
-
Test case failures and white space issue
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635152#comment-14635152
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628072#comment-14628072
]
Varun Saxena commented on YARN-3045:
[~Naganarasimha], a couple of comments.
# In
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628077#comment-14628077
]
Varun Saxena commented on YARN-3045:
A cosmetic comment. Some of the lines are too long
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624472#comment-14624472
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp],
Sorry for the delayed
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619400#comment-14619400
]
Naganarasimha G R commented on YARN-3045:
-
+1, This seems to be a good idea for
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616763#comment-14616763
]
Junping Du commented on YARN-3045:
--
bq. IMO, the latter one sounds like a better choice
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615275#comment-14615275
]
Junping Du commented on YARN-3045:
--
Thanks [~Naganarasimha] for updating the patch!
One
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614346#comment-14614346
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp], [~sjlee0] [~zjshen]
The
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613995#comment-14613995
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602627#comment-14602627
]
Naganarasimha G R commented on YARN-3045:
-
thanks for reviewing [~djp] [~sjlee0],
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598054#comment-14598054
]
Sangjin Lee commented on YARN-3045:
---
{quote}
The lifecycle management of app collector is
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598012#comment-14598012
]
Junping Du commented on YARN-3045:
--
Thanks [~Naganarasimha] for updating the patch!
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598313#comment-14598313
]
Sangjin Lee commented on YARN-3045:
---
I took a quick pass at the latest patch. First,
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597488#comment-14597488
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595046#comment-14595046
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp],[~sjlee0] [~zjshen],
Please
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591439#comment-14591439
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~djp], Well the modifications/fixes
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590914#comment-14590914
]
Junping Du commented on YARN-3045:
--
Hi [~Naganarasimha], given YARN-3044 is already get
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566132#comment-14566132
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526177#comment-14526177
]
Hadoop QA commented on YARN-3045:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520929#comment-14520929
]
Vinod Kumar Vavilapalli commented on YARN-3045:
---
bq. IIUC from discussions in
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520332#comment-14520332
]
Sangjin Lee commented on YARN-3045:
---
Hi [~Naganarasimha], I do have one quick question on
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520902#comment-14520902
]
Naganarasimha G R commented on YARN-3045:
-
Thanks for the reviews [~sjlee0]
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520782#comment-14520782
]
Naganarasimha G R commented on YARN-3045:
-
Hi [~sjlee0],
I have modeled it
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520810#comment-14520810
]
Sangjin Lee commented on YARN-3045:
---
I'm not good at it either. :)
My basic idea is, if
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520843#comment-14520843
]
Vinod Kumar Vavilapalli commented on YARN-3045:
---
The allocated
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503429#comment-14503429
]
Hadoop QA commented on YARN-3045:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481412#comment-14481412
]
Naganarasimha G R commented on YARN-3045:
-
[~djp], As YARN-3334 is in, can I start
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481410#comment-14481410
]
Zhijie Shen commented on YARN-3045:
---
Container metrics publishing has been completed in
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481425#comment-14481425
]
Naganarasimha G R commented on YARN-3045:
-
:) parallely had commented ... Will
[
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481424#comment-14481424
]
Naganarasimha G R commented on YARN-3045:
-
:) parallely had commented ... Will
76 matches
Mail list logo