[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760627#comment-15760627
]
Sunil G commented on YARN-5877:
---
Thanks [~bibinchundatt] for the logs. Looks fine for me.
Newly added test
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754630#comment-15754630
]
Sunil G commented on YARN-5877:
---
Thanks [~bibinchundatt]
I tested this patch locally with LCE as well as
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753583#comment-15753583
]
Bibin A Chundatt commented on YARN-5877:
[~sunilg]
Please do review.
> Allow all nm-whitelist-env
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751858#comment-15751858
]
Hadoop QA commented on YARN-5877:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747494#comment-15747494
]
Bibin A Chundatt commented on YARN-5877:
Thank you [~sunilg] for review.
Will update patch after
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744559#comment-15744559
]
Sunil G commented on YARN-5877:
---
Thanks [~bibinchundatt] for the updated patch.
If testWriteEnvExport could
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744509#comment-15744509
]
Hadoop QA commented on YARN-5877:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741195#comment-15741195
]
Sunil G commented on YARN-5877:
---
In MAPREDUCE-6704, *temp.patch* was attached which is same as the latest
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732823#comment-15732823
]
Daniel Templeton commented on YARN-5877:
Latest patch is fine for me. Looking at it, though, it
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731791#comment-15731791
]
Sunil G commented on YARN-5877:
---
Thanks [~bibinchundatt] for the confirmation.
+1 from my end.
I will commit
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731701#comment-15731701
]
Bibin A Chundatt commented on YARN-5877:
[~sunilg]
With same {{ContainerExecutor}} changes. Test
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731662#comment-15731662
]
Sunil G commented on YARN-5877:
---
Thanks. I suppose that test is done with version 2 of patch, correct?
>
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731659#comment-15731659
]
Bibin A Chundatt commented on YARN-5877:
[~sunilg]
Last time i tested it was working fine. Also
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731218#comment-15731218
]
Sunil G commented on YARN-5877:
---
Latest patch looks fine for me as well.
[~bibinchundatt], could you please
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730955#comment-15730955
]
Hadoop QA commented on YARN-5877:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730178#comment-15730178
]
Daniel Templeton commented on YARN-5877:
Patch 2 looks fine to me.
> Allow all nm-whitelist-env to
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727893#comment-15727893
]
Sunil G commented on YARN-5877:
---
We have checked various cases for this issue in detail and had some offline
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15719529#comment-15719529
]
Varun Saxena commented on YARN-5877:
If the scenario I pointed out above is something which we do not
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717411#comment-15717411
]
Bibin A Chundatt commented on YARN-5877:
[~sunilg]
Is the current approach fine??
> Allow all
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695351#comment-15695351
]
Bibin A Chundatt commented on YARN-5877:
{quote}
How can we prevent user from configuring same
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695051#comment-15695051
]
Sunil G commented on YARN-5877:
---
[~varun_saxena] and [~bibinchundatt]
bq.Do we however need to provide a
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693953#comment-15693953
]
Varun Saxena commented on YARN-5877:
bq. Do we however need to provide a facility for container launch
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692597#comment-15692597
]
Varun Saxena commented on YARN-5877:
Moreover, maybe docker related logic can be moved to its relevant
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691396#comment-15691396
]
Varun Saxena commented on YARN-5877:
Thanks [~bibinchundatt] for the patch. The approach as such seems
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691010#comment-15691010
]
Hadoop QA commented on YARN-5877:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688969#comment-15688969
]
Bibin A Chundatt commented on YARN-5877:
For {{HADOOP_MAPRED_HOME}} this behaviour would be same
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679848#comment-15679848
]
Varun Saxena commented on YARN-5877:
Sorry for the confusion. Correct. We do not inherit parent
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679311#comment-15679311
]
Bibin A Chundatt commented on YARN-5877:
I am open to adding new configuration as mentioned
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679295#comment-15679295
]
Bibin A Chundatt commented on YARN-5877:
{quote}
Before the change in the patch, we could have set
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678620#comment-15678620
]
Hadoop QA commented on YARN-5877:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673988#comment-15673988
]
Hadoop QA commented on YARN-5877:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672448#comment-15672448
]
Sunil G commented on YARN-5877:
---
Yes. This is an option, however it will be difficult for an admin to know
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669571#comment-15669571
]
Varun Saxena commented on YARN-5877:
[~bibinchundatt],
I was leaning towards the same. Better to have a
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669254#comment-15669254
]
Bibin A Chundatt commented on YARN-5877:
[~sunilg]
{quote}
Ideally a mismatch may occur only from
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666859#comment-15666859
]
Sunil G commented on YARN-5877:
---
Thanks [~bibinchundatt].
I think this makes sense to me. I am still thinking
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666003#comment-15666003
]
Bibin A Chundatt commented on YARN-5877:
Thank you [~sunilg] for looking into issue.
{quote}
But
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664571#comment-15664571
]
Sunil G commented on YARN-5877:
---
Currently {{whitelistedEnv}} is used to emit special ENV variables which are
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663794#comment-15663794
]
Bibin A Chundatt commented on YARN-5877:
Thank you [~varun_saxena] and [~vvasudev]
During
[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663407#comment-15663407
]
Varun Saxena commented on YARN-5877:
Looked at the code. {{yarn.nodemanager.env-whitelist}} is
39 matches
Mail list logo
