[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942241#comment-15942241
]
Sunil G commented on YARN-5956:
---
test case failures are unrelated. And asf license too showing in some MR
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942217#comment-15942217
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942074#comment-15942074
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Thank you so much.
{quote}
However its not cleanly getting
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941799#comment-15941799
]
Hudson commented on YARN-5956:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11462 (See
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941790#comment-15941790
]
Sunil G commented on YARN-5956:
---
[~lewuathe]. I have committed patch in trunk. However its not cleanly
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938360#comment-15938360
]
Sunil G commented on YARN-5956:
---
Thanks folks. Committing shortly.
> Refactor ClientRMService
>
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938333#comment-15938333
]
Kai Sasaki commented on YARN-5956:
--
[~ajisakaa] Thanks. I filed a JIRA as followup.
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937784#comment-15937784
]
Akira Ajisaka commented on YARN-5956:
-
+1 LGTM.
I found the argument of checkReservationSystem method
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937696#comment-15937696
]
Rohith Sharma K S commented on YARN-5956:
-
+1 LGTM
> Refactor ClientRMService
>
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935828#comment-15935828
]
Sunil G commented on YARN-5956:
---
Latest patch seems fine for me. I will wait for a day. Please share if any
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930009#comment-15930009
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923702#comment-15923702
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923629#comment-15923629
]
Sunil G commented on YARN-5956:
---
Kicking jenkins again..
> Refactor ClientRMService
>
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903098#comment-15903098
]
Kai Sasaki commented on YARN-5956:
--
[~rohithsharma] [~sunilg] Sorry I overlooked and thank you so much for
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902833#comment-15902833
]
Sunil G commented on YARN-5956:
---
Yes [~rohithsharma], Thanks for pointing out. in
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902827#comment-15902827
]
Rohith Sharma K S commented on YARN-5956:
-
Overall patch looks good..
One comment is the patch is
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902638#comment-15902638
]
Sunil G commented on YARN-5956:
---
Latest patch looks fine for me. I can commit the patch tomorrow if there are
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901299#comment-15901299
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Thanks. I updated the patch. The failed test seems fails
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899642#comment-15899642
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894632#comment-15894632
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893385#comment-15893385
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Sure, let me check findbugs and check style issues.
>
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892422#comment-15892422
]
Sunil G commented on YARN-5956:
---
Thanks [~lewuathe].
Generally looks fine. Do you mind checking whether
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892405#comment-15892405
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885082#comment-15885082
]
Sunil G commented on YARN-5956:
---
Thanks [~lewuathe]
With current patch, {{checkAccess}} inside
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884742#comment-15884742
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Thanks for checking again. I agree with you. I think
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882124#comment-15882124
]
Sunil G commented on YARN-5956:
---
Thanks [~lewuathe] for updating the patch. We are almost there.
A major
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880665#comment-15880665
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868075#comment-15868075
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866049#comment-15866049
]
Sunil G commented on YARN-5956:
---
bq.I think that passing ApplicationAccessType to verifyUserAccessForRMApp
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865823#comment-15865823
]
Kai Sasaki commented on YARN-5956:
--
{quote}
This may cause issue because for any getter api, we just need
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863254#comment-15863254
]
Sunil G commented on YARN-5956:
---
I think there is a bit confusion. Lemme give a detailed concern from my end.
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862785#comment-15862785
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Thanks.
{quote}
GetApplicationReportResponse
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859779#comment-15859779
]
Sunil G commented on YARN-5956:
---
Thanks [~lewuathe].
Were u mentioning about {{YARN-5956.08.patch}}. IN that
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859464#comment-15859464
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Sorry for late. I checked redundant {{checkAccess}} call and
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856302#comment-15856302
]
Sunil G commented on YARN-5956:
---
HI [~kaisasak]
Thanks for the patch. I have some doubts in this patch.
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856154#comment-15856154
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823129#comment-15823129
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764549#comment-15764549
]
Sunil G commented on YARN-5956:
---
Thanks [~lewuathe]. After checking a bit more about
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764155#comment-15764155
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Thanks for checking again.
{quota}
In checkAccess java doc
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763606#comment-15763606
]
Sunil G commented on YARN-5956:
---
I went through patch one more time.
Some doubts:
1. In {{checkAccess}} java
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754635#comment-15754635
]
Sunil G commented on YARN-5956:
---
Yes. This test failure is not related.
Generally patch looks fine for me. I
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754495#comment-15754495
]
Kai Sasaki commented on YARN-5956:
--
[~sunilg] Test failure of {{TestRMRestart}} cannot be reproduced on
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741938#comment-15741938
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15740607#comment-15740607
]
Kai Sasaki commented on YARN-5956:
--
Sure, I'll take a look. Thanks!
> Refactor ClientRMService
>
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739785#comment-15739785
]
Sunil G commented on YARN-5956:
---
Test case failures looks related. [~lewuathe], could you please take a look.
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739678#comment-15739678
]
Sunil G commented on YARN-5956:
---
bq.Since COMPLETED_APP_STATE and isAppInCompletedStates looks same.
Yes..
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739633#comment-15739633
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732423#comment-15732423
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732259#comment-15732259
]
Kai Sasaki commented on YARN-5956:
--
{code}
private static final EnumSet COMPLETED_APP_STATES =
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721663#comment-15721663
]
Sunil G commented on YARN-5956:
---
[~lewuathe]
few comments.
1.
{code}
if
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15718193#comment-15718193
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15718125#comment-15718125
]
Kai Sasaki commented on YARN-5956:
--
I updated the patch but keeps {{ACTIVE_APP_STATES}} as it is.
{quote}
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717106#comment-15717106
]
Kai Sasaki commented on YARN-5956:
--
[~templedf] [~rohithsharma] [~sunilg]
Thanks for feedback. I'll update
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714710#comment-15714710
]
Sunil G commented on YARN-5956:
---
Adding few more possible cleanups:
- COMPLETED_APP_STATES and
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712775#comment-15712775
]
Rohith Sharma K S commented on YARN-5956:
-
As part of this JIRA, we can remove duplicate code which
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712603#comment-15712603
]
Daniel Templeton commented on YARN-5956:
Thanks for the patch, [~lewuathe]! Looks good except that
[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712306#comment-15712306
]
Hadoop QA commented on YARN-5956:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
57 matches
Mail list logo
