[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976943#comment-16976943
]
Hudson commented on YARN-9562:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17659 (See
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975326#comment-16975326
]
Shane Kumpf commented on YARN-9562:
---
I retested without the private tmp mount and moving my YARN local
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975241#comment-16975241
]
Jim Brennan commented on YARN-9562:
---
I'm +1 on patch 015 (non-binding)
> Add Java changes for the new
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975237#comment-16975237
]
Craig Condit commented on YARN-9562:
I'm +1 on this one (non-binding). LGTM.
> Add Java changes for
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974730#comment-16974730
]
Hadoop QA commented on YARN-9562:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974660#comment-16974660
]
Eric Badger commented on YARN-9562:
---
Huh...that's weird. Must've been an issue with the upload. Uploaded
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974650#comment-16974650
]
Jim Brennan commented on YARN-9562:
---
[~ebadger] I don't see a patch 015...
> Add Java changes for the
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973853#comment-16973853
]
Eric Badger commented on YARN-9562:
---
Patch 015 adds a note into the documentation to not mount anything
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973463#comment-16973463
]
Shane Kumpf commented on YARN-9562:
---
Hey Eric, sorry for the delay. Just a note that my patch testing
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971833#comment-16971833
]
Eric Badger commented on YARN-9562:
---
{noformat}
Error while deleting
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971141#comment-16971141
]
Shane Kumpf commented on YARN-9562:
---
Thanks for the new patches, [~ebadger]! I was able to successfully
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970381#comment-16970381
]
Jim Brennan commented on YARN-9562:
---
Thanks for the updates [~ebadger]! I am +1 (non-binding) on patch
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969657#comment-16969657
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969655#comment-16969655
]
Eric Badger commented on YARN-9562:
---
bq. My initial thought would be handling these mounts via the
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969572#comment-16969572
]
Shane Kumpf commented on YARN-9562:
---
Thanks again, Eric! I'll give the latest patches a try.
{quote}
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969547#comment-16969547
]
Eric Badger commented on YARN-9562:
---
Hey [~shaneku...@gmail.com], YARN-9562 Patch 014 combined with
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968539#comment-16968539
]
Shane Kumpf commented on YARN-9562:
---
bq. So you're setting
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968537#comment-16968537
]
Jim Brennan commented on YARN-9562:
---
[~ebadger], [~shaneku...@gmail.com] for the record, I ran with
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968529#comment-16968529
]
Eric Badger commented on YARN-9562:
---
[~shaneku...@gmail.com], thanks for the review!
bq. I am running
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967937#comment-16967937
]
Shane Kumpf commented on YARN-9562:
---
Hey [~ebadger]. Thanks for your (and everyone elses) hard work
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965048#comment-16965048
]
Jim Brennan commented on YARN-9562:
---
Thanks for the updates [~ebadger]! I am +1 (non-binding) on patch
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964430#comment-16964430
]
Hadoop QA commented on YARN-9562:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964370#comment-16964370
]
Eric Badger commented on YARN-9562:
---
Patch 013 adds some more documentation changes. Notably, it adds
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963531#comment-16963531
]
Hadoop QA commented on YARN-9562:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963454#comment-16963454
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963448#comment-16963448
]
Eric Badger commented on YARN-9562:
---
Uploading patch 012 to add some javadoc unstable annotations and
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963332#comment-16963332
]
Eric Badger commented on YARN-9562:
---
I just attached path 011 to address [~Jim_Brennan]'s review
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961562#comment-16961562
]
Eric Yang commented on YARN-9562:
-
[~ebadger] Can we do something to reduce the number of checkstyle
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961150#comment-16961150
]
Jim Brennan commented on YARN-9562:
---
[~ebadger], I pulled YARN-9561, YARN-9562, and YARN-9564 into a
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959326#comment-16959326
]
Hadoop QA commented on YARN-9562:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959235#comment-16959235
]
Eric Badger commented on YARN-9562:
---
Thanks for the review, [~Jim_Brennan]!
I guess patch 010 never got
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959220#comment-16959220
]
Jim Brennan commented on YARN-9562:
---
Comment on patch 009:
Nodemanager.java
* ServiceInit() looks like
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958989#comment-16958989
]
Eric Badger commented on YARN-9562:
---
[~shaneku...@gmail.com], would you mind reviewing this JIRA as well
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956476#comment-16956476
]
Eric Badger commented on YARN-9562:
---
Patch 010 should fix the findbugs.
> Add Java changes for the new
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955035#comment-16955035
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954991#comment-16954991
]
Eric Badger commented on YARN-9562:
---
Patch 009 adds some light documentation and some other
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917374#comment-16917374
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916977#comment-16916977
]
Eric Badger commented on YARN-9562:
---
Patch 008 adds a bunch of checkstyle and findbugs cleanup
> Add
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914870#comment-16914870
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914677#comment-16914677
]
Eric Badger commented on YARN-9562:
---
Thanks for the explanation, [~ccondit]! I've uploaded patch 007,
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914630#comment-16914630
]
Craig Condit commented on YARN-9562:
{quote}I've added patch 005 which adds a new parameterized class
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913942#comment-16913942
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913750#comment-16913750
]
Eric Badger commented on YARN-9562:
---
[~eyang], [~ccondit], I've added patch 005 which adds a new
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910877#comment-16910877
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910847#comment-16910847
]
Eric Yang commented on YARN-9562:
-
[~ebadger] Thank you for patch 005. Cluster can start without the
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910804#comment-16910804
]
Eric Badger commented on YARN-9562:
---
bq. It would be nice, if this is a warning message instead of hard
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910753#comment-16910753
]
Eric Yang commented on YARN-9562:
-
[~ebadger] Node manager can fail to start when configuration defines to
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907566#comment-16907566
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907493#comment-16907493
]
Eric Badger commented on YARN-9562:
---
{noformat:title=Required Configs}
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906663#comment-16906663
]
Eric Yang commented on YARN-9562:
-
[~ebadger]
1. Node manager crashes if the defined
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906452#comment-16906452
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906295#comment-16906295
]
Eric Badger commented on YARN-9562:
---
[~eyang], yes that's the error. I caught this error awhile ago, but
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905667#comment-16905667
]
Eric Yang commented on YARN-9562:
-
[~ebadger] {quote}I'm not quite sure how it's possible that your config
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905630#comment-16905630
]
Eric Badger commented on YARN-9562:
---
{noformat:title=ImageTagToManifestPlugin.java}
Path
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905616#comment-16905616
]
Eric Yang commented on YARN-9562:
-
[~ebadger] The config is written as:
{code}
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905586#comment-16905586
]
Eric Badger commented on YARN-9562:
---
[~eyang], could you post your relevant config settings? It looks
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905561#comment-16905561
]
Eric Yang commented on YARN-9562:
-
By combining YARN-9561, YARN-9562, YARN-9564, I got a few steps further
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898350#comment-16898350
]
Eric Badger commented on YARN-9562:
---
Hey [~eyang], thanks for trying out the patch! Here are what I
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896610#comment-16896610
]
Eric Yang commented on YARN-9562:
-
[~ebadger] I couldn't get very far with patch 002 with YARN-9561 patch
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890273#comment-16890273
]
Eric Yang commented on YARN-9562:
-
[~ebadger] Thank you for the patch. Can we create manifestJson as a
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889279#comment-16889279
]
Hadoop QA commented on YARN-9562:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889243#comment-16889243
]
Eric Yang commented on YARN-9562:
-
{quote}I'm open to changing this. What do you have in mind for
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889228#comment-16889228
]
Eric Badger commented on YARN-9562:
---
Uploading patch 002 with unit tests added.
bq. When it is passing
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889212#comment-16889212
]
Eric Yang commented on YARN-9562:
-
{quote}The idea here was that ContainerRuntimeObject is specific to
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889182#comment-16889182
]
Eric Badger commented on YARN-9562:
---
bq. GetContainerRuntimeData is designed to return an object. When
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888399#comment-16888399
]
Eric Yang commented on YARN-9562:
-
Thank you for the patch [~ebadger].
GetContainerRuntimeData is
[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875283#comment-16875283
]
Eric Badger commented on YARN-9562:
---
Attaching patch 001 as an initial patch to give everyone a sense of
67 matches
Mail list logo
