[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818551#comment-13818551
]
Vinod Kumar Vavilapalli commented on YARN-987:
--
Mostly looks good. One final
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818557#comment-13818557
]
Mayank Bansal commented on YARN-987:
Thanks [~vinodkv] for the review.
We have only
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818606#comment-13818606
]
Vinod Kumar Vavilapalli commented on YARN-987:
--
That's true. I'll try if this
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814743#comment-13814743
]
Mayank Bansal commented on YARN-987:
Thanks [~vinodkv] and [~zjshen] for the review.
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814757#comment-13814757
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815080#comment-13815080
]
Zhijie Shen commented on YARN-987:
--
1. Would you please fix the capitalization?
{code}
+
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815211#comment-13815211
]
Mayank Bansal commented on YARN-987:
bq. 1. Would you please fix the capitalization?
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815228#comment-13815228
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815351#comment-13815351
]
Zhijie Shen commented on YARN-987:
--
No need to do this change, which will break
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815389#comment-13815389
]
Mayank Bansal commented on YARN-987:
Done.
Thanks,
Mayank
Adding History Service to
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815397#comment-13815397
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815417#comment-13815417
]
Zhijie Shen commented on YARN-987:
--
+1
ApplicationHistoryManagerImpl may be changed
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814196#comment-13814196
]
Mayank Bansal commented on YARN-987:
Thanks [~zjshen] for the review.
bq. As we're
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814209#comment-13814209
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814486#comment-13814486
]
Zhijie Shen commented on YARN-987:
--
* The unnecessary type casting is still there.
{code}
+
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813721#comment-13813721
]
Zhijie Shen commented on YARN-987:
--
bq. As we discussed offline, Yes thats similar to JHS
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810557#comment-13810557
]
Mayank Bansal commented on YARN-987:
Thanks [~zjshen] for the review.
bq. Do we really
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810575#comment-13810575
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794329#comment-13794329
]
Zhijie Shen commented on YARN-987:
--
Do we really need ApplicationHistoryContext? I guess it
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771444#comment-13771444
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768832#comment-13768832
]
Hadoop QA commented on YARN-987:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737215#comment-13737215
]
Zhijie Shen commented on YARN-987:
--
It's not guranteed that the implementation of
[
https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732875#comment-13732875
]
Mayank Bansal commented on YARN-987:
I am adding the History service which use of store
23 matches
Mail list logo
