[jira] [Comment Edited] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870044#comment-15870044 ] Varun Saxena edited comment on YARN-6069 at 2/16/17 2:35 PM: - bq. I think folks

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870044#comment-15870044 ] Varun Saxena commented on YARN-6069: bq. I think folks are forgetting one important thing that this

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869957#comment-15869957 ] Varun Saxena commented on YARN-6069: Probably it did not come out clearly in my previous comment. I was

[jira] [Comment Edited] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869957#comment-15869957 ] Varun Saxena edited comment on YARN-6069 at 2/16/17 1:54 PM: - Probably it did

[jira] [Comment Edited] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869865#comment-15869865 ] Varun Saxena edited comment on YARN-6069 at 2/16/17 12:56 PM: -- Now coming to

[jira] [Comment Edited] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869865#comment-15869865 ] Varun Saxena edited comment on YARN-6069 at 2/16/17 12:55 PM: -- Now coming to

[jira] [Comment Edited] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869865#comment-15869865 ] Varun Saxena edited comment on YARN-6069 at 2/16/17 12:54 PM: -- Now coming to

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869865#comment-15869865 ] Varun Saxena commented on YARN-6069: Now coming to the patch, the thing we have to consider is that we

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869864#comment-15869864 ] Varun Saxena commented on YARN-6069: [~sunilg], bq. I am behind such a linear approach and reuse

[jira] [Comment Edited] (YARN-6069) CORS support in timeline v2

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869094#comment-15869094 ] Varun Saxena edited comment on YARN-6069 at 2/16/17 3:53 AM: - As of now for

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869094#comment-15869094 ] Varun Saxena commented on YARN-6069: As of now for timeline service, we use the timeline specific

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869084#comment-15869084 ] Varun Saxena commented on YARN-6069: bq. I think you are missing one key thing is PREFIX is different

[jira] [Commented] (YARN-6069) CORS support in timeline v2

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868628#comment-15868628 ] Varun Saxena commented on YARN-6069: Thanks [~rohithsharma] for the patch. # I think we can move

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868601#comment-15868601 ] Varun Saxena commented on YARN-4675: Javadoc failure looks weird. Wasn't there in the last build

[jira] [Comment Edited] (YARN-6201) Add node label as a query param for nodes REST end point

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868422#comment-15868422 ] Varun Saxena edited comment on YARN-6201 at 2/15/17 7:24 PM: - [~sunilg], this

[jira] [Commented] (YARN-6201) Add node label as a query param for nodes REST end point

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868422#comment-15868422 ] Varun Saxena commented on YARN-6201: [~sunilg], this is for WebUI ? > Add node label as a query param

[jira] [Commented] (YARN-6198) getAMRMToken for application with unmanaged AM fail in secure mode

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867723#comment-15867723 ] Varun Saxena commented on YARN-6198: Bibin, as you pointed out, we need to do a short username fix in

[jira] [Comment Edited] (YARN-2892) Unable to get AMRMToken in unmanaged AM when using a secure cluster

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867718#comment-15867718 ] Varun Saxena edited comment on YARN-2892 at 2/15/17 12:14 PM: -- What happened

[jira] [Commented] (YARN-2892) Unable to get AMRMToken in unmanaged AM when using a secure cluster

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867718#comment-15867718 ] Varun Saxena commented on YARN-2892: What happened to this fix? Maybe someone can rebase and we can get

[jira] [Commented] (YARN-6197) CS Leaf queue am usage gets updated for unmanaged AM

2017-02-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867667#comment-15867667 ] Varun Saxena commented on YARN-6197: Thanks [~bibinchundatt] for raising the JIRA. Agree with you

[jira] [Comment Edited] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867376#comment-15867376 ] Varun Saxena edited comment on YARN-6156 at 2/15/17 7:29 AM: - For unmanaged AM

[jira] [Updated] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Description: As per the current implementation for AM blacklisting, disabling is based on complete

[jira] [Updated] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Description: As per the current implementation for AM blacklisting, disabling is based on complete

[jira] [Updated] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Description: As per the current implementation for AM blacklisting, disabling is based on complete

[jira] [Commented] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867376#comment-15867376 ] Varun Saxena commented on YARN-6156: For unmanaged AM as AM blacklisting is not done, it is equivalent

[jira] [Updated] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Summary: AM blacklisting to consider node label partition (was: AM blacklisting consider node label

[jira] [Updated] (YARN-6156) AM blacklisting to consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Description: As per the current implementation for AM blacklisting, disabling is based on complete

[jira] [Updated] (YARN-6156) AM blacklisting consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Description: As per the current implementation for AM blacklisting, disabling is based on complete

[jira] [Commented] (YARN-6156) AM blacklisting consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867355#comment-15867355 ] Varun Saxena commented on YARN-6156: Thanks [~sunilg]. Will drop a comment and update the description.

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867294#comment-15867294 ] Varun Saxena commented on YARN-6148: Yes, that's the plan. > NM node count reported to AM in Allocate

[jira] [Commented] (YARN-6156) AM blacklisting consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867243#comment-15867243 ] Varun Saxena commented on YARN-6156: By the way for unmanaged AM, am resource request will be null and

[jira] [Commented] (YARN-6156) AM blacklisting consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867203#comment-15867203 ] Varun Saxena commented on YARN-6156: Thanks [~bibinchundatt]. Yeah it is not necessary to invoke simple

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866595#comment-15866595 ] Varun Saxena commented on YARN-4675: [~Naganarasimha], there is a small conflict in the patch. But I

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866481#comment-15866481 ] Varun Saxena commented on YARN-6148: bq. IIUC we don't track label of nodes in AM side of MR We get map

[jira] [Commented] (YARN-6156) AM blacklisting consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866495#comment-15866495 ] Varun Saxena commented on YARN-6156: Thanks [~bibinchundatt] +1. Will commit it later today. > AM

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866475#comment-15866475 ] Varun Saxena commented on YARN-6148: [~leftnoteasy], only concern was whether we add a new field in

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865986#comment-15865986 ] Varun Saxena commented on YARN-6148: I fully understand the use case you are pointing out. Yes, the

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865941#comment-15865941 ] Varun Saxena commented on YARN-6027: [~rohithsharma], we can probably pass encoded ID in info field

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865883#comment-15865883 ] Varun Saxena commented on YARN-6027: bq. define new character set for separator. No matter what we

[jira] [Commented] (YARN-6156) AM blacklisting consider node label partition

2017-02-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865578#comment-15865578 ] Varun Saxena commented on YARN-6156: [~bibinchundatt], checkstyle issues seem fixable. Can you fix

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865157#comment-15865157 ] Varun Saxena commented on YARN-6148: Agree... As I said above, I am not against whatever Sunil

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865001#comment-15865001 ] Varun Saxena commented on YARN-6156: [~bibinchundatt], we need not initialize amNodeLabelExpression to

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864967#comment-15864967 ] Varun Saxena commented on YARN-6148: By the way I need to make a check for node labels enabled in the

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864966#comment-15864966 ] Varun Saxena commented on YARN-6148: Or probably this improvement can be done as part of YARN-4902 >

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864961#comment-15864961 ] Varun Saxena commented on YARN-6156: Thanks [~sunilg] for sharing the relevant piece of code. > AM

[jira] [Updated] (YARN-6159) Documentation changes for TimelineV2Client

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6159: --- Description: Make documentation changes for TimelineV2Client i.e. to reflect changes made in client

[jira] [Updated] (YARN-6159) Documentation changes for TimelineV2Client

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6159: --- Summary: Documentation changes for TimelineV2Client (was: Make documentation changes for

[jira] [Updated] (YARN-6159) Make documentation changes for TimelineV2Client

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6159: --- Summary: Make documentation changes for TimelineV2Client (was: In timeline v2 documentation, the code

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864478#comment-15864478 ] Varun Saxena commented on YARN-4675: Linking YARN-6159, as documentation related changes corresponding

[jira] [Commented] (YARN-6159) In timeline v2 documentation, the code snippet given for creating timeline client has a mistake

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864475#comment-15864475 ] Varun Saxena commented on YARN-6159: Sorry this would require more changes as we need to reflect

[jira] [Commented] (YARN-6159) In timeline v2 documentation, the code snippet given for creating timeline client has a mistake

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864469#comment-15864469 ] Varun Saxena commented on YARN-6159: Changes look fine. Will commit this after YARN-4675. > In

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864464#comment-15864464 ] Varun Saxena commented on YARN-4675: Thanks Naga for the patch! A few more minor comments in addition

[jira] [Updated] (YARN-6159) In timeline v2 documentation, the code snippet given for creating timeline client has a mistake

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6159: --- Priority: Minor (was: Trivial) > In timeline v2 documentation, the code snippet given for creating

[jira] [Comment Edited] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864389#comment-15864389 ] Varun Saxena edited comment on YARN-6027 at 2/13/17 8:49 PM: - Thanks

[jira] [Comment Edited] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864389#comment-15864389 ] Varun Saxena edited comment on YARN-6027 at 2/13/17 8:46 PM: - Thanks

[jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864389#comment-15864389 ] Varun Saxena commented on YARN-6027: Thanks [~rohithsharma] for the patch. Few comments. # I think we

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864277#comment-15864277 ] Varun Saxena commented on YARN-6148: [~sunilg] I do see your point here. But as Naga mentioned our

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864196#comment-15864196 ] Varun Saxena commented on YARN-6156: Do we have an explicit check for not sharing for AM containers?

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863305#comment-15863305 ] Varun Saxena commented on YARN-6156: [~bibinchundatt], actually my first comment was about not using

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863324#comment-15863324 ] Varun Saxena commented on YARN-6156: [~sunilg], But in case of AM container, this i.e. adding a node if

[jira] [Comment Edited] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863485#comment-15863485 ] Varun Saxena edited comment on YARN-6156 at 2/13/17 12:08 PM: -- bq. And again

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863314#comment-15863314 ] Varun Saxena commented on YARN-6156: bq. I agree that non-exclusive nodes are bounded by available

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863310#comment-15863310 ] Varun Saxena commented on YARN-6156: Bibin, sorry ignore my previous comment. I checked the incorrect

[jira] [Comment Edited] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863485#comment-15863485 ] Varun Saxena edited comment on YARN-6156 at 2/13/17 12:10 PM: -- bq. And again

[jira] [Comment Edited] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863485#comment-15863485 ] Varun Saxena edited comment on YARN-6156 at 2/13/17 12:08 PM: -- bq. And again

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863485#comment-15863485 ] Varun Saxena commented on YARN-6156: bq. And again AM container is allocated in another non-exclusive

[jira] [Issue Comment Deleted] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Comment: was deleted (was: [~bibinchundatt], actually my first comment was about not using

[jira] [Issue Comment Deleted] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Comment: was deleted (was: Bibin, sorry ignore my previous comment. I checked the incorrect patch.) >

[jira] [Commented] (YARN-6178) RM recovery failure on node label mirror load

2017-02-12 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862952#comment-15862952 ] Varun Saxena commented on YARN-6178: We can make that check for robustness but my concern was that what

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-12 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862950#comment-15862950 ] Varun Saxena commented on YARN-6156: Thanks Bibin for the patch. Few comments. #

[jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-11 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862411#comment-15862411 ] Varun Saxena commented on YARN-4675: I was thinking trunk but should not matter if we drop onto trunk

[jira] [Commented] (YARN-6178) RM recovery failure on node label mirror load

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862294#comment-15862294 ] Varun Saxena commented on YARN-6178: Why was the size of nodelabel.mirror file, 0? There must be

[jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861975#comment-15861975 ] Varun Saxena commented on YARN-6170: Changes look fine to me. Will commit it by tomorrow. >

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861842#comment-15861842 ] Varun Saxena commented on YARN-6148: Checkstyle cant be fixed and test failure is unrelated. Passes

[jira] [Created] (YARN-6172) TestFSAppStarvation fails on trunk

2017-02-10 Thread Varun Saxena (JIRA)
Varun Saxena created YARN-6172: -- Summary: TestFSAppStarvation fails on trunk Key: YARN-6172 URL: https://issues.apache.org/jira/browse/YARN-6172 Project: Hadoop YARN Issue Type: Bug

[jira] [Updated] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6148: --- Attachment: YARN-6148.01.patch > NM node count reported to AM in Allocate Response should consider

[jira] [Updated] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6148: --- Attachment: (was: YARN-6148.01.patch) > NM node count reported to AM in Allocate Response should

[jira] [Updated] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6148: --- Attachment: YARN-6148.01.patch > NM node count reported to AM in Allocate Response should consider

[jira] [Commented] (YARN-6056) Yarn NM using LCE shows a failure when trying to delete a non-existing dir

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861337#comment-15861337 ] Varun Saxena commented on YARN-6056: Committed to branch-2.6 Thanks [~wilfreds] for your contribution.

[jira] [Comment Edited] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861057#comment-15861057 ] Varun Saxena edited comment on YARN-6170 at 2/10/17 10:31 AM: -- Thanks

[jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861057#comment-15861057 ] Varun Saxena commented on YARN-6170: Thanks [~sjlee0] for raising the issue. I remember Zhijie raising

[jira] [Commented] (YARN-6156) AM blacklistdisableThreshold consider node partition count

2017-02-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861008#comment-15861008 ] Varun Saxena commented on YARN-6156: bq. Since non-exclusive resource are not a guaranteed resources

[jira] [Commented] (YARN-6027) Improve /flows API for more flexible filters fromid, collapse, userid

2017-02-09 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859344#comment-15859344 ] Varun Saxena commented on YARN-6027: Ok...I had forgotton that we currently do not limit flow runs

[jira] [Commented] (YARN-6157) Inconsistencies in verifying Max Applications

2017-02-09 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859205#comment-15859205 ] Varun Saxena commented on YARN-6157: [~Naganarasimha], the check for system max apps is made in

[jira] [Commented] (YARN-6056) Yarn NM using LCE shows a failure when trying to delete a non-existing dir

2017-02-08 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858379#comment-15858379 ] Varun Saxena commented on YARN-6056: Sorry I had missed this one. Will commit it by tomorrow. > Yarn

[jira] [Commented] (YARN-6130) [Security] Generate a delegation token for AM when app collector is created and pass it to AM via NM and RM

2017-02-08 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858276#comment-15858276 ] Varun Saxena commented on YARN-6130: I have broken compatibility here in AllocateResponse if ATSv2 is

[jira] [Updated] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

2017-02-08 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-4675: --- Summary: Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2

[jira] [Commented] (YARN-4675) Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl

2017-02-08 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858001#comment-15858001 ] Varun Saxena commented on YARN-4675: Thanks [~Naganarasimha] for the patch. Looks pretty close. Few

[jira] [Created] (YARN-6159) In timeline v2 documentation, the code snippet given for creating timeline client has a mistake

2017-02-08 Thread Varun Saxena (JIRA)
Varun Saxena created YARN-6159: -- Summary: In timeline v2 documentation, the code snippet given for creating timeline client has a mistake Key: YARN-6159 URL: https://issues.apache.org/jira/browse/YARN-6159

[jira] [Commented] (YARN-6027) Improve /flows API for more flexible filters fromid, collapse, userid

2017-02-08 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857803#comment-15857803 ] Varun Saxena commented on YARN-6027: bq. But it is expected to collapse with date range Ok, then its

[jira] [Commented] (YARN-6027) Improve /flows API for more flexible filters fromid, collapse, userid

2017-02-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856413#comment-15856413 ] Varun Saxena commented on YARN-6027: Thanks [~rohithsharma] for the patch. Few high level comments.

[jira] [Commented] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855816#comment-15855816 ] Varun Saxena commented on YARN-6148: Yes the intention is to make behavior consistent. The nodes

[jira] [Commented] (YARN-6130) [Security] Generate a delegation token for AM when app collector is created and pass it to AM via NM and RM

2017-02-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855715#comment-15855715 ] Varun Saxena commented on YARN-6130: Patch attached is on top of YARN-5647 and YARN-5648 > [Security]

[jira] [Updated] (YARN-6130) [Security] Generate a delegation token for AM when app collector is created and pass it to AM via NM and RM

2017-02-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6130: --- Attachment: YARN-6130-YARN-5355.01.patch > [Security] Generate a delegation token for AM when app

[jira] [Commented] (YARN-3884) RMContainerImpl transition from RESERVED to KILL apphistory status not updated

2017-02-06 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854438#comment-15854438 ] Varun Saxena commented on YARN-3884: Thanks Bibin for the patch. Will review and commit by tomorrow. >

[jira] [Created] (YARN-6149) Allow port range to be specified while starting NM Timeline collector manager.

2017-02-06 Thread Varun Saxena (JIRA)
Varun Saxena created YARN-6149: -- Summary: Allow port range to be specified while starting NM Timeline collector manager. Key: YARN-6149 URL: https://issues.apache.org/jira/browse/YARN-6149 Project:

[jira] [Moved] (YARN-6148) NM node count reported to AM in Allocate Response should consider requested node label partitions.

2017-02-06 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena moved MAPREDUCE-6843 to YARN-6148: --- Key: YARN-6148 (was: MAPREDUCE-6843) Project: Hadoop YARN

[jira] [Commented] (YARN-6147) Blacklisting nodes not happening for AM containers

2017-02-06 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853707#comment-15853707 ] Varun Saxena commented on YARN-6147: This happens when NM is down but RM hasn't yet found out that it

[jira] [Commented] (YARN-5648) [Security] Client side changes for authentication

2017-02-04 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852950#comment-15852950 ] Varun Saxena commented on YARN-5648: Rebased the patch. On top of YARN-5647 > [Security] Client side

[jira] [Updated] (YARN-5648) [Security] Client side changes for authentication

2017-02-04 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-5648: --- Attachment: YARN-5648-YARN-5355.02.patch > [Security] Client side changes for authentication >

<    5   6   7   8   9   10   11   12   13   14   >