[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369792#comment-15369792 ] Hudson commented on YARN-3814: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10074/]) YARN-3814. REST API implementation for getting raw entities in (sjlee: rev 451c13b1de1e42394a4c92888192da9a9519d9ac) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/FileSystemTimelineReaderImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderWebServices.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderServer.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServices.java > REST API implementation for getting raw entities in TimelineReader > -- > > Key: YARN-3814 > URL: https://issues.apache.org/jira/browse/YARN-3814 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: YARN-2928 > > Attachments: YARN-3814-YARN-2928.01.patch, > YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, > YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, > YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706562#comment-14706562 ] Varun Saxena commented on YARN-3814: [~sjlee0], [~djp], any more comments ? REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706966#comment-14706966 ] Junping Du commented on YARN-3814: -- Thanks [~varun_saxena] for your patient. I am still reviewing it and will give my comments before the end of today. Thanks! REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707083#comment-14707083 ] Sangjin Lee commented on YARN-3814: --- The latest patch (v.6) LGTM. I'll wait for [~djp]'s feedback. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707632#comment-14707632 ] Junping Du commented on YARN-3814: -- The patch LGTM too. [~sjlee0], please feel free to go ahead to commit it. Thx! REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701866#comment-14701866
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 19m 27s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 9m 31s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 12m 16s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 29s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 16s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 16s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 47s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 50s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 55s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 2m 50s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 49m 45s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12751064/YARN-3814-YARN-2928.05.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / 9a82008 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8877/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8877/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8877/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch,
YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701893#comment-14701893
]
Li Lu commented on YARN-3814:
-
Hi [~varun_saxena], thanks for the patch! I think the patch is mostly good,
only with a few nits:
- In TimelineReaderManager
- Configuration and YarnConfiguration appears to be unused.
- callerUGI is not used and not documented. What's our plan on that? How to
set caller UGI for now?
- In TimelineReaderWebServices,
- Can we have two constants for default delimiters? Right now we're spreading
them in the source code like:
{code}
parseKeyStrValuesStr(relatesTo, ,, :),
parseKeyStrValuesStr(isRelatedTo, ,, :),
parseKeyStrValueObj(infofilters, ,, :),
parseKeyStrValueStr(conffilters, ,, :),
parseValuesStr(metricfilters, ,), parseValuesStr(eventfilters, ,),
parseFieldsStr(fields, ,), callerUGI);
{code}
Similar problem also happens on line 280 after patch.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch,
YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702370#comment-14702370 ] Varun Saxena commented on YARN-3814: Yes, we wont use it as of now. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702306#comment-14702306 ] Varun Saxena commented on YARN-3814: As now I have removed it, we can add it later when we do ACLs'. Is that fine ? REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702346#comment-14702346 ] Li Lu commented on YARN-3814: - OK... If we're sure we will not use that method else where, that LGTM. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702426#comment-14702426
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 16m 34s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 10s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 55s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 16s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 14s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 35s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 40m 20s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12751178/YARN-3814-YARN-2928.06.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / 9a82008 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8882/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8882/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8882/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch,
YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702253#comment-14702253 ] Varun Saxena commented on YARN-3814: bq.Can we have two constants for default delimiters? Ok. bq. callerUGI is not used and not documented. What's our plan on that? How to set caller UGI for now? callerUGI will be used for applying ACLs'. It is currently set in TimelineReaderWebServices. Can be removed for now. bq. Configuration and YarnConfiguration appears to be unused. Will remove the imports. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702266#comment-14702266 ] Li Lu commented on YARN-3814: - bq. callerUGI will be used for applying ACLs'. It is currently set in TimelineReaderWebServices. Can be removed for now. Yes I know it's used for applying ACLs. We do have plan to support security in (possible near) future, and by then the UGI info will become useful. That's actually why I'm not suggesting remove it but instead document our current intentions on it. So I'd incline to not to remove it for now, but to make it clear about our current assumptions/requirements on it. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch, YARN-3814-YARN-2928.06.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700236#comment-14700236 ] Sangjin Lee commented on YARN-3814: --- I have no other comments. Thanks! REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693626#comment-14693626 ] Varun Saxena commented on YARN-3814: Others have any comments ? Will update a patch after that. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681312#comment-14681312 ] Li Lu commented on YARN-3814: - Thank [~varun_saxena]! bq. So if GenericObjectMapper cannot convert the value and throws an Exception, we merely forward whatever came in the request. Hope I am not misunderstanding your comment. OK that's fine. Actually originally I meant parseKeyStrValuesStr and parseKeyStrValueStr, but not parseKeyStrValueObj, but never mind. bq. Ok. Will move these helper functions to another file. Actually my key point here is not about separating the file, but to maximize code reuse for those parse methods. Part of parseKeyStrValuesStr and parseKeyValue are quite similar. If we can reuse most of the code in parseKeyValue and not mixing it in the middle of a sequence of parse helper methods, I'm totally fine with keeping them in the same file. bq. Would a code comment be fine ? Sure, but it's certainly not harmful to generate one more log, especially when FS storage implementation is for debug only? It's up to you though. :) REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681288#comment-14681288 ] Varun Saxena commented on YARN-3814: [~gtCarrera9], bq. Why we're not using if statement but using exception handling to decide the type of pairStrs[1]? I think we can pretty much restrict the type of pairStrs[1] here, so maybe instanceof will do the work? We are not using exception handling to determine the type. readValue can throw an Exception which has been caught here. So if GenericObjectMapper cannot convert the value and throws an Exception, we merely forward whatever came in the request. Hope I am not misunderstanding your comment. bq. We may further want to move those parse methods into a helper method collection file? Ok. Will move these helper functions to another file. bq. Change its name into newEntity or initEntity? Hmm...Well this function entity is used as a shorthand for creating entity and used during assertion. Maybe name it as newEntity. bq. But still we need some rationales in the code as comment for why we can swallow the exception. It will be also helpful if we output something about the 404? I think it will be quite hard to debug if we hit an exception which cause a null return value and then a 404. Would a code comment be fine ? bq. String msg = new String(); instead of using immediate value Ok. bq. We don't really need a separate JIRA for each set of RESTful APIs since this part is relatively trivial. I agree. Even I meant to do it in a single JIRA. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680396#comment-14680396 ] Li Lu commented on YARN-3814: - HI [~varun_saxena], any updates on this JIRA? Thanks! REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680670#comment-14680670 ] Varun Saxena commented on YARN-3814: Thanks for the review [~gtCarrera9]. Sorry hadn't looked at the reference patch. bq. Also, it looks a little bit awkward to return a set of entities if we use an endpoint called entity (and vice versa). Hmm...makes sense. Lets make it entity and entities then. That is semantically correct. Lets get opinion of others as well because this will be user facing API. bq. are there any special reasons we cannot adopt the way in the reference patch to parse the enum set? Will change it. bq. parseKeyStrValuesStr and parseKeyStrValueStr look pretty similar. Ok. Will make the change. May have to use generics here as maps are of different types. bq. Since we already have aggregation related designs in the reference patch, I suggest we include it in the final version of this patch. We have a JIRA for aggregation implementation for reader side. As we do not have parts of aggregation write path and we havent discussed timeline reader API for it, I think we can do it in the aggregation related JIRA. Because we were initially thinking of having different REST endpoints for different levels of aggregations. Thoughts ? bq. FileSystemTimelineReaderImpl, why we need to swallow FileNotFoundExceptions? The intention here is that if user queries for an entity which does not exist, the entity file would not exist. FileNotFoundException has been swallowed to return null which will then be converted to HTTP 404 in TimelineReaderWebServices. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680833#comment-14680833
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 45s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 9s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 9s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 16s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 14s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 40s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 37s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 39m 39s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12749677/YARN-3814-YARN-2928.04.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / 07433c2 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8817/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8817/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8817/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680778#comment-14680778 ] Li Lu commented on YARN-3814: - bq. We have a JIRA for aggregation implementation for reader side. As we do not have parts of aggregation write path and we havent discussed timeline reader API for it, I think we can do it in the aggregation related JIRA. Because we were initially thinking of having different REST endpoints for different levels of aggregations. Thoughts ? That's reasonable. Yes let's not fixing it here. However, my feeling is it will be way too many fragments if we address the aggregation REST APIs separately. Maybe we can add the RESTful endpoints when we add our aggregation readers? This will speed up the whole process of reviewing and committing. We don't really need a separate JIRA for each set of RESTful APIs since this part is relatively trivial. bq. The intention here is that if user queries for an entity which does not exist, the entity file would not exist. FileNotFoundException has been swallowed to return null which will then be converted to HTTP 404 in TimelineReaderWebServices. OK, but still we need some rationales in the code as comment for why we can swallow the exception. It will be also helpful if we output something about the 404? I think it will be quite hard to debug if we hit an exception which cause a null return value and then a 404. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681029#comment-14681029
]
Li Lu commented on YARN-3814:
-
Hi [~varun_saxena], thanks for the work. I've gone through the latest patch and
in general it's quite close. Some of my follow up comments:
In TimelineReaderWebServices:
{code}
+try {
+ Object value =
+ GenericObjectMapper.OBJECT_READER.readValue(pairStrs[1].trim());
+ map.put(pairStrs[0].trim(), (T) value);
+} catch (IOException e) {
+ map.put(pairStrs[0].trim(), (T) pairStrs[1].trim());
+}
{code}
Why we're not using if statement but using exception handling to decide the
type of pairStrs[1]? I think we can pretty much restrict the type of
pairStrs[1] here, so maybe instanceof will do the work?
I suggest move parseKeyValue to somewhere else so that we can put all user
facing parse methods together. Meanwhile, are there any hopes to let
parseKeyStrValuesStr reuse parseKeyValue? The code looks pretty similar and we
can probably reuse parseKeyValue as well. We may further want to move those
parse methods into a helper method collection file?
In TestTimelineReaderWebServices:
private static TimelineEntity entity(String type, String id)
Change its name into newEntity or initEntity?
l.125 String msg = new String(); instead of using immediate value?
It's great that in this patch there are sufficient unit test cases. This is
awesome. However, we need to be careful with the long URLs with fixed
delimiters.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814-YARN-2928.04.patch, YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662672#comment-14662672
]
Li Lu commented on YARN-3814:
-
Thanks [~varun_saxena] for working on this JIRA! I looked at the latest patch
and the reference patch, and here are some of my comments (I may post something
new later).
# With regard to the endpoint, I'm not quite familiar with the background, but
is there a strong reason for us to _not_ to distinguish entity and entities? I
think it is helpful if the user can clearly expect whether it's a single entity
or a set of entities to be returned from a call (even if the set may contain 0
or 1 entities)? Also, it looks a little bit awkward to return a set of entities
if we use an endpoint called entity (and vice versa).
# Since we already have aggregation related designs in the reference patch, I
suggest we include it in the final version of this patch. Although we may add
more details to this call in the future, I believe it will be quite helpful to
include the code skeleton.
# {{private static EnumSetField parseFieldsStr(String str, String
delimiter)}}, are there any special reasons we cannot adopt the way in the
reference patch to parse the enum set?
# {{FileSystemTimelineReaderImpl}}, why we need to swallow
FileNotFoundExceptions? Given this implementation is mainly for unit tests I
think we need to be extremely cautious on dealing with these exceptions. A
FileNotFoundException may indicate we have some problems in other parts of our
code.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662678#comment-14662678
]
Li Lu commented on YARN-3814:
-
Oh and one more thing, {{parseKeyStrValuesStr}} and {{parseKeyStrValueStr}}
look pretty similar. If we do not want to apply different logic as the
reference patch, maybe we can refactor it so that they have less duplications?
Thanks!
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650295#comment-14650295
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 18m 10s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 3s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 4s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 16s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 15s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 26s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 50s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 41s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 41m 56s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12748305/YARN-3814-YARN-2928.03.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / df0ec47 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8750/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8750/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8750/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650270#comment-14650270 ] Varun Saxena commented on YARN-3814: [~zjshen], [~sjlee0] updated patch as per Zhijie's comment. Cluster ID will now be part of path. Client side handling for cluster id to be done as part of same JIRA ? REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650243#comment-14650243 ] Varun Saxena commented on YARN-3814: [~zjshen], ok...Lets have it on the client side then. Or we can have 2 separate REST endpoints, with and without cluster ID. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch, YARN-3814.reference.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647023#comment-14647023
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12747894/YARN-3814.reference.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ddc867ce |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8712/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch, YARN-3814.reference.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643059#comment-14643059 ] Sangjin Lee commented on YARN-3814: --- Agreed. It would be client's responsibility to encode them correctly. Also, the server (e.g. jetty) may decode them properly so that the hadoop code may not be concerned about this. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch, YARN-3814-YARN-2928.02.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637233#comment-14637233
]
Varun Saxena commented on YARN-3814:
[~zjshen], [~sjlee0], have uploaded a patch.
Have consolidated functionally REST API part implemented in YARN-3049 and this
JIRA.
Couple of points I have taken from YARN-3049. Those being :
# User ID is taken from request if not supplied.
# Used following format for expressing relations in query. There was a bug in
YARN-3049 for it. Handling it properly in this JIRA.
{noformat}
[type1]:[id1]:[id2]:[id3], [type2]:[id4]:[id5]
{noformat}
Others are still same as previous patch.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637334#comment-14637334
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 17m 3s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 40s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 18s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 18s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 41s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 35s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 41m 56s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12746583/YARN-3814-YARN-2928.02.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / eb1932d |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8616/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8616/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8616/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637305#comment-14637305
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 23s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 53s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 52s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 15s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 18s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 28s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 40s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 48s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 36s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 38m 42s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12746581/YARN-3814-YARN-2928.02.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / eb1932d |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8615/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8615/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8615/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch,
YARN-3814-YARN-2928.02.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635181#comment-14635181 ] Varun Saxena commented on YARN-3814: bq. For example, characters such as : are reserved characters in URL that are not directly allowed in queries or other parts of the URL. They should always be properly encoded (e.g. %3A). [~sjlee0], I think this tends to depend on whether the class used to construct URL at client is RFC-2396 compliant or not. I am for instance in my unit tests able to send both : and %3A. And both are interpreted as : at server side. We anyways were using : even in ATSv1 so behavior would be same for current users. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633690#comment-14633690
]
Varun Saxena commented on YARN-3814:
[~zjshen], [~sjlee0] had a look at YARN-3049.
The REST API part is quite similar except minor differences. Those being :
# Cluster ID is mandatory in YARN-3049 whereas in this patch its optional. Will
be taken from config if not supplied.
# If flowId or any other long value in query is not a numeric value, YARN-3049
will send Internal Server Error. This patch will reply with Bad Request error.
# User ID is taken from request if not supplied in YARN-3049. Here, we do not
handle this case.
# relatesTo and isRelatedTo is given in query in YARN-3049 in format
{noformat}
[type1]:[id1]:[id2]:[id3], [type2]:[id4]:[id5]
{noformat}
In this patch, format is as under :
{noformat}
[type1]:[id1];[id2];[id3], [type2]:[id4];[id5]
{noformat}
So we can decide on these points of difference and consolidate this code.
I have added 19 test cases in this patch as well.
Maybe REST API code can be consolidate in this JIRA with HBase implementation
in YARN-3049.
Thoughts ?
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634128#comment-14634128 ] Sangjin Lee commented on YARN-3814: --- bq. 1. Cluster ID is mandatory in YARN-3049 whereas in this patch its optional. Will be taken from config if not supplied. Agreed. The default use case of the reader is it serves data that belongs to its own cluster. If the cluster is not specified in the query, it should simply assume the current cluster. In terms of the general query pattern, I'd just like to make sure we follow the correct URL query syntax. For example, characters such as : are reserved characters in URL that are not directly allowed in queries or other parts of the URL. They should always be properly encoded (e.g. %3A). Just to be sure. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628567#comment-14628567
]
Varun Saxena commented on YARN-3814:
REST URL for fetching a single entity by entity ID has been kept as under:
{noformat}
http://{ip}:{port}/ws/v2/timeline/entity/{appId}/{entityType}/{entityId}?[Query
Parameters]
{noformat}
REST URL for fetching a multiple entities has been kept as under:
{noformat}
http://{ip}:{port}/ws/v2/timeline/entity/{appId}/{entityType}?[Query Parameters]
{noformat}
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628582#comment-14628582 ] Varun Saxena commented on YARN-3814: +*For Get Entity API,*+ appId, entityType and entityId are mandatory parameters for querying a single entity hence they are kept as part of path in REST URL. Optional query Parameters for get entity API have been kept as *clusterId, userId, flowId, flowRunId and fields.* *clusterId* and appId are mandatory for getting an entity. But clusterId can be kept as an optional query parameter because if clusterId is not specified, we can take it from configuration. *userId, flowId and flowRunId* as params are to ensure that we need not query app to flow mapping table. *fields* are a comma separated list of possible fields which have to be returned in addition to default view of entity. Default view of an entity contains entity ID, entity type, created time and modified time. Possible fields are *EVENTS, INFO, METRICS, CONFIGS, RELATESTO and ISRELATEDTO* (case insensitive). If fields is *ALL*, all the above fields are returned. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628623#comment-14628623
]
Varun Saxena commented on YARN-3814:
+*For Get Entities API,*+
appId and entityType are mandatory parameters for querying multiple entities
hence they are kept as part of path in REST URL.
Optional query Parameters for get entity API have been kept as *clusterId,
userId, flowId, flowRunId, limit, createdTimeStart, createdTimeEnd,
modifiedTimeStart, modifiedTimeEnd, relatesTo, isRelatedTo, infofilters,
conffilters, metricfilters, eventfilters and fields.*
Behavior of userId, flowId, flowRunId, fields and clusterId is same as it is
for get entity API.
*createdTimeStart and createdTimeEnd* specifies the time window in which
created time for entity should fall for it to be returned. This specifies
seconds since epoch and is represented as a long internally. Either start or
end can be specified.
*modifiedTimeStart and modifiedTimeEnd* specifies the time window in which
modified time for entity should fall for it to be returned. This specifies
seconds since epoch and is represented as a long internally.
*limit* specifies how many entities have to be returned in response. If number
of entities is more than the limit, most recent entities are returned i.e.
sorted descendingly by created time.
*relatesTo and isRelatedTo* directy map to these fields in TimelineEntity.
These are specified as a comma separated list. With type to IDs' given in the
form :
{noformat}
[type]:[id1];[id2];[id3]
For instance,
relatesTo=type1:id1;id2,type2:id1
This means the entity returned should match with relatesTo field having id1 and
id2 of type1 id1 of type2.
{noformat}
*infoFilters and configFilters* specifies the configs or info (with their
values) which should match with entities to be returned. They are in the form
of key value pair. Value part of config filters is deciphered as a String. For
info filters, no such restriction exists. Key value pairs are specified as
under :
{noformat}
[key]:[value]
So, infofilters=info1:val1,info2:val2 means entities which have info1 with val1
and info2 with val2 should be returned.
{noformat}
*metricFilters and eventFilters* are both a comma separated list of metric IDs'
and events which should match.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628625#comment-14628625 ] Varun Saxena commented on YARN-3814: Deleted and updated a new patch as some debug statements were left over in previous patch REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628633#comment-14628633
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 16m 15s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 47s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 44s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 15s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 16s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 25s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 39s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 50s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 34s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 41m 15s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12745499/YARN-3814-YARN-2928.01.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / eb1932d |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8549/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8549/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8549/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628713#comment-14628713 ] Li Lu commented on YARN-3814: - Oops sorry I was replying a wrong message... REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628711#comment-14628711 ] Li Lu commented on YARN-3814: - OK, thanks [~zjshen]! REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628675#comment-14628675
]
Hadoop QA commented on YARN-3814:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 18m 31s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 10m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 12m 18s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 26s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 21s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 18s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 2m 1s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 58s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 10s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 2m 2s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 48m 39s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12745505/YARN-3814-YARN-2928.01.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / eb1932d |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8550/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8550/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8550/console |
This message was automatically generated.
REST API implementation for getting raw entities in TimelineReader
--
Key: YARN-3814
URL: https://issues.apache.org/jira/browse/YARN-3814
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Affects Versions: YARN-2928
Reporter: Varun Saxena
Assignee: Varun Saxena
Attachments: YARN-3814-YARN-2928.01.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628647#comment-14628647 ] Zhijie Shen commented on YARN-3814: --- [~varun_saxena], thanks for putting the patch. It seems that we have duplicate some work (I'm working on a POC for reader (YARN-3049) which contains some REST API hook too). I'll upload a POC patch a bit latter. Let's consolidate them. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628680#comment-14628680 ] Varun Saxena commented on YARN-3814: [~zjshen], did not know about that. Thought YARN-3049 was about HBase backend implementation. We can surely consolidate both. Let's have REST implementation in this JIRA. And HBase implementation in YARN-3049. Thoughts ? Moreover, parallely I am working on YARN-3862 and YARN-3863. Not sure if there is any overlap there. REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3814) REST API implementation for getting raw entities in TimelineReader
[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628708#comment-14628708 ] Zhijie Shen commented on YARN-3814: --- I didn't go beyond the current reader interface. You're safe:-) REST API implementation for getting raw entities in TimelineReader -- Key: YARN-3814 URL: https://issues.apache.org/jira/browse/YARN-3814 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Affects Versions: YARN-2928 Reporter: Varun Saxena Assignee: Varun Saxena Attachments: YARN-3814-YARN-2928.01.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
