[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266385#comment-17266385 ] Wangda Tan commented on YARN-10506: --- Verified the test failure is an intermittent one which is not

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266384#comment-17266384 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266315#comment-17266315 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266292#comment-17266292 ] Wangda Tan commented on YARN-10506: --- Thanks for the additional comments, I +1 to the latest patch, if

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266265#comment-17266265 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266181#comment-17266181 ] Andras Gyori commented on YARN-10506: - Thanks [~zhuqi], you are right, but I realized the whole logic

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266170#comment-17266170 ] zhuqi commented on YARN-10506: -- [~gandras] Here should be changed to : {code:java} if (parentQueue != null

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266096#comment-17266096 ] Andras Gyori commented on YARN-10506: - Thank you [~shuzirra] for the feedback, I too find out

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266081#comment-17266081 ] Gergely Pollak commented on YARN-10506: --- Thank you [~gandras] for the fix, here are a few comments,

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266061#comment-17266061 ] zhuqi commented on YARN-10506: -- Thanks for [~gandras] fix. Thanks for [~bteke] review.  The 

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Benjamin Teke (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266036#comment-17266036 ] Benjamin Teke commented on YARN-10506: -- Thanks for working on this! Checked the latest patch,

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266018#comment-17266018 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-15 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265868#comment-17265868 ] Andras Gyori commented on YARN-10506: - Thank you [~shuzirra] [~pbacsko] [~zhuqi] [~wangda] for the

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265713#comment-17265713 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265652#comment-17265652 ] Wangda Tan commented on YARN-10506: --- Thanks [~zhuqi], the latest patch looks good to me! I will wait

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265651#comment-17265651 ] zhuqi commented on YARN-10506: -- I update this and fix the check style in 013 patch. Thanks all for patient

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265618#comment-17265618 ] zhuqi commented on YARN-10506: -- It makes sense to me. Thanks to [~shuzirra]  [~pbacsko] for your patient

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265521#comment-17265521 ] Wangda Tan commented on YARN-10506: --- Sounds good, thanks [~shuzirra], [~pbacsko]. It makes sense to me,

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265208#comment-17265208 ] Gergely Pollak commented on YARN-10506: --- Actually the queue creation checks were present in the

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265149#comment-17265149 ] Wangda Tan commented on YARN-10506: --- [~pbacsko], I see, I think it makes sense. {quote}The logic must

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265144#comment-17265144 ] Peter Bacsko commented on YARN-10506: - "_It is possible when the rule checks, the queue allow

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265085#comment-17265085 ] Wangda Tan commented on YARN-10506: --- Thanks [~shuzirra], [~pbacsko], posting this comment while in the

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264977#comment-17264977 ] Peter Bacsko commented on YARN-10506: - *Clarification comment* I turned out I misunderstood

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264903#comment-17264903 ] Peter Bacsko commented on YARN-10506: - Hi guys. I haven't really contributed to this patch and

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264855#comment-17264855 ] Gergely Pollak commented on YARN-10506: --- Hi [~gandras] [~wangda], *1) How we deal with "create"

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264689#comment-17264689 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264683#comment-17264683 ] zhuqi commented on YARN-10506: --  [~gandras]  When submit without enabled mapping rules(auto create

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-14 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264673#comment-17264673 ] Andras Gyori commented on YARN-10506: - Thank you [~wangda] and [~zhuqi] for the reviews and fixes! I

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264666#comment-17264666 ] zhuqi commented on YARN-10506: -- Thanks for [~wangda] patient review.     > Update queue creation logic to

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264661#comment-17264661 ] Wangda Tan commented on YARN-10506: --- Thanks [~zhuqi], I don't have further comments, +1.  [~gandras] 

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264616#comment-17264616 ] zhuqi commented on YARN-10506: -- [~wangda] [~gandras] I have updated a patch according to [~wangda] comment,

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264397#comment-17264397 ] Wangda Tan commented on YARN-10506: --- Reg. *2) How we deal with the queue's auto-queue-creation

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264390#comment-17264390 ] Wangda Tan commented on YARN-10506: --- [~zhuqi], [~gandras],  I just took a look at the latest patch,

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264332#comment-17264332 ] Andras Gyori commented on YARN-10506: - I think javac warnings are unrelated (we did not touch any of

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264238#comment-17264238 ] Wangda Tan commented on YARN-10506: --- Can we also take care of javac warnings? > Update queue creation

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264237#comment-17264237 ] Wangda Tan commented on YARN-10506: --- Thanks [~zhuqi] and [~gandras] for quick updates!  *I will review

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264210#comment-17264210 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264151#comment-17264151 ] Andras Gyori commented on YARN-10506: - Thanks [~zhuqi] for the insights, it is indeed a good

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264113#comment-17264113 ] zhuqi commented on YARN-10506: -- Thanks for [~gandras] for the fix. Another question is when parent is 

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264108#comment-17264108 ] Andras Gyori commented on YARN-10506: - Uploaded v11 revision of patch, in which the following changes

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264071#comment-17264071 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264048#comment-17264048 ] zhuqi commented on YARN-10506: -- [~gandras]  Regarding 2.2 atomicity: The last instanceof Parent check

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264036#comment-17264036 ] Andras Gyori commented on YARN-10506: - Regarding CSQueueUtils#extractQueuePath. I think we should

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264027#comment-17264027 ] Andras Gyori commented on YARN-10506: - Regarding 2.2 atomicity: The last instanceof Parent check

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264018#comment-17264018 ] zhuqi commented on YARN-10506: -- Thank you [~gandras]  for the comment, about the ApplicationPlacementContext

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264000#comment-17264000 ] Andras Gyori commented on YARN-10506: - Thank you [~zhuqi] for the patch, I am going to build the

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-13 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263999#comment-17263999 ] Andras Gyori commented on YARN-10506: - Thank you [~wangda] for the review. My comments: # My initial

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263961#comment-17263961 ] zhuqi commented on YARN-10506: -- [~wangda] [~gandras] Thanks [~wangda] for review. I update a patch for:

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263672#comment-17263672 ] Wangda Tan commented on YARN-10506: --- Thanks for all updates, here's my comments:    1)

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263550#comment-17263550 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263457#comment-17263457 ] Wangda Tan commented on YARN-10506: --- [~zhuqi], [~gandras] can you check the findbugs warning? > Update

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263399#comment-17263399 ] zhuqi commented on YARN-10506: -- [~gandras] Thanks for including the fix. LGTM +1 Waiting for the CI. >

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263393#comment-17263393 ] Andras Gyori commented on YARN-10506: - I have uploaded a new patch, which is based on trunk with the

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-12 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263211#comment-17263211 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263118#comment-17263118 ] zhuqi commented on YARN-10506: -- [~wangda] [~gandras] Update a patch to fix two problem: # Fix 

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262789#comment-17262789 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262685#comment-17262685 ] Andras Gyori commented on YARN-10506: - Thank you [~zhuqi] it was indeed the issue. I have fixed it in

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262673#comment-17262673 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262660#comment-17262660 ] zhuqi commented on YARN-10506: -- [~wangda] [~gandras] Add an updated patch for fix all test in 

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262619#comment-17262619 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-11 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262528#comment-17262528 ] Andras Gyori commented on YARN-10506: - Combined YARN-10504-010 and YARN-10506-006 to see test

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262364#comment-17262364 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-10 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262323#comment-17262323 ] Wangda Tan commented on YARN-10506: --- Attached ver.6 combined patch (which includes YARN-10506.005

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262305#comment-17262305 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-10 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262302#comment-17262302 ] Wangda Tan commented on YARN-10506: --- Manually rebased patch on top of the latest YARN-10504 (008).

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-08 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261259#comment-17261259 ] Andras Gyori commented on YARN-10506: - Added support for placementContexts. As of now, there are two

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261258#comment-17261258 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-06 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259764#comment-17259764 ] Andras Gyori commented on YARN-10506: - Thank you [~zhuqi] for your feedback! I understand your point,

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-05 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259445#comment-17259445 ] zhuqi commented on YARN-10506: -- [~gandras] The new patch, LGTM. And we also should support template

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-04 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258220#comment-17258220 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-04 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258209#comment-17258209 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-04 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258204#comment-17258204 ] Andras Gyori commented on YARN-10506: - Fixed the test regarding mixed weight mode and capacity mode.

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-02 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257451#comment-17257451 ] Andras Gyori commented on YARN-10506: - Uploaded a new revision. Since we already have a test of

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2021-01-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257449#comment-17257449 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-22 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253943#comment-17253943 ] zhuqi commented on YARN-10506: -- [~gandras] Thanks for your reply. 1. What i said is related policy

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-22 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253687#comment-17253687 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-22 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253682#comment-17253682 ] Andras Gyori commented on YARN-10506: - I have taken your advise into account, however, I would need

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-21 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252934#comment-17252934 ] Andras Gyori commented on YARN-10506: - Thank you [~zhuqi] for the feedback! I intend to upload a new

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-21 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252919#comment-17252919 ] zhuqi commented on YARN-10506: -- [~wangda] [~gandras] When i deep into some test in 

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-14 Thread zhuqi (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248989#comment-17248989 ] zhuqi commented on YARN-10506: -- [~wangda] {quote}Handle convert of dynamic queue to static queue (still see

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248263#comment-17248263 ] Hadoop QA commented on YARN-10506: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-11 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248261#comment-17248261 ] Wangda Tan commented on YARN-10506: --- Uploaded a patch, which is based on YARN-10504. It has done the

[jira] [Commented] (YARN-10506) Update queue creation logic to use weight mode and allow the flexible static/dynamic creation

2020-12-11 Thread Wangda Tan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248048#comment-17248048 ] Wangda Tan commented on YARN-10506: --- I'm looking at PoC of the patch now, and will keep the JIRA