Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Chris Withers
Julien Anguenot wrote: The refactoring was obsious and harmless right ? Just removing hardcoded references to portal_catalog and portal_workflow within the internals of CMFCatalogAware. Well, that's not refactoring is it? You've added new functionality with the intent of allowing a new

[Zope-CMF] CMF Collector: Open Issues

2005-09-12 Thread tseaver
The following supporters have open issues assigned to them in this collector (http://www.zope.org/Collectors/CMF). Assigned and Open efge - CMFSetup: provide non-ascii im- and exports, [Accepted] http://www.zope.org/Collectors/CMF/292 - CMFSetup doesn't correctly detect

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Julien Anguenot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chris Withers wrote: Julien Anguenot wrote: The refactoring was obsious and harmless right ? Just removing hardcoded references to portal_catalog and portal_workflow within the internals of CMFCatalogAware. Well, that's not refactoring is

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Sidnei da Silva
On Mon, Sep 12, 2005 at 01:46:00PM +0200, Jean-Marc Orliaguet wrote: | Julien fixed a bug. Only poorly designed software implements hardcoded | references to paths ('portal_catalog'). And he needed it to implement a | separate catalog for portlets. So let's move on Sorry, but I totally

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Jean-Marc Orliaguet
Sidnei da Silva wrote: On Mon, Sep 12, 2005 at 01:46:00PM +0200, Jean-Marc Orliaguet wrote: | Julien fixed a bug. Only poorly designed software implements hardcoded | references to paths ('portal_catalog'). And he needed it to implement a | separate catalog for portlets. So let's move on

[Zope-CMF] Re: Small CMFCatalogAware refactoring

2005-09-12 Thread yuppie
Sidnei da Silva wrote: On Mon, Sep 12, 2005 at 01:46:00PM +0200, Jean-Marc Orliaguet wrote: | Julien fixed a bug. Only poorly designed software implements hardcoded | references to paths ('portal_catalog'). And he needed it to implement a | separate catalog for portlets. So let's move on

[Zope-CMF] Reminder: CMF 2.0 Roadmap chat

2005-09-12 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 What: public chat about the CMF 2.0 roadmap, in particular resolving issues which impact the downstream applications / frameworks (CPS and Plone, particulary). Where: irc://irc.freenode.net/#zope-cmf When: Monday, 9/12, 15:00-16:00 UTC

[Zope-CMF] Re: Small CMFCatalogAware refactoring

2005-09-12 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jean-Marc Orliaguet wrote: Julien fixed a bug. Only poorly designed software implements hardcoded references to paths ('portal_catalog'). And he needed it to implement a separate catalog for portlets. So let's move on 'portal_catalog' is not

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Sidnei da Silva
On Mon, Sep 12, 2005 at 02:03:24PM +0200, Jean-Marc Orliaguet wrote: | Hi Sidnei | the difference is that portal_catalog is both a tool and a catalog | instance (with its indexes, records...). Other CMF tools are just tools | and their path can well be hardcoded in CMF since they provide only |

[Zope-CMF] Re: [CMF-checkins] SVN: CMF/branches/1.4/CMFCore/ - Backport Jens V. changes to Geoff D.'s Caching Policy Manager branch

2005-09-12 Thread Jens Vagelpohl
On 12 Sep 2005, at 13:46, Sidnei da Silva wrote: Log message for revision 38449: - Backport Jens V. changes to Geoff D.'s Caching Policy Manager branch Sidnei, you're a bit overeager - I am still waiting for feedback from Geoff! ;) jens

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Jean-Marc Orliaguet
Sidnei da Silva wrote: On Mon, Sep 12, 2005 at 02:03:24PM +0200, Jean-Marc Orliaguet wrote: | Hi Sidnei | the difference is that portal_catalog is both a tool and a catalog | instance (with its indexes, records...). Other CMF tools are just tools | and their path can well be hardcoded in CMF

Re: [Zope-CMF] Re: [CMF-checkins] SVN: CMF/branches/1.4/CMFCore/ - Backport Jens V. changes to Geoff D.'s Caching Policy Manager branch

2005-09-12 Thread Sidnei da Silva
On Mon, Sep 12, 2005 at 01:40:35PM +0100, Jens Vagelpohl wrote: | | On 12 Sep 2005, at 13:46, Sidnei da Silva wrote: | | Log message for revision 38449: | | - Backport Jens V. changes to Geoff D.'s Caching Policy Manager | branch | | Sidnei, you're a bit overeager - I am still waiting for

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Sidnei da Silva
On Mon, Sep 12, 2005 at 02:36:21PM +0200, Jean-Marc Orliaguet wrote: | Still, the place to add indirection would be 'getToolByName'. As Tres | said above, let's not invent another component architecture. | | I agree that the correct of doing it is through the equivalent of a |

Re: [Zope-CMF] Small CMFCatalogAware refactoring

2005-09-12 Thread Jean-Marc Orliaguet
Sidnei da Silva wrote: On Mon, Sep 12, 2005 at 02:36:21PM +0200, Jean-Marc Orliaguet wrote: | Still, the place to add indirection would be 'getToolByName'. As Tres | said above, let's not invent another component architecture. | | I agree that the correct of doing it is through the equivalent of

Re: [Zope-CMF] Re: [CMF-checkins] SVN: CMF/branches/1.4/CMFCore/ - Backport Jens V. changes to Geoff D.'s Caching Policy Manager branch

2005-09-12 Thread Jens Vagelpohl
On 12 Sep 2005, at 13:42, Sidnei da Silva wrote: On Mon, Sep 12, 2005 at 01:40:35PM +0100, Jens Vagelpohl wrote: | | On 12 Sep 2005, at 13:46, Sidnei da Silva wrote: | | Log message for revision 38449: | | - Backport Jens V. changes to Geoff D.'s Caching Policy Manager | branch | | Sidnei,

[Zope-CMF] Re: Small CMFCatalogAware refactoring

2005-09-12 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jean-Marc Orliaguet wrote: then there is a list of hooks that can be migrated to the new getToolByName() when it materializes. At least this shows the need for named utilities in CMF. Those won't be named utilities; they will be adapters, with

Re: [Zope-CMF] Re: [CMF-checkins] SVN: CMF/branches/1.4/CMFCore/ - Backport Jens V. changes to Geoff D.'s Caching Policy Manager branch

2005-09-12 Thread Sidnei da Silva
On Mon, Sep 12, 2005 at 01:54:38PM +0100, Jens Vagelpohl wrote: | Ups! Should I back out? I've reviewed the changes and they look very | good to me. | | You don't have to back them out, you could always create a second | patch *if* there are any further changes before merging. I'm just |

Re: [Zope-CMF] Re: Small CMFCatalogAware refactoring

2005-09-12 Thread Sidnei da Silva
On Mon, Sep 12, 2005 at 09:10:02AM -0400, Tres Seaver wrote: | -BEGIN PGP SIGNED MESSAGE- | Hash: SHA1 | | Jean-Marc Orliaguet wrote: | | then there is a list of hooks that can be migrated to the new | getToolByName() when it materializes. At least this shows the need for | named

Re: [Zope-CMF] Re: Small CMFCatalogAware refactoring

2005-09-12 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sidnei da Silva wrote: On Mon, Sep 12, 2005 at 09:10:02AM -0400, Tres Seaver wrote: | -BEGIN PGP SIGNED MESSAGE- | Hash: SHA1 | | Jean-Marc Orliaguet wrote: | | then there is a list of hooks that can be migrated to the new |

Re: [Zope-CMF] Re: Re: CachingPolicyManager improvements checked in to svn

2005-09-12 Thread Jens Vagelpohl
On 12 Sep 2005, at 17:12, Geoff Davis wrote: On Sat, 10 Sep 2005 16:04:18 +0100, Jens Vagelpohl wrote: Here's the result of my refactoring/rewriting for the tests in question: http://svn.zope.org/CMF/branches/geoffd-cachingpolicymanager-branch/? rev=38439view=rev Geoff, as the one with