Re: [Zope-dev] Zope3 server control machinery is untested
On Tue, Feb 19, 2008 at 3:10 PM, Jim Fulton <[EMAIL PROTECTED]> wrote: > It can't be that useful since restart doesn't work and no one bothered > to write a test for this functionality. It's less useful in Zope3 than in Zope2, that's for sure. -- Lennart Regebro: Zope and Plone consulting. http://www.colliberty.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope3 server control machinery is untested
On Feb 19, 2008, at 8:59 AM, Lennart Regebro wrote: On Tue, Feb 19, 2008 at 12:43 PM, Jim Fulton <[EMAIL PROTECTED]> wrote: This only applies to Zope3 developers and people using the Zope 3 ZMI. I'm trying to get rid of ThreadedAsync. zope.app.server uses it to cause the asyncore main loop to stop as part of the server-control functionality. There are no tests for this afaict. Trying this throigh the web, shutdown seems to work, but not restart. (It looks like restart doesn't work because the exit status os only used to exit the loop. It isn't used in the call to sys.exit.) I propose, at least, to remove this untested functionality from zope.app.server. I'd be for removing it from zope.app.twisted, if it is there, and for removing the UI from zope.app.applicationcontrol. Thoughts? Does this mean you remove the possibility to shutdown or restart a Zope3 server from the ZMI? Yes. That is a quite practical thing to be able to do, especially when you don't know with what user the server has been started with so you can't stop or restart it from the command line... It can't be that useful since restart doesn't work and no one bothered to write a test for this functionality. The run-time information tab provides the pid, so shutting down from the command line should be straightforward. Jim -- Jim Fulton Zope Corporation ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope3 server control machinery is untested
On Tue, Feb 19, 2008 at 12:43 PM, Jim Fulton <[EMAIL PROTECTED]> wrote: > This only applies to Zope3 developers and people using the Zope 3 ZMI. > > I'm trying to get rid of ThreadedAsync. zope.app.server uses it to > cause the asyncore main loop to stop as part of the server-control > functionality. > > There are no tests for this afaict. Trying this throigh the web, > shutdown seems to work, but not restart. (It looks like restart > doesn't work because the exit status os only used to exit the loop. It > isn't used in the call to sys.exit.) > > I propose, at least, to remove this untested functionality from > zope.app.server. > > I'd be for removing it from zope.app.twisted, if it is there, and for > removing the UI from zope.app.applicationcontrol. > > Thoughts? Does this mean you remove the possibility to shutdown or restart a Zope3 server from the ZMI? That is a quite practical thing to be able to do, especially when you don't know with what user the server has been started with so you can't stop or restart it from the command line... -- Lennart Regebro: Zope and Plone consulting. http://www.colliberty.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope3 server control machinery is untested
Hi, Jim Fulton schrieb: This only applies to Zope3 developers and people using the Zope 3 ZMI. I'm trying to get rid of ThreadedAsync. zope.app.server uses it to cause the asyncore main loop to stop as part of the server-control functionality. There are no tests for this afaict. Trying this throigh the web, shutdown seems to work, but not restart. (It looks like restart doesn't work because the exit status os only used to exit the loop. It isn't used in the call to sys.exit.) I propose, at least, to remove this untested functionality from zope.app.server. I'd be for removing it from zope.app.twisted, if it is there, and for removing the UI from zope.app.applicationcontrol. > Thoughts? That code sounds very familiar and reminds me of my first sprint. IIRC we opted out testing this code because we didn't know how to do that. Personally I haven't been using this button at all the console scripts are much more convenient for me. grok currently exposes the functionality in a very accessible way through the standard UI though. Christian -- gocept gmbh & co. kg - forsterstrasse 29 - 06112 halle (saale) - germany www.gocept.com - [EMAIL PROTECTED] - phone +49 345 122 9889 7 - fax +49 345 122 9889 1 - zope and plone consulting and development ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope3 server control machinery is untested
This only applies to Zope3 developers and people using the Zope 3 ZMI. I'm trying to get rid of ThreadedAsync. zope.app.server uses it to cause the asyncore main loop to stop as part of the server-control functionality. There are no tests for this afaict. Trying this throigh the web, shutdown seems to work, but not restart. (It looks like restart doesn't work because the exit status os only used to exit the loop. It isn't used in the call to sys.exit.) I propose, at least, to remove this untested functionality from zope.app.server. I'd be for removing it from zope.app.twisted, if it is there, and for removing the UI from zope.app.applicationcontrol. Thoughts? JIm -- Jim Fulton Zope Corporation ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
