Re: [Zope-dev] Logging of ConflictError

2005-12-05 Thread Chris Withers
Dennis Allison wrote: Dieter's point about not includeing the traceback makes sense if all it does is report on the reporting code. Yeah, the traceback just shows where the ConflictError was raised, not what caused it, and theyr'e always in very different places... Wlorent, do you envision

Re: [Zope-dev] Logging of ConflictError

2005-12-05 Thread Chris Withers
Florent Guillaume wrote: If you look at the way their purpose is explained in zLOG, you'll see that level INFO is reserved for things like server startup and shutdown. You must be one of the few humans who's ever read that documentation ;-) recurring that can happen many times in the lif

Re: [Zope-dev] Logging of ConflictError

2005-12-04 Thread Dennis Allison
Dieter's point about not includeing the traceback makes sense if all it does is report on the reporting code. Wlorent, do you envision a single ConflicError or two -- one which succeeds on retry and another where the retry fails? On Sun, 4 Dec 2005, Dieter Maurer wrote: > Florent Guillaume wro

Re: [Zope-dev] Logging of ConflictError

2005-12-04 Thread Dieter Maurer
Florent Guillaume wrote at 2005-12-2 22:59 +0100: > ... >If you look at the way their purpose is explained in zLOG, you'll see >that level INFO is reserved for things like server startup and >shutdown. >Or, as shown above, initial mounting of databases. Anything >recurring that can happen man

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Chris Withers
Paul Winkler wrote: I'm +1 on having failed retries show up at level ERROR. With Florent's changes you get 'em twice, with mine, you get 'em once ;-) I'm neutral on having successful retries show up at level INFO, BLATHER, or in some other log handler entirely. Conflict errors are a pretty

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Florent Guillaume
On 2 Dec 2005, at 20:50, Dieter Maurer wrote: Florent Guillaume wrote at 2005-12-2 13:33 +0100: ... Please no. Don't put anything at INFO. A conflict error is either something normal that should be at level BLATHER or below, or an ERROR that a sysadmin wants to see logged as such. I strongly

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Florent Guillaume
On 2 Dec 2005, at 20:40, Dieter Maurer wrote: Florent Guillaume wrote at 2005-12-1 19:49 +0100: I've improved the logging of ConflictError in Zope 2.9 and trunk. http://svn.zope.org/?rev=40454&view=rev Now you'll get two things: - logs at level BLATHER for each conflict, but it may be retried

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Dieter Maurer
Florent Guillaume wrote at 2005-12-2 13:33 +0100: > ... >Please no. Don't put anything at INFO. A conflict error is either >something normal that should be at level BLATHER or below, or an >ERROR that a sysadmin wants to see logged as such. I strongly disagree with you: "ConflictError"s are

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Dieter Maurer
Florent Guillaume wrote at 2005-12-1 19:49 +0100: >I've improved the logging of ConflictError in Zope 2.9 and trunk. > >http://svn.zope.org/?rev=40454&view=rev > >Now you'll get two things: >- logs at level BLATHER for each conflict, but it may be retried >- log at level ERROR when the conflict can

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Paul Winkler
On Fri, Dec 02, 2005 at 02:09:56PM +0100, Florent Guillaume wrote: > On 2 Dec 2005, at 11:09, Chris Withers wrote: > >I was planning on rolling my changes out to 2.8, 2.9 and the trunk. > >Unless anyone strenuously objects, I still intend to do that. I > >cleaned up a lot of the code and made a

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Jens Vagelpohl
On 2 Dec 2005, at 14:16, Chris Withers wrote: Please no. Don't put anything at INFO. A conflict error is either something normal that should be at level BLATHER or below, or an ERROR that a sysadmin wants to see logged as such. Not so. If I'm getting 1,000 resolved conflict errors a day,

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Chris Withers
Florent Guillaume wrote: Please no. Don't put anything at INFO. A conflict error is either something normal that should be at level BLATHER or below, or an ERROR that a sysadmin wants to see logged as such. INFO sucks for recurring stuff like that that in addition contain the word "error" w

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Chris Withers
Florent Guillaume wrote: Please no. Don't put anything at INFO. A conflict error is either something normal that should be at level BLATHER or below, or an ERROR that a sysadmin wants to see logged as such. Incidentally, your changes result in most users seeing two errors in their logs whe

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Chris Withers
Florent Guillaume wrote: It doesn't really matter, zLOG has a compatibility layer that ends up doing the same thing. python's logging module has a cleaner, nicer syntax. Please no. Don't put anything at INFO. A conflict error is either something normal that should be at level BLATHER or bel

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Florent Guillaume
On 2 Dec 2005, at 11:09, Chris Withers wrote: I was planning on rolling my changes out to 2.8, 2.9 and the trunk. Unless anyone strenuously objects, I still intend to do that. I cleaned up a lot of the code and made a few other changes that generally improve logging. I strenuously object t

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Florent Guillaume
On 2 Dec 2005, at 11:09, Chris Withers wrote: Damn, I was working on this at the same time :-S Florent Guillaume wrote: I've improved the logging of ConflictError in Zope 2.9 and trunk. http://svn.zope.org/?rev=40454&view=rev Now you'll get two things: - logs at level BLATHER for each conflict,

Re: [Zope-dev] Logging of ConflictError

2005-12-02 Thread Chris Withers
Hi Florent, Damn, I was working on this at the same time :-S Florent Guillaume wrote: I've improved the logging of ConflictError in Zope 2.9 and trunk. http://svn.zope.org/?rev=40454&view=rev Now you'll get two things: - logs at level BLATHER for each conflict, but it may be retried - log at

Re: [Zope-dev] Logging of ConflictError

2005-12-01 Thread Chris McDonough
+1 On Dec 1, 2005, at 1:49 PM, Florent Guillaume wrote: I've improved the logging of ConflictError in Zope 2.9 and trunk. http://svn.zope.org/?rev=40454&view=rev Now you'll get two things: - logs at level BLATHER for each conflict, but it may be retried - log at level ERROR when the conflict