Benji York wrote:
Two of the three lines of _quote are comments about why the method
exists, is there something that you'd like added? Perhaps it shouldn't
be a method at all, but refactored to be inline (with comments).
Inline would be the way I'd go, as it'll stop people (mis)using the
met
Chris Withers wrote:
Benji York wrote:
In this case we'd have to mark all characters but the space as "safe".
This isn't the "normal" type of URI quoting issue, this problem arises
because nothing else in the call chain quotes the spaces
Ah, okay, nice to have would be a docstring to avoid p
Benji York wrote:
In this case we'd have to mark all characters but the space as "safe".
This isn't the "normal" type of URI quoting issue, this problem arises
because nothing else in the call chain quotes the spaces
Ah, okay, nice to have would be a docstring to avoid people like me
misinte
Chris Withers wrote:
Stephan Richter wrote:
I hope it would have sometimes a "?" in them, since this is a
totally valid character. also ":" will be in 90% of the URLs.
True.
The idea here is that we want to support those silly apple URLs.
Not really sure what that's about. Joke?
OK, I
On Friday 09 December 2005 06:09, Chris Withers wrote:
> OK, I guess my point was that there's a perfectly good library function
> that does this, and supports marking certain characters (suchs as ':')
> as "safe" if you want them to be, so I'm curious as to why we're growing
> our own warts?
Beca
Stephan Richter wrote:
I hope it would have sometimes a "?" in them, since this is a totally valid
character. also ":" will be in 90% of the URLs. The idea here is that we want
to support those silly apple URLs.
OK, I guess my point was that there's a perfectly good library function
that does
On Thursday 08 December 2005 04:04, Chris Withers wrote:
> What happens with urls have other dodgy characters in them (?;:, etc)?
I hope it would have sometimes a "?" in them, since this is a totally valid
character. also ":" will be in 90% of the URLs. The idea here is that we want
to support t
Benji York wrote:
+def _quote(self, url):
+# the publisher expects to be able to split on whitespace, so we have
+# to make sure there is none in the URL
+return url.replace(' ', '%20')
Perhaps we should be using urllib's quote function insteead of this
class method
