Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-15 Thread Chris Hillery
More detailed commit message and Changelog entry, please. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsub

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-trace_empty-sequence into lp:zorba

2013-02-15 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-trace_empty-sequence/+merge/148825 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/archive-module-winfixes into lp:zorba/archive-module

2013-02-18 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/archive-module-winfixes into lp:zorba/archive-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/archive-module-winfixes/+merge/120438 -- https://code.launchpad.net/~zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-02-20 Thread Chris Hillery
Juan has added the canonicalize#2 function as suggested. I have pushed a couple additional comment additions, plus a preventative fix that ensures this change to the XML module won't interfere with runtime generation. Matthias, please re-review. -- https://code.launchpad.net/~zorba-coders/zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ModuleInfo into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-ModuleInfo into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-ModuleInfo/+merge/148616 -- https://code.launchpad.net/~zorba-coders/zorba/feature-M

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ModuleInfo into lp:zorba

2013-02-20 Thread Chris Hillery
Review: Needs Fixing Looks like you forgot to add xquery.cpp (test case?). You added the new parse() virtual method to the public API not at the end of the XQuery class. I don't like our XQuery API (what's the point behind creating an XQuery object that doesn't represent a query?), but I guess

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-EntityDataNS/+merge/148618 -- https://code.launchpad.net/~zorba-coders/zorba/featu

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba has been updated. Status: Approved => Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-EntityDataNS/+merge/148618 -- https://code.launchpad.net/~zorba-coders/zorba/feature-E

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba has been updated. Status: Rejected => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-EntityDataNS/+merge/148618 -- https://code.launchpad.net/~zorba-coders/zorba/featu

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-EntityDataNS/+merge/148618 -- https://code.launchpad.net/~zorba-coders/zorba/featu

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-EntityDataNS into lp:zorba

2013-02-20 Thread Chris Hillery
Review: Needs Fixing I reviewed the code and it looks OK (I fixed one small typo). Obviously the test failures need to be fixed though; I'll re-review when that's done. -- https://code.launchpad.net/~zorba-coders/zorba/feature-EntityDataNS/+merge/148618 Your team Zorba Coders is subscribed to br

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-02-20 Thread Chris Hillery
Regarding the GenZorbaRuntime.cmake change: I noticed when I merged this change locally *into an already-working build* that the build started failing. Turns out to be because GenZorbaRuntime implicitly depends on the XML module, and once the new xml.xq file was installed in URI_PATH, you couldn

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_driver/+merge/149285 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-20 Thread Chris Hillery
Sorin - looks like this works, but I'm not voting Approve yet as I know you have concerns with my latest changes. Let me know if you review them and decide they're OK, and I'll merge the proposal. -- https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_driver/+merge/149285 Your team Zorba C

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-02-21 Thread Chris Hillery
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/149845 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/149845 Your team Zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_driver/+merge/149285 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_driver/+merge/149285 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-22 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba. Commit message: Remove undesired debug output. Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1130069 in Zorba: "FOTS driver: serialization error in the outputed test case&quo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-22 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba has been updated. Commit Message changed to: Remove undesired debug output. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_driver/+merge/149987 -- https://code.launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_fots_driver into lp:zorba

2013-02-22 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_fots_driver/+merge/149987 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1131002 into lp:zorba

2013-02-22 Thread Chris Hillery
FYI, that failing test will probably pass next time. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1131002/+merge/150017 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubs

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1131002 into lp:zorba

2013-02-22 Thread Chris Hillery
Review: Approve Perfect, thanks! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1131002/+merge/150017 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://lau

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1131002 into lp:zorba

2013-02-22 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1131002 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1131002/+merge/150017 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1131002

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-tests-keys into lp:zorba/couchbase-module

2013-02-22 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/couchbase-tests-keys/+merge/150089 Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-tests-keys into lp:zorba/couchbase-module

2013-02-22 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/couchbase-tests-keys into lp:zorba/couchbase-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/couchbase-tests-keys/+merge/150089 -- https://code.launchpad.net/~zorba-c

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1129950 into lp:zorba

2013-02-22 Thread Chris Hillery
Review: Approve I'm curious about the answer to Matthias' question as well. However, things run valgrind-clean (including no leaks) with and without the explicit call to xqxq:delete-query() in the query, so I'm assuming that it DOES get cleaned up somewhere. -- https://code.launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1129950 into lp:zorba

2013-02-22 Thread Chris Hillery
(My guess is that since theQueryMap contains QueryData_t objects - ie, smart pointers - they are reclaimed when theQueryMap is deleted because theQueryMap was the last object maintain a refcount on them.) -- https://code.launchpad.net/~zorba-coders/zorba/bug1129950/+merge/150105 Your team Zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1017924 into lp:zorba

2013-02-25 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1017924/+merge/150430 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1017924 into lp:zorba

2013-02-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1017924 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1017924/+merge/150430 -- https://code.launchpad.net/~zorba-coders/zorba/bug1017924/+merge/150430

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_assert_xml into lp:zorba

2013-02-25 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_assert_xml/+merge/150353 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_assert_xml into lp:zorba

2013-02-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_assert_xml into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_assert_xml/+merge/150353 -- https://code.launchpad.net/~zorba-coders/zorba/fix_assert_xml/+m

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-25 Thread Chris Hillery
Review: Approve I do have two minor points, but they're just about comments so I'll go ahead and leave my Approve vote too. First, one minor typo: "ahe" instead of "the" in regex.cpp. Second, question about comment: // // The '=' is neither the first or last character within a /

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1123161 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/1487

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-25 Thread Chris Hillery
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-25 Thread Chris Hillery
I re-voted to prevent this RQ run from succeeding, because it won't have Paul's typo fixes in it. I'll re-start it in a bit. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.ne

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-25 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123161 into lp:zorba

2013-02-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1123161 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/1487

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/gen-flwor-opt into lp:zorba

2013-02-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/gen-flwor-opt into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/gen-flwor-opt/+merge/147161 -- https://code.launchpad.net/~zorba-coders/zorba/gen-flwor-opt/+merg

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1064978 into lp:zorba

2013-02-27 Thread Chris Hillery
Review: Needs Fixing 1. Need some test cases of this functionality, including error conditions, for both new functions. 2. For the element() case, I think you should use the x:parse() function in the built-in XML module (http://www.zorba-xquery.com/modules/xml) with the "parse-external-parsed-

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba

2013-02-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba

2013-02-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769 -- https://code.launchpad.net/~zorba-coders/zorba/update_

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-02-27 Thread Chris Hillery
> - There should be a private canonicalize function that does the schema > validation if the input is not validated similarly to most other modules. Matthias: could you give an example from other modules of what you're referring to here? -- https://code.launchpad.net/~zorba-coders/zorba/canonica

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/read-pdf-installer-changes into lp:zorba/read-pdf-module

2013-02-27 Thread Chris Hillery
Review: Needs Fixing I'm afraid this won't work. We have to use ZORBA_FIND_JAR(), or else it's very inconvenient to build this module using downloaded jars (not from the Ubuntu repository). We will need to find some way to make that macro available for the PPA building situation. (Or, possibly

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-03-05 Thread Chris Hillery
Review: Needs Fixing I just realized that the set of options for canonicalization (as proposed by Matthias) are overlapping with the options that already exist for XML parsing. But the current implementation adds an entirely new set of options. This looks pretty silly, and is a waste of code.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-03-05 Thread Chris Hillery
My proposal: 1. Add a new method: int store::LoadProperties::toLibXmlOptions() The implementation of this method should be copied from zorba::simplestore::XmlLoader::applyLoadOptions() (minus the final call to xmlCtxtUseOptions() ), and applyLoadOptions() should of course be refactored to call

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-03-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-03-06 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-03-06 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-03-07 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/hof-merge into lp:zorba

2013-03-11 Thread Chris Hillery
I believe I agree, for what it's worth. I can't think of any reason an end user would want or need to disable hof. -- https://code.launchpad.net/~zorba-coders/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Needs Fixing 1. Unless I'm missing something, we don't want the function util:replace-entity-references(). The result of calling fn:serialize() should be exactly the XML we wish to canonicalize; if it contains < and > then there's a problem. 2. I also don't like the $actualResult1 / $a

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba

2013-03-12 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsub

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove-wordlists into lp:zorba

2013-03-13 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/remove-wordlists into lp:zorba has been updated. Commit Message changed to: Removed unused "wordlists" folder. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/remove-wordlists/+merge/153187 -- https://code.launchpad.net/~zorba-

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove-wordlists into lp:zorba

2013-03-13 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/remove-wordlists/+merge/153187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update_FOTS_snapshot into lp:zorba

2013-03-18 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update_FOTS_snapshot/+merge/153683 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update_FOTS_snapshot into lp:zorba

2013-03-18 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/update_FOTS_snapshot into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update_FOTS_snapshot/+merge/153683 -- https://code.launchpad.net/~zorba-coders/zorba/updat

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba

2013-03-18 Thread Chris Hillery
Review: Needs Fixing The ctest tests should not be run with verbose enabled. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1134403/+merge/153784 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@l

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba

2013-03-19 Thread Chris Hillery
Review: Approve What I wanted: - verbose=false => passing tests shown condensed, failing tests shown in full - verbose=true => all tests shown in full - ctest in "fots-activate-sets" mode uses verbose=false, and in "fots-activate-cases" mode uses verbose=true What you did: - verbose=false =>

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba

2013-03-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1134403/+merge/153784 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1134403

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot_March_20 into lp:zorba

2013-03-20 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_March_20/+merge/154269 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-import-fots into lp:zorba. Commit message: Fix erroneous ELSEIF() condition. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-import-fots into lp:zorba has been updated. Commit Message changed to: Fix erroneous ELSEIF() condition. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 -- https://code.launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123162 into lp:zorba

2013-03-20 Thread Chris Hillery
Sorry, I killed this merge, because until https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 is merged the RQ won't even run the FOTS tests. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123162/+merge/154529 Your team Zorba Coders is subscribed to branch lp:zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-import-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 -- https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot_March_21 into lp:zorba

2013-03-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_March_21/+merge/154793 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123842 into lp:zorba

2013-03-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123842/+merge/154671 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123842 into lp:zorba

2013-03-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1123842 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123842/+merge/154671 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123842

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/FOTS_run_time_decrease into lp:zorba

2013-03-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/FOTS_run_time_decrease/+merge/155598 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.ne

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/FOTS_run_time_decrease into lp:zorba

2013-03-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/FOTS_run_time_decrease into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/FOTS_run_time_decrease/+merge/155598 -- https://code.launchpad.net/~zorba-coders/zorba/F

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba

2013-03-26 Thread Chris Hillery
Review: Approve Juan - I've updated the branch to remove the EXPECTED_FOTS_FAILURE()s for 8 more tests - fn-nilled-38, 39, 41, 44, 45, 47, 51, and 52. Sorin, please confirm that these are the tests you mentioned (your link above doesn't go anywhere useful, I'm afraid). Also Juan - at least her

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba

2013-03-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba

2013-03-26 Thread Chris Hillery
Review: Needs Information I don't think it's correct to try deep-equal() for test cases. Certainly this doesn't match with the description of that assertion at http://dev.w3.org/2011/QT3-test-suite/catalog-schema.html#elem_assert-xml . Can you tell me why you did that? I'm also confused how th

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixing_issues_FOTS_driver/+merge/155294 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixing_issues_FOTS_driver/+merge/155294 -- https://code.launchpad.net/~zorba-coders/z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1132937/+merge/155640 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-03-27 Thread Chris Hillery
If xs:dateTimeStamp can be added quickly, do it as part of this merge. If it'll take more than a few hours, file a separate bug and propose the change separately. -- https://code.launchpad.net/~zorba-coders/zorba/bug1132937/+merge/155640 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-03-27 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1133260 into lp:zorba. Commit message: Support global property ZORBA_PROJECT_UNAVAILABLE so non-core modules can inform Zorba build that they failed to find their dependencies. Requested reviews: Chris Hillery (ceejatec) Juan

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1133260 into lp:zorba has been updated. Commit Message changed to: Support global property ZORBA_PROJECT_UNAVAILABLE so non-core modules can inform Zorba build that they failed to find their dependencies. For more details, see: https://code.laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module

2013-03-27 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module. Commit message: Set ZORBA_PROPERTY_UNAVAILABLE when libtidy not found. Requested reviews: Chris Hillery (ceejatec) Juan Zacarias (juan457) Related bugs: Bug #1133260 in Zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module

2013-03-27 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module. Commit message: Set ZORBA_PROJECT_UNAVAILABLE when OpenSSL not found. Requested reviews: Chris Hillery (ceejatec) Juan Zacarias (juan457) Related bugs: Bug #1133260 in

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/security-module-bug-1133260/+merge/155880 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1133260/+merge/155879 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1133260/+merge/155878 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module has been updated. Commit Message changed to: Set ZORBA_PROPERTY_UNAVAILABLE when libtidy not found. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1133260/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module has been updated. Commit Message changed to: Set ZORBA_PROJECT_UNAVAILABLE when OpenSSL not found. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/security-module-bug-113

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Chris Hillery
Review: Approve The changes seem OK for now; however, they don't actually *fix* the two related bugs, do they? -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.ne

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Chris Hillery
Review: Approve As they were likely unused, I don't have a problem with those removals. Not sure how to handle this situation more generally going forward. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322 Your team Zorba Coders is subscribed to branch lp:zorba. -- Ma

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/1563

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module. Commit message: Insert Authorization header as first node into http:request element, so it will always be valid according to the schema. Requested reviews: Matthias Brantner (matthias

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module has been updated. Commit Message changed to: Insert Authorization header as first node into http:request element, so it will always be valid according to the schema. For more details, see: https://code.lau

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-oauth-header/+merge/156450 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launc

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/155778 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module. Commit message: Handle HTTP redirects manually, so we create a unique nonce for each request. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module has been updated. Commit Message changed to: Handle HTTP redirects manually, so we create a unique nonce for each request. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-oauth-r

  1   2   3   4   5   6   7   8   9   10   >