On Thu, 14 Nov 2024 21:35:52 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping >> code, and adds an old test that we call the verifier for redefining a class, >> even one in the bootclass path. >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Updated the test with some comments. Hi Coleen, I agree with David here, I've no clue how this fixes the problem :). Could you expand on how this fix works? src/hotspot/share/classfile/verifier.cpp line 114: > 112: } > 113: > 114: // This method determines whether we allow package access in access > checks in reflection. Style: "This method" prefix isn't necessary. Maybe just "Determine whether..."? or "Do we ...?" or "Returns true if and only if ..." ------------- PR Review: https://git.openjdk.org/jdk/pull/22116#pullrequestreview-2438240723 PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1843558145
