On Fri, 15 Nov 2024 10:29:33 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated the test with some comments. > > src/hotspot/share/classfile/verifier.cpp line 114: > >> 112: } >> 113: >> 114: // This method determines whether we allow package access in access >> checks in reflection. > > Style: "This method" prefix isn't necessary. Maybe just "Determine > whether..."? or "Do we ...?" or "Returns true if and only if ..." I added "This method" because the two methods right next to each other look the same but are different. I want to say this one does one thing and this other one does something subtly different. And it makes it a complete sentence. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1844024244
