On Fri, 15 Nov 2024 05:19:58 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reduce test, fix bug in verifier, move and add comments to >> is_eligible_for_verification. > > src/hotspot/share/classfile/verifier.cpp line 280: > >> 278: >> 279: return (should_verify_class && >> 280: // return if the class is a bootstrapping class > > This method should have a comment explaining what the eligibility criteria is > and how/why `should_verify_class` should be set in different conditions. I moved the function near should_verify_for, so it would be clear what this does and why, and added a comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1846549059
