On Fri, 15 Nov 2024 05:23:24 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated the test with some comments.
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyError.java
> line 90:
>
>> 88: }
>> 89:
>> 90: { // broken method
>
> Please add a comment showing the Java code this asm is implementing.
This test came from asmifying java.lang.VerifyError and hacking it to have a
VerifyError. The code it's implementing is a lot of code and not interesting.
I can try cutting some things out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1843688929
