On Fri, 16 Oct 2026 07:28:56 GMT, Stefan Karlsson <[email protected]> wrote:
>> Patrick Fontanilla has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment to declaration of _workers > > src/hotspot/share/services/heapDumper.cpp line 2666: > >> 2664: } >> 2665: >> 2666: prepare_parallel_dump(workers); > > The `prepare_parallel_dump` function looks at "active workers" and adjusts > `_num_dumper_theads` accordingly. It seems like there's some kind of > circularity going on there. Could you take a look at that and make sure that > the code is still necessary and doing the right thing? Maybe the setup of > active workers could be moved into `prepare_parallel_dump`? Yes, I think it makes sense if `prepare_parallel_dump` sets up the active workers instead. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33218#discussion_r4297367411
