On Fri, 16 Oct 2026 07:35:53 GMT, Stefan Karlsson <[email protected]> wrote:

>> Patrick Fontanilla has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add comment to declaration of _workers
>
> src/hotspot/share/gc/shared/gcVMOperations.cpp line 211:
> 
>> 209:   } else {
>> 210:     inspect.heap_inspection(_out, 1);
>> 211:   }
> 
> To me this seems like we have two places where we place the logic around how 
> many worker threads to use: One here, and one directly inside the 
> `heap_inspection` function. What do you think about moving all of this into 
> the `heap_inspection` function?

I agree. That would simplify things a bit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33218#discussion_r4297157419

Reply via email to