[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674712#action_12674712
]
Jared Flatow commented on SOLR-993:
-----------------------------------
Shalin: yes I saw it, I still feel the underlying issues are just as important
if not moreso. addToNamespace is probably an improvement in the API, but it is
still not clear to me how the API is meant to be used, which I can only imagine
is true for others as well. I think making the semantics for using the
VariableResolver well-defined is the most important part of the patch, as well
as this discussion.
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993.patch, SOLR-993b.patch,
> SOLR-993c.patch, SOLR-993c.patch, SOLR-993c.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
