[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jared Flatow updated SOLR-993:
------------------------------
Attachment: SOLR-993c.patch
I updated the patch to work off the trunk. The full set of changes in this
patch are as follows:
1. get rid of no-op call to removeNamespace(null) in DocBuilder
2. warn about all unresolved variables from TemplateString
3. add a getOrInsertNamespace method to VariableResolverImpl, which returns the
named namespace, creating it if it doesn't already exist. addNamespace,
addToNamespace and removeNamespace are now implemented in terms of this method
4. add a splitName method to VariableResolverImpl which breaks a name into its
hierarchical components (discussed in detail here). getOrInsertNamespace uses
this method, as does resolve
5. modify TemplateTransformer to use the new VariableResolverImpl methods and
not to warn about unresolved variables (since this was moved to TemplateString)
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch, SOLR-993c.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
