[ 
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672146#action_12672146
 ] 

Noble Paul commented on SOLR-993:
---------------------------------

# The patch would not apply if it has the patch like 
a/contrib/dataimporthandler/ .it should not have that "a" in the beginning.
# it still does not allow other characters in the namespace. We may need to 
discuss more about this
# did we open another issue for the behavior change in VariableResolver?  I 
dont see the need for so many changes if we are dealing with things separately. 
especially the resolve method

> VariableResolverImpl addNamespace overwrites entire namespace instead of 
> adding
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-993
>                 URL: https://issues.apache.org/jira/browse/SOLR-993
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Jared Flatow
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-993.patch, SOLR-993b.patch, SOLR-993c.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the 
> namespace as overwrite it. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to