[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672496#action_12672496
]
Noble Paul commented on SOLR-993:
---------------------------------
bq.The addToNamespace method relies on the new getOrInsertNamespace, and
changing the others to use this method also ensures that they will be
consistent with one another. Perhaps the logging issue should be in a separate
patch
we can easily implement addToNamespace w/o the other changes you have made . I
wish that the behavior change be implemented in a separate issue. It needs
better review. I am still not convinced about the correctness of the
implementation
BTW, I am still unable to apply the patch using tortoise svn .
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch, SOLR-993c.patch,
> SOLR-993c.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
