[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jared Flatow updated SOLR-993:
------------------------------
Attachment: SOLR-993c.patch
bq. The patch would not apply if it has the patch like
a/contrib/dataimporthandler/ .it should not have that "a" in the beginning.
Use patch -p1 (or whatever tool you are using, make the patchlevel 1). In case
somehow your tool is unable to do that, I am attaching a patch without the
prefixes.
bq. it still does not allow other characters in the namespace. We may need to
discuss more about this
Sure, which other characters should be allowed?
bq. I dont see the need for so many changes if we are dealing with things
separately. especially the resolve method
ISTM the changes are all interrelated. The addToNamespace method relies on the
new getOrInsertNamespace, and changing the others to use this method also
ensures that they will be consistent with one another. Perhaps the logging
issue should be in a separate patch...?
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch, SOLR-993c.patch,
> SOLR-993c.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
