URL: https://github.com/SSSD/sssd/pull/52 Author: lslebodn Title: #52: CI: Remove dlopen-test from valgrind blacklist Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/52/head:pr52 git checkout pr52
From b88f0bd9bb6442a923fc82b7d8b198383d5b6c67 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <[email protected]> Date: Thu, 29 Sep 2016 13:45:04 +0200 Subject: [PATCH] CI: Remove dlopen-test from valgrind blacklist Dlopen test was added to blacklist due to following reason: > Disable running dlopen-tests under Valgrind as their use of dlclose > makes Valgrind drop symbols and produce meaningless backtraces, which > cannot be matched with specific suppressions. It's true that dlclose makes meaningless backtraces but backtraces should not be generated otherwise there is a bug in some library which need to be fixed and not suppressed. --- contrib/ci/run | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/ci/run b/contrib/ci/run index f96476f..a2f7f4f 100755 --- a/contrib/ci/run +++ b/contrib/ci/run @@ -187,8 +187,8 @@ function build_debug() { # Extended glob pattern matching tests to run under Valgrind. # NOTE: The particular pattern below is inverted - declare -r valgrind_test_pattern="\ - !(*.py|*/dlopen-tests|*/whitespace_test|*/double_semicolon_test)" + declare valgrind_test_pattern="!(*.py|*/whitespace_test|" + declare -r valgrind_test_pattern+="*/double_semicolon_test)" export CFLAGS="$DEBUG_CFLAGS" declare test_dir declare test_dir_distcheck
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
