Antoine Martin wrote: >> How is this related? The bug my E-Mail was referring to was in the OS X >> linker, and the patch that worked around it in the TigerVNC build has >> been checked in to trunk for quite some time. > Was this before or after 1.0 was released? > I was building from the tigervnc-1.0.0.tar and I still get this > alignment issue: > > ld: in ./.libs/libjpeg.a(jiss2int.o), malformed .o file, symbol > _jconst_idct_islow_sse2 with address 0x969 is not with section 2 > (__DATA,__const) address range of 0x970 to 0xA20
After. I thought that the issue only affected 64-bit builds, but now I see that it affects 32-bit builds as well, if NASM 2.07 is used. Thus, I created the attached patch which should be applied against the 1.0 branch to allow it to be built with NASM 2.07 or later on Mac. This is a subset of r3910. It is also necessary to apply r3903 (the fls() rename patch) from trunk to get the 1.0 branch to build on OS/X 10.5 or later. >> I have not seen the >> problem with fls() that you describe above. Under what circumstances do >> you see that? > Just a normal build (as above): cd tigervnc-1.0.0/unix && ./configure && > make > > Not sure how to build from svn as there is no "./configure" script in > there and automake barfs at me with all sorts of errors on osx. > How do you create a full release tigervnc-X.X.X.tar from an svn tree? In the 1.0 branch, you do cd unix autoreconf -fiv configure {configure arguments} make in trunk, you leave out the 'cd unix' part. The trunk also has convenience scripts under release/ that you can use. >> I've tried 'port upgrade nasm' and also doing a clean >> uninstall/reinstall of nasm, but it still gives me 2.05.01. >> > I'm new to macports, I'll assume you've run "port sync" recently and > that your $PATH is correct. Yes, port sync did the trick. Thanks for the tip. > PS: this message is off-list, is this intentional? The list is configured so that you have to Reply-All to get the replies to go back to the list, and sometimes I forget to do so.
Index: common/jpeg/simd/jimmxfst.asm =================================================================== --- common/jpeg/simd/jimmxfst.asm (revision 3945) +++ common/jpeg/simd/jimmxfst.asm (working copy) @@ -495,3 +495,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcqntmmx.asm =================================================================== --- common/jpeg/simd/jcqntmmx.asm (revision 3945) +++ common/jpeg/simd/jcqntmmx.asm (working copy) @@ -269,3 +269,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jfss2fst.asm =================================================================== --- common/jpeg/simd/jfss2fst.asm (revision 3945) +++ common/jpeg/simd/jfss2fst.asm (working copy) @@ -399,3 +399,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jiss2fst.asm =================================================================== --- common/jpeg/simd/jiss2fst.asm (revision 3945) +++ common/jpeg/simd/jiss2fst.asm (working copy) @@ -497,3 +497,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jf3dnflt.asm =================================================================== --- common/jpeg/simd/jf3dnflt.asm (revision 3945) +++ common/jpeg/simd/jf3dnflt.asm (working copy) @@ -315,3 +315,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/ji3dnflt.asm =================================================================== --- common/jpeg/simd/ji3dnflt.asm (revision 3945) +++ common/jpeg/simd/ji3dnflt.asm (working copy) @@ -447,3 +447,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jsimdcpu.asm =================================================================== --- common/jpeg/simd/jsimdcpu.asm (revision 3945) +++ common/jpeg/simd/jsimdcpu.asm (working copy) @@ -100,3 +100,6 @@ pop ebx ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcsammmx.asm =================================================================== --- common/jpeg/simd/jcsammmx.asm (revision 3945) +++ common/jpeg/simd/jcsammmx.asm (working copy) @@ -319,3 +319,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jdsammmx.asm =================================================================== --- common/jpeg/simd/jdsammmx.asm (revision 3945) +++ common/jpeg/simd/jdsammmx.asm (working copy) @@ -732,3 +732,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcqnt3dn.asm =================================================================== --- common/jpeg/simd/jcqnt3dn.asm (revision 3945) +++ common/jpeg/simd/jcqnt3dn.asm (working copy) @@ -228,3 +228,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jdmrgmmx.asm =================================================================== --- common/jpeg/simd/jdmrgmmx.asm (revision 3945) +++ common/jpeg/simd/jdmrgmmx.asm (working copy) @@ -461,3 +461,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcsamss2.asm =================================================================== --- common/jpeg/simd/jcsamss2.asm (revision 3945) +++ common/jpeg/simd/jcsamss2.asm (working copy) @@ -346,3 +346,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jdsamss2.asm =================================================================== --- common/jpeg/simd/jdsamss2.asm (revision 3945) +++ common/jpeg/simd/jdsamss2.asm (working copy) @@ -724,3 +724,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcqnts2f.asm =================================================================== --- common/jpeg/simd/jcqnts2f.asm (revision 3945) +++ common/jpeg/simd/jcqnts2f.asm (working copy) @@ -166,3 +166,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jdmrgss2.asm =================================================================== --- common/jpeg/simd/jdmrgss2.asm (revision 3945) +++ common/jpeg/simd/jdmrgss2.asm (working copy) @@ -559,3 +559,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jfmmxint.asm =================================================================== --- common/jpeg/simd/jfmmxint.asm (revision 3945) +++ common/jpeg/simd/jfmmxint.asm (working copy) @@ -617,3 +617,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcqnts2i.asm =================================================================== --- common/jpeg/simd/jcqnts2i.asm (revision 3945) +++ common/jpeg/simd/jcqnts2i.asm (working copy) @@ -195,3 +195,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jimmxint.asm =================================================================== --- common/jpeg/simd/jimmxint.asm (revision 3945) +++ common/jpeg/simd/jimmxint.asm (working copy) @@ -847,3 +847,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jiss2flt.asm =================================================================== --- common/jpeg/simd/jiss2flt.asm (revision 3945) +++ common/jpeg/simd/jiss2flt.asm (working copy) @@ -493,3 +493,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jfss2int.asm =================================================================== --- common/jpeg/simd/jfss2int.asm (revision 3945) +++ common/jpeg/simd/jfss2int.asm (working copy) @@ -629,3 +629,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jiss2int.asm =================================================================== --- common/jpeg/simd/jiss2int.asm (revision 3945) +++ common/jpeg/simd/jiss2int.asm (working copy) @@ -854,3 +854,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jimmxred.asm =================================================================== --- common/jpeg/simd/jimmxred.asm (revision 3945) +++ common/jpeg/simd/jimmxred.asm (working copy) @@ -701,3 +701,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcclrmmx.asm =================================================================== --- common/jpeg/simd/jcclrmmx.asm (revision 3945) +++ common/jpeg/simd/jcclrmmx.asm (working copy) @@ -474,3 +474,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jdclrmmx.asm =================================================================== --- common/jpeg/simd/jdclrmmx.asm (revision 3945) +++ common/jpeg/simd/jdclrmmx.asm (working copy) @@ -402,3 +402,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jfsseflt.asm =================================================================== --- common/jpeg/simd/jfsseflt.asm (revision 3945) +++ common/jpeg/simd/jfsseflt.asm (working copy) @@ -365,3 +365,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jisseflt.asm =================================================================== --- common/jpeg/simd/jisseflt.asm (revision 3945) +++ common/jpeg/simd/jisseflt.asm (working copy) @@ -567,3 +567,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcclrss2.asm =================================================================== --- common/jpeg/simd/jcclrss2.asm (revision 3945) +++ common/jpeg/simd/jcclrss2.asm (working copy) @@ -500,3 +500,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jiss2red.asm =================================================================== --- common/jpeg/simd/jiss2red.asm (revision 3945) +++ common/jpeg/simd/jiss2red.asm (working copy) @@ -589,3 +589,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jdclrss2.asm =================================================================== --- common/jpeg/simd/jdclrss2.asm (revision 3945) +++ common/jpeg/simd/jdclrss2.asm (working copy) @@ -500,3 +500,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jcqntsse.asm =================================================================== --- common/jpeg/simd/jcqntsse.asm (revision 3945) +++ common/jpeg/simd/jcqntsse.asm (working copy) @@ -206,3 +206,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16 Index: common/jpeg/simd/jfmmxfst.asm =================================================================== --- common/jpeg/simd/jfmmxfst.asm (revision 3945) +++ common/jpeg/simd/jfmmxfst.asm (working copy) @@ -392,3 +392,6 @@ pop ebp ret +; For some reason, the OS X linker does not honor the request to align the +; segment unless we do this. + align 16
------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel