Rod Evans wrote:
<snip>
That's a lot of interesting comments.
Side note: I think think the dump+elfdump combo is used to provide more
robust diff detection (to prevent a case where the actual difference
gets lost thanks to an error in elfdump pretty printing functions) and
also to push the complexity (pretty printing) until after it's known
that there is actually a difference.
Some of the stuff in wsdiff I've lost track of. For example, ignoring
the .plt, .rela.bss, .rela-plt ... perhaps there were compiler changes
that resulted in different code relocations that caused these to change,
but there really was no real change to the files "content". I don't
recall. I don't recall the sections_preferred stuff either.
I'd bet most of this comes from Eric's experience with comparing onnv
proto areas.
Anyway, this is just me thinking out loud. A single elfdump() invocation
would certainly be faster, but whether a directory of section-files
would allow for more parallelization, or offer an easier more flexibly
environment in which to architect wsdiff I don't know.
Perhaps the wsdiff maintainers have an idea of what would make their life
easier?
Dunno who is wsdiff maintainer but I think in terms of performance the
ultimate solution (although a bit of a overkill) would be to avoid the
fork()+exec(elfdump) completely. This would require python bindings for
libelf.so (libelfdump.so ?).
v.
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
