That makes sense, the scripts should come from the version
of tomcat being used. And if a version of tomcat is not
present i.e. $TOMCAT_HOME is not defined then the build
should fail.
+1
On taking the goodies from the tomcat directories. But I don't
think you need the webapps.
jvz.
> Note that I did _not_ include src\bin and src\conf in that list. I think that
> the contents of these directories (which is currently nothing more than some
> files from some unknown snapshot of Tomcat) should also be retrieved from CVS
> (or the like).
>
> I think you should only have to point TDK to any TOMCAT_HOME, and it should be
> able to build a fully-runnable installation. If we include Tomcat execution
> scripts (i.e., the current contents of src\bin) and/or Tomcat configuration
> files (i.e., the current contents of src\conf), we indirectly tie the TDK to a
> specific release of Tomcat. (For instance, Tomcat 3.3 dev (the main Tomcat
> branch) does _not_ work with the files currently in src\bin and src\conf.) Of
> course, it makes perfect sense to tie a TDK release to a specific Tomcat
> release. However, there should be no reason why you can't use TDK CVS with
> Tomcat CVS.
>
> So, my proposal...remove the following TDK directories and simply grab them from
> TOMCAT_HOME at build time:
> tdk.new/src/bin
> tdk.new/src/conf
>
> Taken to its extreme, this translates to the following lines (abridged for
> clarity):
> build-tdk.sh:
> if test -z "${TOMCAT_HOME}" ; then
> TOMCAT_HOME=../../dist/tomcat
> fi
>
> java org.apache.tools.ant.Main -Dtomcat.home=${TOMCAT_HOME} "$@"
>
> build-tdk.xml:
> <copydir src="${tomcat.home}/bin" dest="${tdk.dist}/bin"/>
> <copydir src="${tomcat.home}/conf" dest="${tdk.dist}/conf"/>
> <copydir src="${tomcat.home}/lib" dest="${tdk.dist}/lib"/>
> <copydir src="${tomcat.home}/webapps" dest="${tdk.dist}/webapps"/>
>
> Comments?
>
> --
> Christopher Elkins
>
>
>
> ------------------------------------------------------------
> To subscribe: [EMAIL PROTECTED]
> To unsubscribe: [EMAIL PROTECTED]
> Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
> Problems?: [EMAIL PROTECTED]
>
>
--
Jason van Zyl
[EMAIL PROTECTED]
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
