The overall direction looks good. Thanks for working on this!
I am not too happy about the duplication of the classes in the API, so I
have
added Jochen to comment on this.
Before this is landed, there should be some better test coverage of all
this.
What are your plans here?
(I am also assuming that this will be hidden behind a flag.)
https://codereview.chromium.org/1069883002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1069883002/diff/1/src/bootstrapper.cc#newcode194
src/bootstrapper.cc:194: bool is_shared);
Could you introduce an enum for the various places where you pass the
is_shared flag? That would make it easier to read the code at call
sites.
https://codereview.chromium.org/1069883002/diff/1/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/1069883002/diff/1/src/factory.h#newcode446
src/factory.h:446: Handle<JSArrayBuffer> NewJSArrayBuffer(bool is_shared
= false);
Please use an enum here and below (rather than a bool).
https://codereview.chromium.org/1069883002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1069883002/diff/1/src/objects.h#newcode10265
src/objects.h:10265: static const int kIsSharedBit = 3;
Why do you need the bit? Cannot you get the sharedness from the map?
https://codereview.chromium.org/1069883002/diff/1/src/objects.h#newcode10328
src/objects.h:10328: static const int kIsSharedOffset = kLengthOffset +
kPointerSize;
Again, why do you need the shared flag? Don't you have it on the map
already?
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
