some comments
it's unfortunate that the shared thingies have a different map - that means
that
code that handles both regular and shared typed arrays will go polymorphic
(i.e.
ultra slow)
https://codereview.chromium.org/1069883002/diff/220001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1069883002/diff/220001/include/v8.h#newcode3684
include/v8.h:3684: class V8_EXPORT Allocator { // NOLINT
why can't we use the allocator form ArrayBuffer?
https://codereview.chromium.org/1069883002/diff/220001/include/v8.h#newcode3751
include/v8.h:3751: size_t byte_length);
we should have a version that creates an internalized shared array
buffer
https://codereview.chromium.org/1069883002/diff/220001/include/v8.h#newcode3769
include/v8.h:3769: Contents Externalize();
also add GetContents() that gets the contents without externalizing
https://codereview.chromium.org/1069883002/diff/220001/include/v8.h#newcode6081
include/v8.h:6081: static void SetSharedArrayBufferAllocator(
the allocator should be per isolate and passed in via CreateParams. I'll
change the array buffer one soon to follow this pattern.
https://codereview.chromium.org/1069883002/diff/220001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/1069883002/diff/220001/src/accessors.cc#newcode103
src/accessors.cc:103: case JS_SHARED_TYPED_ARRAY_TYPE:
can shared array buffers be neutered?
https://codereview.chromium.org/1069883002/diff/220001/src/harmony-sharedtypedarray.js
File src/harmony-sharedtypedarray.js (right):
https://codereview.chromium.org/1069883002/diff/220001/src/harmony-sharedtypedarray.js#newcode86
src/harmony-sharedtypedarray.js:86: %_TypedArrayInitialize(obj,
ARRAY_ID, null, 0, byteLength);
what's the point of having an on-heap shared typed array?
https://codereview.chromium.org/1069883002/diff/220001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1069883002/diff/220001/src/objects.h#newcode10267
src/objects.h:10267: inline SharedFlag is_shared();
why is that not just a bool like the other bits?
https://codereview.chromium.org/1069883002/diff/220001/src/runtime/runtime-typedarray.cc
File src/runtime/runtime-typedarray.cc (right):
https://codereview.chromium.org/1069883002/diff/220001/src/runtime/runtime-typedarray.cc#newcode201
src/runtime/runtime-typedarray.cc:201:
DCHECK(!array_buffer->is_shared());
why? What about ArrayBuffer.transfer?
https://codereview.chromium.org/1069883002/diff/220001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/1069883002/diff/220001/tools/gyp/v8.gyp#newcode1733
tools/gyp/v8.gyp:1733: '../../src/harmony-sharedtypedarray.js',
please also update BUILD.gn
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
