https://codereview.chromium.org/1069883002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1069883002/diff/1/src/bootstrapper.cc#newcode194
src/bootstrapper.cc:194: bool is_shared);
On 2015/04/16 14:55:28, jarin wrote:
Could you introduce an enum for the various places where you pass the
is_shared
flag? That would make it easier to read the code at call sites.
Done.
https://codereview.chromium.org/1069883002/diff/1/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/1069883002/diff/1/src/factory.h#newcode446
src/factory.h:446: Handle<JSArrayBuffer> NewJSArrayBuffer(bool is_shared
= false);
On 2015/04/16 14:55:28, jarin wrote:
Please use an enum here and below (rather than a bool).
Done.
https://codereview.chromium.org/1069883002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1069883002/diff/1/src/objects.h#newcode10265
src/objects.h:10265: static const int kIsSharedBit = 3;
On 2015/04/16 14:55:28, jarin wrote:
Why do you need the bit? Cannot you get the sharedness from the map?
Do you mean from the ExternalArrayType? I currently share that
enumeration value between TypedArrays and SharedTypedArrays. I could add
new shared types, but I'm not sure how much code would need to be
duplicated then. Also, I think that will only work for TypedArrays, not
for the SharedArrayBuffer.
Or am I missing something? (quite likely :)
https://codereview.chromium.org/1069883002/diff/1/src/objects.h#newcode10328
src/objects.h:10328: static const int kIsSharedOffset = kLengthOffset +
kPointerSize;
On 2015/04/16 14:55:28, jarin wrote:
Again, why do you need the shared flag? Don't you have it on the map
already?
see above
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
