On 2015/04/17 09:06:44, binji wrote:
I'll work on some additional tests next.
I think it's worth adding tests for constructing
SharedArrayBuffers/SharedTypedArrays, ensuring that they ArrayBufferViews
cannot
be used on SharedArrayBuffers and vice-versa. Testing the "shared" part
is not
possible as it is more of a DOM feature requiring Workers and postMessage.
Is it worth copying the typedarray cctests/mjsunit tests and substituting
s/ArrayBuffer/SharedArrayBuffer/? I'm leaning toward yes; it's not nice to
have
duplicated code, but it seems wrong for the tests to assume a shared
implementation. What do you think?
I've duplicated some mjsunit tests and fixed some issues that those found.
I understand Jochen is working on some ArrayBuffer refactoring, so I'll
continue
to rebase
this patch until he's landed all his changes.
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
