https://codereview.chromium.org/1069883002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1069883002/diff/1/src/objects.h#newcode10265
src/objects.h:10265: static const int kIsSharedBit = 3;
On 2015/04/16 21:00:34, binji wrote:
On 2015/04/16 14:55:28, jarin wrote:
> Why do you need the bit? Cannot you get the sharedness from the map?
Do you mean from the ExternalArrayType? I currently share that
enumeration value
between TypedArrays and SharedTypedArrays. I could add new shared
types, but I'm
not sure how much code would need to be duplicated then. Also, I think
that will
only work for TypedArrays, not for the SharedArrayBuffer.
Or am I missing something? (quite likely :)
I was just wondering why you could not define is_shared()
{ return map()->instance_type() == JS_SHARED_ARRAY_BUFFER_TYPE; }
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
