Thanks for adding the sameValueZero tests, was missing indeed.
Almost there. My only other request is to separate out the SIMD tests from
the
ES5 tests, and move them into new files in harmony/. It would also be good
to
have a test that uses SIMD values as keys in actual maps or sets (and checks
they are rejected for weak maps), to make sure all that works correctly.
https://codereview.chromium.org/1219943002/diff/310001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1219943002/diff/310001/src/runtime.js#newcode963
src/runtime.js:963: return %Float32x4SameValue(x, y) ? true : false;
The ?: seems redundant.
https://codereview.chromium.org/1219943002/diff/310001/src/runtime.js#newcode976
src/runtime.js:976: return %Float32x4SameValueZero(x, y) ? true : false;
Same here.
https://codereview.chromium.org/1219943002/diff/310001/test/mjsunit/samevalue.js
File test/mjsunit/samevalue.js (right):
https://codereview.chromium.org/1219943002/diff/310001/test/mjsunit/samevalue.js#newcode131
test/mjsunit/samevalue.js:131:
assertTrue(sameValueBoth(SIMD.float32x4(+0, -0, NaN, 1),
Perhaps don't have NaN in here, to be sure we get the correct result for
the correct reason in all cases.
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
