Moved SIMD tests out of es5 tests (samevalue.js, object-toprimitive.js) and
into
the simd.js test file. Left Simd tests in reflect-apply.js, since it's also
in
tests/harmony.
Added hash code calculation for Float32x4 values in object.cc.
Added Set/WeakSet and Map/WeakMap tests in simd.js.
PTAL
https://codereview.chromium.org/1219943002/diff/310001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1219943002/diff/310001/src/runtime.js#newcode963
src/runtime.js:963: return %Float32x4SameValue(x, y) ? true : false;
On 2015/07/13 11:13:23, rossberg wrote:
The ?: seems redundant.
Yep, I was trying to fix a weird problem and thought it might relate to
return type. Instead, I had left the declaration of this fn out of
runtime.h. Forgot to remove this.
Done.
https://codereview.chromium.org/1219943002/diff/310001/src/runtime.js#newcode976
src/runtime.js:976: return %Float32x4SameValueZero(x, y) ? true : false;
On 2015/07/13 11:13:23, rossberg wrote:
Same here.
Done.
https://codereview.chromium.org/1219943002/diff/310001/test/mjsunit/samevalue.js
File test/mjsunit/samevalue.js (right):
https://codereview.chromium.org/1219943002/diff/310001/test/mjsunit/samevalue.js#newcode131
test/mjsunit/samevalue.js:131:
assertTrue(sameValueBoth(SIMD.float32x4(+0, -0, NaN, 1),
On 2015/07/13 11:13:23, rossberg wrote:
Perhaps don't have NaN in here, to be sure we get the correct result
for the
correct reason in all cases.
I'll separate out the tests. BTW I'll rewrite these tests once we have
replaceLane defined, to be exhaustive.
https://codereview.chromium.org/1219943002/diff/350001/test/mjsunit/object-toprimitive.js
File test/mjsunit/object-toprimitive.js (right):
https://codereview.chromium.org/1219943002/diff/350001/test/mjsunit/object-toprimitive.js#newcode110
test/mjsunit/object-toprimitive.js:110:
assertThrows('Number(SIMD.float32x4(1, 2, 3, 4))', TypeError);
I'll just delete this test - it's covered by TestToNumber in
tests/mjsunit/harmony/simd.js.
https://codereview.chromium.org/1219943002/diff/350001/test/mjsunit/samevalue.js
File test/mjsunit/samevalue.js (right):
https://codereview.chromium.org/1219943002/diff/350001/test/mjsunit/samevalue.js#newcode140
test/mjsunit/samevalue.js:140: SIMD.float32x4(+0, +0, NaN, 1)));
I'll move these to tests/mjsunit/harmony/simd.js.
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
