This change is fine with me. Although the client could achieve the same
effect
by disabling all breakpoints one by one and later reenabling some of them,
it
makes temporal deactivation of all breakpoints very simple and doesn't
require
the client to store the breakpoints data between state changes. Since it's a
common feature in debugger to temporarily deactivate all breakpoints I think
it'd be good to have it in the protocol.
http://codereview.chromium.org/2880011/diff/1/2
File src/debug-debugger.js (right):
http://codereview.chromium.org/2880011/diff/1/2#newcode1310
src/debug-debugger.js:1310: } else if (request.command ==
'setbreakpointsactivated') {
We also need a way to get current state of the breakpoint, either in a
separate request or as part of 'listbreakpoints'
http://codereview.chromium.org/2880011/diff/1/2#newcode1651
src/debug-debugger.js:1651: response.body = {};
Probably send new state in the body?
http://codereview.chromium.org/2880011/diff/1/4
File test/mjsunit/debug-set-break-points-activated.js (right):
http://codereview.chromium.org/2880011/diff/1/4#newcode1
test/mjsunit/debug-set-break-points-activated.js:1: // Copyright 2008
the V8 project authors. All rights reserved.
2008->2010
http://codereview.chromium.org/2880011/diff/1/4#newcode36
test/mjsunit/debug-set-break-points-activated.js:36: var base_request =
'"seq":0,"type":"request","command":"setbreakpointsactivated"'
style: long line
http://codereview.chromium.org/2880011/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
