http://codereview.chromium.org/2880011/diff/13001/14001 File src/debug-debugger.js (right):
http://codereview.chromium.org/2880011/diff/13001/14001#newcode85 src/debug-debugger.js:85: getter: function() { return this.value; }, On 2010/07/02 15:10:34, Yury Semikhatsky wrote:
could you rename them to get/setValue?
Done. http://codereview.chromium.org/2880011/diff/13001/14001#newcode2132 src/debug-debugger.js:2132: if (!request.arguments) { On 2010/07/02 15:10:34, Yury Semikhatsky wrote:
As discussed offline please return all properties when there is no
arguments
field.
Done. http://codereview.chromium.org/2880011/diff/13001/14001#newcode2153 src/debug-debugger.js:2153: debugger_flags[name].setter(flags[i].value); On 2010/07/02 15:10:34, Yury Semikhatsky wrote:
consider extracting debugger_flags[name] into a variable
Done. http://codereview.chromium.org/2880011/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
