http://codereview.chromium.org/2880011/diff/1/2 File src/debug-debugger.js (right):
http://codereview.chromium.org/2880011/diff/1/2#newcode1310 src/debug-debugger.js:1310: } else if (request.command == 'setbreakpointsactivated') { On 2010/07/01 16:40:45, Yury Semikhatsky wrote:
We also need a way to get current state of the breakpoint, either in a
separate
request or as part of 'listbreakpoints'
I've added listdebuggerflags request for that. http://codereview.chromium.org/2880011/diff/1/2#newcode1646 src/debug-debugger.js:1646: var activated = request.arguments.activated; On 2010/07/01 21:38:57, Peter Rybin wrote:
We may want a type enforcement here. User may have passed us an array
here and
we will store it and possibly return back later.
Done. http://codereview.chromium.org/2880011/diff/1/2#newcode1651 src/debug-debugger.js:1651: response.body = {}; On 2010/07/01 16:40:45, Yury Semikhatsky wrote:
Probably send new state in the body?
Done. http://codereview.chromium.org/2880011/diff/1/4 File test/mjsunit/debug-set-break-points-activated.js (right): http://codereview.chromium.org/2880011/diff/1/4#newcode1 test/mjsunit/debug-set-break-points-activated.js:1: // Copyright 2008 the V8 project authors. All rights reserved. On 2010/07/01 16:40:45, Yury Semikhatsky wrote:
2008->2010
Done. http://codereview.chromium.org/2880011/diff/1/4#newcode36 test/mjsunit/debug-set-break-points-activated.js:36: var base_request = '"seq":0,"type":"request","command":"setbreakpointsactivated"' On 2010/07/01 16:40:45, Yury Semikhatsky wrote:
style: long line
Done. http://codereview.chromium.org/2880011/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
