Pavel,
thanks for doing this. I have long wanted to start it myself.
Please consider the following suggestion.
I guess there are a set of global parameters that we may want to control
from a
debugger. I.e. not only break_points_activated.
It may make sense to generalize your protocol to update and read them all.
We
could have a simple map of handlers on the server side that implements
reading/writing for them.
E.g. we may want:
- suspend_on_exceptions: boolean
- string_values_truncate_limit: integer
I can't tell whether I would recommend changing this CL or considering all
this
for a future. However, since you are dealing with the protocol, maybe the
former
would be safer (not to expose temporary commands).
Peter
http://codereview.chromium.org/2880011/diff/1/2
File src/debug-debugger.js (right):
http://codereview.chromium.org/2880011/diff/1/2#newcode1646
src/debug-debugger.js:1646: var activated = request.arguments.activated;
We may want a type enforcement here. User may have passed us an array
here and we will store it and possibly return back later.
http://codereview.chromium.org/2880011/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
