http://codereview.chromium.org/2880011/diff/13001/14001 File src/debug-debugger.js (right):
http://codereview.chromium.org/2880011/diff/13001/14001#newcode85 src/debug-debugger.js:85: getter: function() { return this.value; }, could you rename them to get/setValue? http://codereview.chromium.org/2880011/diff/13001/14001#newcode2132 src/debug-debugger.js:2132: if (!request.arguments) { As discussed offline please return all properties when there is no arguments field. http://codereview.chromium.org/2880011/diff/13001/14001#newcode2153 src/debug-debugger.js:2153: debugger_flags[name].setter(flags[i].value); consider extracting debugger_flags[name] into a variable http://codereview.chromium.org/2880011/diff/13001/14002 File test/mjsunit/debug-debugger-flags.js (right): http://codereview.chromium.org/2880011/diff/13001/14002#newcode73 test/mjsunit/debug-debugger-flags.js:73: testArguments(dcp, '{"flags":[{"name":"break_points_activated","value":true}]}', true); mind 80 chars constraint http://codereview.chromium.org/2880011/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
