http://codereview.chromium.org/2880011/diff/7001/8001 File src/debug-debugger.js (right):
http://codereview.chromium.org/2880011/diff/7001/8001#newcode181 src/debug-debugger.js:181: if (!Debug.getDebuggerFlag('break_points_activated')) return false; On 2010/07/02 11:27:43, Yury Semikhatsky wrote:
I think you can use ebugger_flags.break_points_activated directly, as
long as it
happens in the debug-debugger.js
Done. http://codereview.chromium.org/2880011/diff/7001/8001#newcode2143 src/debug-debugger.js:2143: DebugCommandProcessor.prototype.setDebuggerFlagsRequest_ = function(request, response) { On 2010/07/02 11:27:43, Yury Semikhatsky wrote:
style: long line
Done. http://codereview.chromium.org/2880011/diff/7001/8001#newcode2152 src/debug-debugger.js:2152: if (typeof request.arguments[flag] != "boolean") { On 2010/07/02 11:27:43, Yury Semikhatsky wrote:
I don't think we need this check, there may be integer values or other
values. Done. http://codereview.chromium.org/2880011/diff/7001/8001#newcode2167 src/debug-debugger.js:2167: DebugCommandProcessor.prototype.listDebuggerFlagsRequest_ = function(request, response) { On 2010/07/02 11:27:43, Yury Semikhatsky wrote:
style: long line
Done. http://codereview.chromium.org/2880011/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
