On 2013/12/09 23:12:27, Michael Starzinger wrote:
This change frightens an confuses me. But I lack the necessary context to
give
constructive feedback. So I just left a few pennies for your thoughts.
Please
feel free to ignore me if I am not making any sense.
https://codereview.chromium.org/106453003/diff/20001/src/typing.cc
File src/typing.cc (right):
https://codereview.chromium.org/106453003/diff/20001/src/typing.cc#newcode578
src/typing.cc:578: &allocation_site, expr->op());
The type-inference phase sets the allocation-site that it got from the
type
feedback oracle on the AST node? That is cross-cutting across almost all
layers
of the compilation pipeline that I am aware of. Are we sure this is the
right
approach?
Why do we need a gazillion binary-op IC stubs that all embed an allocation
site?
Is that really the best way to thread one word-sized value per binary-op
AST
node from full-codegen to Crankshaft?
As discussed offline, this is quick&dirty to make it work. We really need to
improve our compiler pipeline and IC mechanisms.
https://codereview.chromium.org/106453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
