I just did a quick round, more comments later
BUT:we need the InstanceType for HAllocate!
https://codereview.chromium.org/106453003/diff/100001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/106453003/diff/100001/src/arm/code-stubs-arm.cc#newcode339
src/arm/code-stubs-arm.cc:339: }
why did you move this code?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1688
src/hydrogen.cc:1688: HAllocate* HGraphBuilder::BuildAllocate(
I like that. Are you planning to refactor other pretenuring effected
allocation call sites to use that?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1718
src/hydrogen.cc:1718: // supported string length, we bailout to the
runtime. This is done implicitly
implicitly
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1746
src/hydrogen.cc:1746: // one-byte or two-byte and set the appropriate
map.
Allocate should have the right instance type and we actually use it. If
you don't know it know, can you patch it later?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1790
src/hydrogen.cc:1790: AddStoreMapConstantNoWriteBarrier(result, map);
Why is there a write barrier emitted? We should be smart enough to not
emit a write barrier here?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1795
src/hydrogen.cc:1795: Handle<Map> map =
isolate()->factory()->cons_string_map();
Why is there a write barrier emitted?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1950
src/hydrogen.cc:1950: AddStoreMapNoWriteBarrier(result, map);
Why is there a write barrier emitted?
https://codereview.chromium.org/106453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
