Okay, getting closer!
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1720
src/hydrogen.cc:1720: // equals the max smi valie. Otherwise, for
platforms with 32-bit smis, we do
value, not valie.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1746
src/hydrogen.cc:1746: // one-byte or two-byte and set the appropriate
map.
Here you'll add the assert that the HAllocate flags would be the same,
too.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1924
src/hydrogen.cc:1924: HValue* size = AddUncasted<HShl>(length,
graph()->GetConstant1());
The shift instruction seems very low level. Any chance of
HMul::New(length, constant) working in a way to either give you a shift
operation back, or to solve this at the lithium level, with more
efficient code for power-of-2 constants?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1942
src/hydrogen.cc:1942: ~kObjectAlignmentMask)));
Could this size computation be in a method, or is there a reason why
BuildSeqStringSizeFor() can't consider this alignment issue inside?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode8890
src/hydrogen.cc:8890: return BuildStringAdd(left, right,
allocation_mode);
If you are building a stub, can you count on having an AllocationSite
from type feedback?
If so, can you assert that (I guess by asserting via a method on the
allocation_mode object).
If not, why not?
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode8904
src/hydrogen.cc:8904: if (c_left->StringValue()->length() + 1 >=
ConsString::kMinLength) {
nit: put the "base case" of empty left string first.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode8914
src/hydrogen.cc:8914: if (c_right->StringValue()->length() + 1 >=
ConsString::kMinLength) {
Same here.
https://codereview.chromium.org/106453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
