Done. PTAL
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1720
src/hydrogen.cc:1720: // equals the max smi valie. Otherwise, for
platforms with 32-bit smis, we do
On 2013/12/11 14:14:20, mvstanton wrote:
value, not valie.
Done.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1924
src/hydrogen.cc:1924: HValue* size = AddUncasted<HShl>(length,
graph()->GetConstant1());
Using HMul generates less optimal code.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode1942
src/hydrogen.cc:1942: ~kObjectAlignmentMask)));
BuildSeqStringSizeFor() is gone. This is basically an inlined version of
the last part of BuildSeqStringSizeFor().
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode8890
src/hydrogen.cc:8890: return BuildStringAdd(left, right,
allocation_mode);
No, because this code is also used for the BinaryOpICStub, which does
not get an allocation site passed in.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode8904
src/hydrogen.cc:8904: if (c_left->StringValue()->length() + 1 >=
ConsString::kMinLength) {
On 2013/12/11 14:14:20, mvstanton wrote:
nit: put the "base case" of empty left string first.
Done.
https://codereview.chromium.org/106453003/diff/100001/src/hydrogen.cc#newcode8914
src/hydrogen.cc:8914: if (c_right->StringValue()->length() + 1 >=
ConsString::kMinLength) {
On 2013/12/11 14:14:20, mvstanton wrote:
Same here.
Done.
https://codereview.chromium.org/106453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
